Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: upload_file() #7923

Merged
merged 1 commit into from Jul 19, 2019
Merged

Fix: upload_file() #7923

merged 1 commit into from Jul 19, 2019

Conversation

cfconrad
Copy link
Contributor

@cfconrad cfconrad commented Jul 17, 2019 •
edited

  • run sha1sum on a file before closing the filedescriptor lead to
    wrong sha1sum
  • use perl libs to calculate sha1sum

FIX for #7565

openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/7923 https://openqa.opensuse.org/tests/984679

@cfconrad cfconrad force-pushed the wicked_fix_offline_upload branch 2 times, most recently from a51e683 to c2f9a38 Compare July 17, 2019 21:57
@cfconrad
Fix: upload_file()
cb82a86 
* run sha1sum on a file before closing the filedescriptor lead to
  wrong sha1sum
* use perl libs to calculate sha1sum
@cfconrad cfconrad changed the title [WIP] wicked: use perl way of creating sha1sum [WIP] Fix: upload_file() Jul 18, 2019
@jlausuch jlausuch self-requested a review July 19, 2019 09:10
@cfconrad cfconrad changed the title [WIP] Fix: upload_file() Fix: upload_file() Jul 19, 2019
@cfconrad
Copy link
Contributor Author

VR: http://cfconrad-vm.qa.suse.de/tests/5089

jlausuch
jlausuch approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@jlausuch jlausuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlausuch jlausuch merged commit 700da66 into os-autoinst:master Jul 19, 2019
@cfconrad cfconrad deleted the wicked_fix_offline_upload branch September 24, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlausuch jlausuch jlausuch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cfconrad @jlausuch