Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix machinery workaround #7834

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Fix machinery workaround #7834

merged 1 commit into from
Jul 25, 2019

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Jul 9, 2019 •
edited
Loading

@asdil12 asdil12 marked this pull request as ready for review July 9, 2019 11:18
@ggardet
Copy link
Collaborator

ggardet commented Jul 9, 2019

Verification run seems to be wrong or the bug is not fixed, because latest aarch64 TW snapshot (20190705) should have the fix in.

@asdil12
Copy link
Member Author

asdil12 commented Jul 9, 2019

The workaround code was wrong all the time - I don't know how this could have ever worked.

@thardeck
Copy link

thardeck commented Jul 11, 2019 •
edited
Loading

Inspecting of aarch64 and ppc64le should be possible with Tumbleweed and machinery 1.24.1, that I have verified manually.
I did not check running machinery on these platforms but it should also work if all the required ruby packages are there.

dzedro
dzedro approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@dzedro dzedro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is not much to discuss, grep should be true to prove bug

@asdil12 asdil12 merged commit a3a5e01 into os-autoinst:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzedro dzedro dzedro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asdil12 @ggardet @thardeck @dzedro