spvm: Format all disks before the test starts #9449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
reviewed
Jan 28, 2020
| @@ -117,10 +117,15 @@ sub prepare_pvm_installation { | |||
|
|
|||
| # Delete partition table before starting installation | |||
| select_console('install-shell'); | |||
| foreach my $disk (split(',', get_var('DISK_DEVICES', 'sda'))) { | |||
There was a problem hiding this comment.
As we get rid of this variable, let's remove it from variables.md too.
There was a problem hiding this comment.
yep, but also found better solution =)
Soulofdestiny
force-pushed
the
spvm_format_multiple
branch
from
6458a17
to
c00d1fc
Compare
rwx788
reviewed
Jan 28, 2020
Soulofdestiny
force-pushed
the
spvm_format_multiple
branch
3 times, most recently
from
f2d9b3d
to
d0a1375
Compare
rwx788
reviewed
Feb 19, 2020
lib/bootloader_pvm.pm
Outdated
|
|
||
| my $disks = script_output('lsblk -n -p -l -o NAME -d -e 7,11'); | ||
| for my $d (split('\n', $disks)) { | ||
| script_run("echo 'wipefs -a $d'"); |
Soulofdestiny
force-pushed
the
spvm_format_multiple
branch
from
d0a1375
to
6acbe70
Compare
JRivrain
reviewed
Feb 21, 2020
| my $disks = script_output('lsblk -n -p -l -o NAME -d -e 7,11'); | ||
| for my $d (split('\n', $disks)) { | ||
| script_run "wipefs -a $d"; | ||
| create_encrypted_part("$d") if get_var('ENCRYPT_ACTIVATE_EXISTING'); |
There was a problem hiding this comment.
Hi, this caused s little issue here https://openqa.suse.de/tests/3909752#step/bootloader_start/36 as then in create_encrypted_part we have assert_script_run "parted -s /dev/$disk mklabel gpt";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.