Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spvm: Format all disks before the test starts #9449

Merged
merged 1 commit into from
Feb 19, 2020
Merged

spvm: Format all disks before the test starts #9449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/bootloader_pvm.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,12 @@ sub prepare_pvm_installation {

# Delete partition table before starting installation
select_console('install-shell');
foreach my $disk (split(',', get_var('DISK_DEVICES', 'sda'))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we get rid of this variable, let's remove it from variables.md too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, but also found better solution =)

script_run("wipefs -a /dev/$disk");
# For cryptlvm+activate existing scenario, create empty enrypted partition
create_encrypted_part("$disk") if get_var('ENCRYPT_ACTIVATE_EXISTING');


my $disks = script_output('lsblk -n -p -l -o NAME -d -e 7,11');
rwx788 marked this conversation as resolved.
Show resolved Hide resolved
for my $d (split('\n', $disks)) {
script_run "wipefs -a $d";
create_encrypted_part("$d") if get_var('ENCRYPT_ACTIVATE_EXISTING');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this caused s little issue here https://openqa.suse.de/tests/3909752#step/bootloader_start/36 as then in create_encrypted_part we have assert_script_run "parted -s /dev/$disk mklabel gpt";

}
# Switch to installation console (ssh or vnc)
select_console('installation');
Expand Down
1 change: 0 additions & 1 deletion variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ DEPENDENCY_RESOLVER_FLAG| boolean | false | Control whether the resolve_dep
DEV_IMAGE | boolean | false | This setting is used to set veriables properly when SDK or Development-Tools are required.
DISABLE_ONLINE_REPOS | boolean | false | Enables `installation/disable_online_repos` test module, relevant for openSUSE only. Test module explicitly disables online repos not to be used during installation.
DISABLE_SLE_UPDATES | boolean | false | Disables online updates for the installation. Is true if `QAM_MINIMAL` is true for SLE.
DISK_DEVICES | string | | Comma separated list of disk devices in the system, e.g. `sda,sdb,vda`. Can be used to format disks as a precondition for the test suite.
DISTRI | string | | Defines distribution. Possible values: `sle`, `opensuse`, `casp`, `caasp`, `microos`.
DOCRUN | boolean | false |
DUALBOOT | boolean | false | Enables dual boot configuration during the installation.
Expand Down