Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evolution for GNOME-3.34 #9529

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

zhaocongjia
Copy link
Contributor

This commit adapts evolution test cases for GNOME 3.34.

The main change is to use super-up to make sure evolution window is maximized.

The other two assert_and_click is to ensure better compatibility with other versions.

@GraceWang571

@okurz
Copy link
Member

okurz commented Feb 7, 2020

You haven't shown any verification runs for Tumbleweed but lib/main_common.pm shows that evolution_smoke is used in Tumbleweed. Because of the company policy of Factory First we should test against Tumbleweed by default (with exceptions for special packages, of course).

@zhaocongjia
Copy link
Contributor Author

This test doesn't exist in Tumbleweed yet. There was plan to add it in TW: https://progress.opensuse.org/issues/54887 , to help this upgrade in SLE15SP2, but we decided not to maintain this test in TW in the end.

@okurz
Copy link
Member

okurz commented Feb 7, 2020

That is a very unfortunate decision and I hope you rethink it (also to follow company policy) but then of course there is no impact of this PR expected on the current Tumbleweed tests.

@GraceWang571
Copy link
Contributor

We can talk about maintain of the test case in TW in https://progress.opensuse.org/issues/54887
In terms of this PR, since it has been in "open" status for more than 10 days, I will merge it later.

@GraceWang571 GraceWang571 merged commit 985742f into os-autoinst:master Feb 18, 2020
@zhaocongjia zhaocongjia deleted the fix-evolution branch March 8, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants