Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if wicked is running for yast command line tests #9811

Merged
merged 1 commit into from Mar 18, 2020
Merged

Check if wicked is running for yast command line tests #9811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/console/yast2_cmdline.pm
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ use base "y2_module_consoletest";
use strict;
use warnings;
use testapi;
use utils 'zypper_call';
use utils qw(zypper_call systemctl);
use repo_tools 'prepare_source_repo';

# Executes the command line tests from a yast repository (in master or in the
Expand Down Expand Up @@ -44,7 +44,7 @@ sub run_yast_cli_test {

sub run {
select_console 'root-console';

return if (systemctl("status wicked.service", ignore_failure => 1) != 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I believe that we need at least record info here, otherwise it's not even visible that we did nothing and have passing test. Next step will be to get proper setup to make this test suite work in TW.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create another as this has been merged, and i will ask you to review it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks a lot!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i ended up with #9862 and followup ticket have been created to solve the problem in o3

prepare_source_repo;

# Install test requirement
Expand Down