-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if wicked is running for yast command line tests #9811
Conversation
If systemctl status returns 0 then wicked is running for any other return code die. The funtion systemctl uses the output of the script_run. To do so the function is called with ignore_failure enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -44,7 +44,7 @@ sub run_yast_cli_test { | |||
|
|||
sub run { | |||
select_console 'root-console'; | |||
|
|||
return if (systemctl("status wicked.service", ignore_failure => 1) != 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I believe that we need at least record info here, otherwise it's not even visible that we did nothing and have passing test. Next step will be to get proper setup to make this test suite work in TW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will create another as this has been merged, and i will ask you to review it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i ended up with #9862 and followup ticket have been created to solve the problem in o3
If systemctl status returns 0 then wicked is running
for any other return code die.
The funtion systemctl uses the output of the script_run. To do so
the function is called with ignore_failure enabled.
nm
wicked