Check if wicked is running for yast command line tests #9811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If systemctl status returns 0 then wicked is running for any other return code die. The funtion systemctl uses the output of the script_run. To do so the function is called with ignore_failure enabled.
b10n1k
changed the title
rwx788
reviewed
Mar 23, 2020
| @@ -44,7 +44,7 @@ sub run_yast_cli_test { | |||
|
|
|||
| sub run { | |||
| select_console 'root-console'; | |||
|
|
|||
| return if (systemctl("status wicked.service", ignore_failure => 1) != 0); | |||
There was a problem hiding this comment.
Hmm, I believe that we need at least record info here, otherwise it's not even visible that we did nothing and have passing test. Next step will be to get proper setup to make this test suite work in TW.
There was a problem hiding this comment.
I will create another as this has been merged, and i will ask you to review it
There was a problem hiding this comment.
So i ended up with #9862 and followup ticket have been created to solve the problem in o3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If systemctl status returns 0 then wicked is running
for any other return code die.
The funtion systemctl uses the output of the script_run. To do so
the function is called with ignore_failure enabled.
nm
wicked