Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted envorinment variable names #219

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Adjusted envorinment variable names #219

merged 1 commit into from
Oct 27, 2022

Conversation

suppathak
Copy link
Member

Closes #218

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Shreyanand
Shreyanand reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@Shreyanand Shreyanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, thanks :) Will all the notebooks follow the same env variable names after this PR? let's make sure the standard is followed across!

Make sure the DCO check is satisfied, you'll have to add signature in the commit message like here

@erikerlandson
Copy link
Contributor

/approve

@sesheta
Copy link
Member

sesheta commented Oct 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikerlandson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@erikerlandson
Copy link
Contributor

/lgtm

@sesheta sesheta added the lgtm label Oct 27, 2022
@erikerlandson
Copy link
Contributor

looks like the commits need to be signed, like commit -asm ....

@sesheta sesheta merged commit 62e9c38 into os-climate:master Oct 27, 2022
@suppathak suppathak mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shreyanand Shreyanand Shreyanand left review comments

@chauhankaranraj chauhankaranraj Awaiting requested review from chauhankaranraj

@erikerlandson erikerlandson Awaiting requested review from erikerlandson

Assignees

@erikerlandson erikerlandson

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup-environment variable names
4 participants
@suppathak @erikerlandson @sesheta @Shreyanand