Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the environment variable name to original in order to match with elyra pipeline #225

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

suppathak
Copy link
Member

Here, we previously had adjusted the env variable names according to the format given in the documentation. This turned out to be not in match with env variable names in elyra pipeline. Hence reverting it back to its original form.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@Shreyanand Shreyanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have to sign the commit by having something like this for your commit message:
" Change the env var names to match Elyra pipeline secrets

Signed-off-by: suppathak <supathak@redhar.com"

You can amend the commit message on your local branch by using "git commit --amend" and the force push the change on your fork.
The instructions to contribute are here

Signed-off-by: Surya Prakash Pathak <supathak@redhat.com>
@suppathak
Copy link
Member Author

suppathak commented Oct 31, 2022

Thanks @Shreyanand . PHAL. The information given in the doc seemed a bit unclear to me.

The steps I followed:

- git commit --amend --signoff

...followed by the commit message...

@Shreyanand
Copy link
Member

/lgtm /approve

@sesheta
Copy link
Member

sesheta commented Oct 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit f1228d9 into os-climate:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants