feat: receive each advisory info separatly #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baruchiro
commented
Mar 15, 2023
Comment on lines
+4
to
+28
| const listener = async ({ type, detail }, port) => { | ||
| if (type === REQUEST_PACKAGE_INFO_EVENT) { | ||
| const promises = await advisories(detail); | ||
| Object.entries(promises).forEach(([part, promise]) => { | ||
| promise.then((info) => { | ||
| port.postMessage({ | ||
| type: RESPONSE_PACKAGE_INFO_EVENT, | ||
| detail: { | ||
| packageId: detail, | ||
| part, | ||
| info, | ||
| }, | ||
| }); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| return true; | ||
| }; | ||
|
|
||
| export const listen = () => { | ||
| chrome.runtime.onConnect.addListener((port) => { | ||
| port.onMessage.addListener(listener); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
The code became a deep indentation, and also I'm struggling with the objects that passed between the events, each one requires a particular property for its use case.
I'm open to suggestions.
baruchiro
force-pushed
the
baruchiro/get-package-info---from-single-response-to-async-responses-event-based
branch
from
2e91914
to
fe6518f
Compare
baruchiro
commented
Mar 15, 2023
Comment on lines
+13
to
32
| export default (packageID) => { | ||
| const depsDev = handleAsyncError(fetchDepsDev, packageID); | ||
| const info = depsDev.then((depsDevInfo) => { | ||
| const { latestVersion, licenses, stars } = depsDevInfo.data; | ||
| return { | ||
| latest: latestVersion, | ||
| licenses, | ||
| stars, | ||
| }; | ||
| }); | ||
|
|
||
| return { debricked, depsDev, openbase, snyk, socket }; | ||
| return { | ||
| debricked: handleAsyncError(fetchDebricked, packageID), | ||
| depsDev, | ||
| info, | ||
| openbase: handleAsyncError(fetchOpenbase, packageID), | ||
| snyk: handleAsyncError(fetchSnyk, packageID), | ||
| socket: handleAsyncError(fetchSocket, packageID), | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Here is the trick. Instead of returning a complete result, I returned a Promise for each key.
This allows me to add a .then to each promise, for registering a port.sendMessage at the end of each promise.
…esponse-to-async-responses-event-based # Conflicts: # src/content.stackoverflow.js
jossef
deleted the
baruchiro/get-package-info---from-single-response-to-async-responses-event-based
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26
Depends on #30
First, I moved from
messagecommunication toportcommunication, as described here.Then, I split the advisories fetching to send a message when each advisory info is fetched, instead of aggregating them all together.