Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Updated CSS of Login page buttons #132

Merged
merged 18 commits into from
Dec 29, 2021
Merged

Conversation

SachinMittal1766
Copy link
Contributor

I have updated the login page buttons. @osBins pls check it.

@osBins
Copy link
Member

osBins commented Dec 29, 2021

Hey @SachinMittal1766, the buttons look really cool now. However, when we are on the 'registration/signup' page, there is no animation on the 'Sign In' button on the top right, can you look into that?
Also, can you add a little transition animation to all the buttons so that the hover state change is not abrupt and happens smoothly?

@SachinMittal1766
Copy link
Contributor Author

Sure ! I will do it

@SachinMittal1766
Copy link
Contributor Author

@osBins I have committed all the modifications requested.

@osBins
Copy link
Member

osBins commented Dec 29, 2021

Great work @SachinMittal1766! Just one last request, can you change the 'Sign In' button on the top right of 'signup' page to say 'Log In' instead of 'Sign In'?
image

@SachinMittal1766
Copy link
Contributor Author

Done !

@osBins
Copy link
Member

osBins commented Dec 29, 2021

Awesome! Merging your PR.

@osBins osBins merged commit bffe7e7 into osPrims:main Dec 29, 2021
@osBins
Copy link
Member

osBins commented Dec 29, 2021

Is #140 resolved with this PR too?

@SachinMittal1766
Copy link
Contributor Author

No , I will make PR for it #140 by tomorrow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants