Fix filter issue where negative logic prevents matches #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quickList() method will attempt to ask the database to find filters that might match the incoming ticket information. The idea is that MySQL is likely faster than PHP. The problem is that it assumes positive logic is being utilized. This patch adds all filters with at least one rule with dn_contain (does-not-contain) or not_equal (not-equal)
protich
added a commit
that referenced
this pull request
Nov 5, 2013
Fix filter issue where negative logic prevents matches Reviewed-By: Peter Rotich <peter@osticket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quickList() method will attempt to ask the database to find filters that might match the incoming ticket information. The idea is that MySQL is likely faster than PHP. The problem is that it assumes positive logic is being utilized.
This patch adds all filters with at least one rule with dn_contain (does-not-contain) or not_equal (not-equal)
Fixes #838