xss: Prevent Shared XSS Attachments #3962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue where a User can upload an XSS infected attachment to a ticket, share the file link with another person, and the person will be able to view/download the attachment. This adds a check to see if the attachment is apart of a ticket and if it is then only Users associated with the ticket can view the attachment. You have to enable the setting ‘Login Required to view attachments’ for this to work.
JediKev
commented
Mar 10, 2020
| @@ -39,6 +39,18 @@ | |||
| require 'secure.inc.php'; | |||
| } | |||
| } | |||
| } elseif ($cfg->isAuthRequiredForFiles() && $thisclient) { | |||
There was a problem hiding this comment.
Combine into:
if ($cfg->isAuthRequiredForFiles()) {
if ($thisclient) {
xxx
} else {
xxx
}
}
JediKev
commented
Mar 10, 2020
| $attachment = $file->attachments->findFirst(); | ||
| if (($thread = $attachment->getObject()->getThread()) && $thread->getObjectType() == 'T') { | ||
| $recipients = $thread->getObject()->getRecipients(); | ||
| foreach($recipients as $r) { |
There was a problem hiding this comment.
ORM lookup is faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where a User can upload an XSS infected
attachment to a ticket, share the file link with another person, and the
person will be able to view/download the attachment. This adds a check to
see if the attachment is apart of a ticket and if it is then only Users
associated with the ticket can view the attachment. You have to enable
the setting ‘Login Required to view attachments’ for this to work.