Issue: Template Variables in Ticket Filter #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JediKev
reviewed
Jan 30, 2020
aydreeihn
force-pushed
the
issue/filter-email-vars
branch
from
12e52f4
to
ef517df
Compare
JediKev
reviewed
Feb 4, 2020
| @@ -3851,6 +3851,9 @@ static function create($vars, &$errors, $origin, $autorespond=true, | |||
| return null; | |||
|
|
|||
| /* -------------------- POST CREATE ------------------------ */ | |||
| $vars['ticket'] = $ticket; | |||
There was a problem hiding this comment.
Use only certain filters with actions like Send Email, etc.
|
It seemed like the best way to control when we run certain filter actions (before or after ticket creation) was best handled with adding the postCreate variable to the apply functions. I passed it as its own variable rather than sending it through vars because later on in the process, we start using $this->vars instead of just $vars, and it wasn't working out at the end. I'm open to suggestions though if there is a better way to make this work with a function rather than a variable. Also, it didn't seem like there were any other actions we needed to happen postCreate. Can you guys think of any we'd need to wait to run? |
aydreeihn
force-pushed
the
issue/filter-email-vars
branch
from
3313e5e
to
aeae758
Compare
aydreeihn
force-pushed
the
issue/filter-email-vars
branch
from
aeae758
to
9a58b01
Compare
protich
reviewed
Mar 3, 2020
This commit fixes an issue where you could not use template variables when using the 'Send an Email' filter action. All variables would just display as 'Array'. We needed to pass the Ticket object to FA_SendEmail::apply however, we were running the filters before the Ticket object was created. To fix this, we can add the Ticket object to vars and run the filterTicketData function again after the Ticket is created and only apply the send email filter action if the Ticket object is found.
This commit controls when we run certain types of filters. If we are sending out an email, we want those filter actions to run after the ticket is created in case template variables are used. All other types of filter actions can run before the ticket is created.
aydreeihn
force-pushed
the
issue/filter-email-vars
branch
from
9a58b01
to
8a82d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where you could not use template variables when using the 'Send an Email' filter action. All variables would just display as 'Array'.
We needed to pass the Ticket object to FA_SendEmail::apply, however, we were running the filters before the Ticket object was created. To fix this, we can add the Ticket object to vars and run the filterTicketData function again after the Ticket is created and only apply the send email filter action if the Ticket object is found.