Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate annex errors #1905

Merged
merged 12 commits into from
Jul 26, 2019
Merged

Propagate annex errors #1905

merged 12 commits into from
Jul 26, 2019

Conversation

joeseibel
Copy link
Contributor

Fixes #1884.

@joeseibel joeseibel requested a review from lwrage July 18, 2019 20:13
lwrage
lwrage previously approved these changes Jul 25, 2019
View reviewed changes
@lwrage lwrage dismissed their stale review July 25, 2019 17:04

approved by accident

lwrage
lwrage requested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@lwrage lwrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a test

@lwrage lwrage merged commit 18829ce into master Jul 26, 2019
@lwrage lwrage deleted the 1884_propagate_annex_errors branch July 26, 2019 18:06
@lwrage lwrage mentioned this pull request Aug 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwrage lwrage lwrage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annex parsing errors are not converted into markers
2 participants
@joeseibel @lwrage