New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The code is unreasonable #727

Open

nagq opened this issue Jun 30, 2020 · 0 comments

nagq commented Jun 30, 2020 •

edited

Loading

https://github.com/OSBI/saiku/blob/development/saiku-ui/js/saiku/views/TabSet.js

close_all: function() {
    for (var i = 0, len = this._tabs.length; i < len; i++) {
        var otherTab = this._tabs[i];
        otherTab.remove();
    }
}

should be

close_all: function() {
    for (var len = this._tabs.length, i = len - 1; i >= 0; i--) {
        var otherTab = this._tabs[i];
        otherTab.remove();
    }
}

nagq changed the title ~~code error~~ The code is unreasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment