Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selected components display in list of dependencies #100

Closed
jgiardino opened this issue May 25, 2017 · 1 comment
Closed

selected components display in list of dependencies #100

jgiardino opened this issue May 25, 2017 · 1 comment

Comments

@jgiardino
Copy link
Contributor

jgiardino commented May 25, 2017

Description of problem

The depsolve api call which provides all packages needed for the recipe, labeled as 'dependencies'. These contents are then displayed as the dependencies, but currently the selected components are included in this list that displays as dependencies.

Component (web, API, etc)

web

How often reproducible

Whenever depsolve successfully returns a list of dependencies.

Steps to Reproduce

  1. Navigate to the recipe or edit recipe page.
  2. Note which components are listed in the Selected Components section
  3. Expand the Dependencies section

Alternatively:

  1. run this: http://devel.weld.lab.eng.bos.redhat.com/api/v0/recipes/depsolve/http-server
  2. search for one of the 'modules' in the list of 'dependencies'

Actual results

The api call returns all components in the list of 'dependencies'.
The front-end js does not currently filter out the selected components from that list.

Expected results

The api call returns all components in the list of 'dependencies', as expected.
Then the front-end js filters out the selected components from that list.

Additional info

Additionally, the UI indicates that the list of dependencies is the first-level. But really, these are the total number of dependencies. Additional discussions are needed to determine whether we should show just first level vs all vs something else. But it would be nice to have the UI at least accurately describe the contents being listed.

@jgiardino
Copy link
Contributor Author

This was addressed with #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant