Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch_connect_sessions and authentication timeout #3605

Closed
mattmix opened this issue Jun 12, 2024 · 2 comments · Fixed by #3915
Closed

batch_connect_sessions and authentication timeout #3605

mattmix opened this issue Jun 12, 2024 · 2 comments · Fixed by #3915
Assignees
Labels
bug Existing functionality not working as expected community request component/batch_connect
Milestone

Comments

@mattmix
Copy link

mattmix commented Jun 12, 2024

When authentication times out for a user, requests are redirected to the auth server so they can login again. However, if they are sitting on the /pun/sys/dashboard/batch_connect/sessions page, the background polling for session updates will hit the redirect and fail in a way that gives no indication to the user that they aren't getting updates without pulling up the browser's console. This also causes noise on the authentication server since the polling function will follow the redirect on each poll and, at least on ours, fail also due to a CORS error.

I think it would be better if a failure to retrieve session information caused the whole page to be reloaded. That way, if the user's session has timed out they will be properly redirected to the login page.

The code that does the session polling was changed since 3.1's release, but I think the result is still the same regarding this issue: fdf9920

@osc-bot osc-bot added this to the Backlog milestone Jun 12, 2024
@johrstrom johrstrom modified the milestones: Backlog, 4.0 Jun 12, 2024
@johrstrom
Copy link
Contributor

Yes I've noticed this too in our apache logs. We should not keep pinging the server if we get 403 or similar errors. I think this often happens to me when I leave the browser open and let my machine fall asleep.

@johrstrom
Copy link
Contributor

I've got a fix for this that'll be in 4.0. Note that it'll just stop querying when a failure occurs. But if/when one does it'll additionally create a div on the page that tells the user there's been an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality not working as expected community request component/batch_connect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants