Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Building and Synchronization #725

Open
Oglopf opened this issue Sep 8, 2022 · 0 comments
Open

Doc Building and Synchronization #725

Oglopf opened this issue Sep 8, 2022 · 0 comments

Comments

@Oglopf
Copy link
Contributor

Oglopf commented Sep 8, 2022

There are more than one way to build the docs currently. Using either docker or pipenv and in either case, there are different images being used on docker-hub, which means there is a possibility of divergence in state between them and one method working while another is broken.

This ticket is to propose either of the following:

  • cutting out the multiple build paths and agreeing on a single path
  • come up with a plan to keep these differing build paths and images they need in sync

Either of these would be fine and the issue is nothing major, but it is some technical debt that seems easy to pay down with some discussion.

The docker method uses rake docker:build which relies on:

namespace :docker do

  desc "Build docs using docker"
  task :build do
    exec 'docker run --rm -i -t -v "${PWD}:/doc" -u "$(id -u):$(id -g)" ohiosupercomputer/docker-sphinx make html'
  end
end

Using the pipenv method ends up relying on the make utility and the repo's makefile which looks to use the sphinx-build command in the environment it sets up, and so from my reading it doesn't look like any docker-hub image is used, but I've also not looked at makefiles much.

In any case, it would be best to somehow get these synced by ensuring they use the same image to build and work on or removing one entirely.

┆Issue is synchronized with this Asana task by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant