Skip to content
This repository has been archived by the owner on Nov 13, 2019. It is now read-only.

When submitting a job, use the "underscore" version of the human readable name provided #10

Closed
ericfranz opened this issue Mar 21, 2016 · 4 comments
Assignees
Milestone

Comments

@ericfranz
Copy link
Contributor

This is the logic to determine the name of the job submitted:

  1. If the user provides a human readable name for the job, use the "underscore" version by calling http://api.rubyonrails.org/classes/ActiveSupport/Inflector.html#method-i-parameterize with "_" as the separator
  2. If the user doesn't, use the name of the directory or use what is in the job script itself?
@ericfranz ericfranz modified the milestone: OD3.0 Mar 21, 2016
@brianmcmichael
Copy link
Contributor

Shouldn't the submit name be defined in the PBS headers?

The user-entered name is only used in the table display in the app. Are you suggesting that we rewrite pbs headers?

@nickjer
Copy link
Contributor

nickjer commented Mar 24, 2016

I don't believe we should be renaming jobs if the user defined the job name already. The user won't be expecting this and may break any job checking scripts he may use.

I am fine with default job names if they are undefined.

@nickjer
Copy link
Contributor

nickjer commented Mar 24, 2016

Quick check shows if name is undefined, qsub defaults to the batch script filename. Which I think is reasonable.

@brianmcmichael
Copy link
Contributor

done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants