Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affine way of thinking causes confusion with trivial hyperplane #715

Closed
lkastner opened this issue Oct 1, 2021 · 2 comments · Fixed by #747
Closed

Affine way of thinking causes confusion with trivial hyperplane #715

lkastner opened this issue Oct 1, 2021 · 2 comments · Fixed by #747
Labels
bug Something isn't working topic: polyhedral geometry Issue concerns polyhedral geometry code

Comments

@lkastner
Copy link
Member

lkastner commented Oct 1, 2021

In polymake everything is homogeneous and polytopes are treated internally as cones most of the time where the actual polytope sits at height one. I.e. we have the coordinates [height, x_1, x_2, ...] in polymake. Every polytope comes with the hyperplane height>=0. For unbounded polyhedra, this hyperplane is also a facet, which we need to compute rays and lineality correctly. Now there are the following tasks:

  • When a polyhedron is created from inequalities in Oscar, even if they are non_redundant from the affine point of view, it can be necessary to add this hyperplane for the polymake computation. This depends on whether the result would be bounded. However, we might not want to check boundedness upon creation, but still if the user gives us a non_redundant presentation this should not just be piped into INEQUALITIES.
  • When the user asks for facets, should the trivial facet appear?
@lkastner lkastner added bug Something isn't working topic: polyhedral geometry Issue concerns polyhedral geometry code labels Oct 1, 2021
@benlorenz benlorenz mentioned this issue Oct 1, 2021
@lkastner
Copy link
Member Author

@alexej-jordan Are you aware of this issue? Do you have an idea?

lkastner added a commit that referenced this issue Oct 18, 2021
- Resolve issue #715
- User that want to give non-redundant input have to do so projectively,
  via Polymake.jl
lkastner added a commit that referenced this issue Oct 18, 2021
- Resolve issue #715
- User that want to give non-redundant input have to do so projectively,
  via Polymake.jl
@lkastner
Copy link
Member Author

This issue is not trivial at all and my initial description was wrong. Even unbounded polytopes do not need to have the trivial hyperplane as a facet, namely if the intersection with the trivial hyperplane has a lower dimension than the facet dimension of the polyhedron.

Therefore the consensus is now: Remove the non_redundant option for constructing a Polyhedron. Users that want to give non-redundant data have to do so by going via Polymake.jl, which is acceptable, since the projective viewpoint of polymake was explicitly chosen for resolving this mess (and others).

lkastner added a commit that referenced this issue Oct 18, 2021
- Resolve issue #715
- User that want to give non-redundant input have to do so projectively,
  via Polymake.jl
@lkastner lkastner linked a pull request Oct 18, 2021 that will close this issue
lkastner added a commit that referenced this issue Oct 19, 2021
- Resolve issue #715
- User that want to give non-redundant input have to do so projectively,
  via Polymake.jl
lkastner added a commit that referenced this issue Oct 25, 2021
- Resolve issue #715
- User that want to give non-redundant input have to do so projectively,
  via Polymake.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic: polyhedral geometry Issue concerns polyhedral geometry code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant