Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/677 #700

Merged
merged 9 commits into from
Oct 1, 2021
Merged

Issue/677 #700

merged 9 commits into from
Oct 1, 2021

Conversation

lkastner
Copy link
Member

Add missing functionality mentioned in #677

@lkastner lkastner linked an issue Sep 28, 2021 that may be closed by this pull request
Unifying and streamlining Polytopes interfaces #677
Closed
12 tasks
@lkastner
Copy link
Member Author

@alexej-jordan I think once you are done with the *_hull functions we can merge this. Well, you will probably have a look at my stuff before anyway, just a heads up that I consider this done.

@lkastner lkastner marked this pull request as ready for review September 29, 2021 11:21
@fingolfin
Copy link
Member

There's a conflict now

benlorenz
benlorenz requested changes Oct 1, 2021
View reviewed changes
Copy link
Member

@benlorenz benlorenz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, I commented on a few small issues that should be addressed before merging.

docs/src/PolyhedralGeometry/Polyhedra/visualization.md Outdated Show resolved Hide resolved
src/Polytopes/Polyhedron/standard_constructions.jl Outdated Show resolved Hide resolved
src/Polytopes/helpers.jl Outdated Show resolved Hide resolved
src/Polytopes/Polyhedron/constructors.jl Outdated Show resolved Hide resolved
src/Polytopes/iterators.jl Outdated Show resolved Hide resolved
test/Polytopes/Polyhedron.jl Outdated Show resolved Hide resolved
@lkastner @benlorenz
Apply suggestions from code review
89b6e25 
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
@lkastner lkastner merged commit 9dbbb11 into master Oct 1, 2021
@lkastner lkastner deleted the issue/677 branch October 1, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlorenz benlorenz benlorenz approved these changes

@alexej-jordan alexej-jordan alexej-jordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unifying and streamlining Polytopes interfaces
4 participants
@lkastner @fingolfin @benlorenz @alexej-jordan