Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polytopes: Minor improvements #747

Merged
merged 11 commits into from
Oct 26, 2021
Merged

Polytopes: Minor improvements #747

merged 11 commits into from
Oct 26, 2021

Conversation

lkastner
Copy link
Member

@lkastner lkastner linked an issue Oct 18, 2021 that may be closed by this pull request
Affine way of thinking causes confusion with trivial hyperplane #715
Closed
@lkastner
Copy link
Member Author

Note that for the serialization to work changes are necessary in Polymake.jl. There is a branch with the same name over there.

Also for the loading of graphs I had to determine whether the loaded thing is Directed or Undirected. So the output is slightly unclear. I can replace this with load_directed_graph and load_undirected_graph if you think this invites too much trouble.

@lkastner lkastner marked this pull request as ready for review October 18, 2021 20:57
fingolfin
fingolfin reviewed Oct 19, 2021
View reviewed changes
docs/src/PolyhedralGeometry/graphs.md Outdated
```
The file is in JSON format and contains all previously gathered data belonging
to the underlying polymake object. In particular, this file can now be read by
both polymake and Oscar.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specification of this format somewhere? It would be nice to reference it here and/or in the docstrings of the two functions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will reference @benlorenz to correct me if I am wrong: I know that there was an article on the old xml format https://arxiv.org/pdf/1605.05057.pdf and that there hasn't been something like this on the json version. There is https://polymake.org/doku.php/documentation/latest/core#schemas for bigobjects, and in general https://polymake.org/schemas/data.json summarizes everything. For now I will collect these things in a separate serialization page in the docs, ok?

@lkastner lkastner force-pushed the Polytopes/minor_improvements branch 2 times, most recently from 9de27a5 to 24679b8 Compare October 20, 2021 13:22
@alexej-jordan alexej-jordan mentioned this pull request Oct 20, 2021
Merged
@lkastner @benlorenz
Typo fixed
85ea31a 
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
@lkastner lkastner merged commit e049899 into master Oct 26, 2021
@lkastner lkastner deleted the Polytopes/minor_improvements branch November 10, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlorenz benlorenz benlorenz approved these changes

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Affine way of thinking causes confusion with trivial hyperplane
4 participants
@lkastner @fingolfin @benlorenz @alexej-jordan