Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function fields for irreducible varieties #1573

Merged
merged 21 commits into from
Sep 29, 2022

Conversation

HechtiDerLachs
Copy link
Collaborator

We introduce function fields of irreducible varieties which are given as covered schemes. The functionality comprises the basic arithmetic, but also moving the representatives around from one chart to another.

@thofma
Copy link
Collaborator

thofma commented Sep 28, 2022

I think it would be nice if the user-facing function call is just FunctionField(V).

experimental/Schemes/CoveredScheme.jl Outdated Show resolved Hide resolved
experimental/Schemes/FunctionFields.jl Outdated Show resolved Hide resolved
@fingolfin
Copy link
Member

I think it would be nice if the user-facing function call is just FunctionField(V).

And while we are at it, perhaps also function_field(V) as an alias?

experimental/Schemes/FunctionFields.jl Show resolved Hide resolved
experimental/Schemes/FunctionFields.jl Outdated Show resolved Hide resolved
experimental/Schemes/FunctionFields.jl Outdated Show resolved Hide resolved
experimental/Schemes/FunctionFields.jl Outdated Show resolved Hide resolved
experimental/Schemes/FunctionFields.jl Outdated Show resolved Hide resolved
experimental/Schemes/SpecOpen.jl Show resolved Hide resolved
src/Rings/localization_interface.jl Outdated Show resolved Hide resolved
src/Rings/mpolyquo-localizations.jl Show resolved Hide resolved
src/Rings/mpolyquo-localizations.jl Outdated Show resolved Hide resolved
test/Schemes/FunctionFields.jl Show resolved Hide resolved
@simonbrandhorst simonbrandhorst merged commit 5621a7e into oscar-system:master Sep 29, 2022
@simonbrandhorst simonbrandhorst deleted the function_fields branch September 29, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants