-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function fields for irreducible varieties #1573
Merged
simonbrandhorst
merged 21 commits into
oscar-system:master
from
HechtiDerLachs:function_fields
Sep 29, 2022
Merged
Function fields for irreducible varieties #1573
simonbrandhorst
merged 21 commits into
oscar-system:master
from
HechtiDerLachs:function_fields
Sep 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thofma
reviewed
Sep 28, 2022
thofma
reviewed
Sep 28, 2022
I think it would be nice if the user-facing function call is just |
fingolfin
reviewed
Sep 28, 2022
And while we are at it, perhaps also |
simonbrandhorst
requested changes
Sep 28, 2022
Co-authored-by: Max Horn <max@quendi.de> Co-authored-by: simonbrandhorst <51749255+simonbrandhorst@users.noreply.github.com>
…into function_fields
simonbrandhorst
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce function fields of irreducible varieties which are given as covered schemes. The functionality comprises the basic arithmetic, but also moving the representatives around from one chart to another.