Fixes for intersections and coverings #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thofma
reviewed
Sep 27, 2022
added 2 commits
September 27, 2022 14:53
| end | ||
| W = SpecOpen(X, [f*g]) | ||
| W = PrincipalOpenSubset(X, [f*g]) |
There was a problem hiding this comment.
Let's try to find a test for this line, tomorrow. Also, we should run the whole method on covered schemes that use both types of glueings.
There was a problem hiding this comment.
We can write it when #1573 is merged.
afkafkafk13
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its not perfect, but it is an improvement.