Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coeff (correctly) not implemented for spoly used by various functions #398

Closed
wbhart opened this issue Mar 22, 2021 · 3 comments · Fixed by #417
Closed

coeff (correctly) not implemented for spoly used by various functions #398

wbhart opened this issue Mar 22, 2021 · 3 comments · Fixed by #417
Labels

Comments

@wbhart
Copy link
Contributor

wbhart commented Mar 22, 2021

spoly cannot provide a coeff(f, n) function due to the fact that Singular does not have random access structures for polynomials.

This means the following are implemented incorrectly in Singular (or no longer needed):

canonical_unit(a::spoly{T}) -- src/poly/poly.jl
isnegative(x::spoly) -- src/poly/poly.jl

@wbhart wbhart added the bug label Mar 22, 2021
@wbhart
Copy link
Contributor Author

wbhart commented Mar 22, 2021

In both cases coeff(f, 0) can be replaced with first(coefficients(f)), which will give the leading coefficient, which is presumably what was meant. Alternatively, perhaps leading_coefficient is better once the relevant PR is merged.

@fieker
Copy link
Contributor

fieker commented Mar 23, 2021

There is a chance that in Hecke at some point we (I) added hasLength to the iterator

@oscar-system oscar-system deleted a comment from wbhart Mar 23, 2021
@wbhart wbhart changed the title coeff used by (correctly) not implemented for spoly coeff (correctly) not implemented for spoly used by various functions Mar 23, 2021
@wbhart
Copy link
Contributor Author

wbhart commented Mar 23, 2021

Just to clarify, addition of has_length wouldn't make these definitions correct, even if Singular depended on Hecke. Fortunately with the new printing code, these may not be needed any more anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants