Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature sugestion: Fixed width rivers where no riverbank polygon is defined. #45

Closed
StevenJNPearce opened this issue Oct 17, 2018 · 1 comment

Comments

@StevenJNPearce
Copy link

StevenJNPearce commented Oct 17, 2018

It would be nice to use the wdith tag from waterway=river, and then have rivers that do not have a riverbank defined in the OSM data filled with water to this width, following the linear waterway from OSM data. Potentially this could yield good results, as these are usually smaller rivers/creeks that have a fairly uniform width along their course.

@oscarpilote
Copy link
Owner

I would certainly do that if it was for a landclass scenery (where the exact position is less of an issue) but with orthoscenery I always tend to think that "better not placed that wrongly placed". You have probably already encountered situations where, although the riverbanks are encoded, they do not correspond very well to the ortho. Also, for narrow rivers in the ortho (and IRL) you can often only spot trees, and having a reflective surface with tree-like albedo looks a bit unusual.

But if you wish to test, you can try to have a look at the include_water part of O4_Vector_Map.py and modify it in that sense (using the "improved_buffer" function as it is done for buffering the road network in include_roads).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants