Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for logging with limit for messages per minutes #4

Closed
oshai opened this issue Jul 7, 2016 · 3 comments
Closed

add support for logging with limit for messages per minutes #4

oshai opened this issue Jul 7, 2016 · 3 comments

Comments

@oshai
Copy link
Owner

oshai commented Jul 7, 2016

No description provided.

@oshai
Copy link
Owner Author

oshai commented Jul 21, 2016

this can assist in preventing log spamming with many similar messages.

@IRus
Copy link

IRus commented Jul 31, 2016 •
edited
Loading

This is not responsibility of your library or even logger facade. I think messages throttling is responsibility of concrete appender. But this is logging, so you should log every message, because you don't want lost important stacktraces and errors.

@oshai
Copy link
Owner Author

oshai commented Jul 31, 2016

I tend to agree. on the other hand it seems like a valuable feature. I will close it now and reconsider in case it will pop-up again.

@oshai oshai closed this as completed Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IRus @oshai