Skip to content
This repository has been archived by the owner on Jul 3, 2020. It is now read-only.

Add OSIAM Shell to main distribution #12

Closed
tkrille opened this issue Sep 30, 2014 · 5 comments
Closed

Add OSIAM Shell to main distribution #12

tkrille opened this issue Sep 30, 2014 · 5 comments

Comments

@tkrille
Copy link
Member

tkrille commented Sep 30, 2014

see osiam/shell#1.

@sschum
Copy link
Contributor

sschum commented Sep 30, 2014

I think we have the following options:

  • Only add the runable jar file into the distribution.zip (where all other components are stored)
  • Make a own zip-pagage for shell (then we can outsource the lib jars into a seperate folder, but we need a start-script)

@tkrille
Copy link
Member Author

tkrille commented Oct 2, 2014

what about a fat- (or uber-) jar? this way you can start it just like this in a terminal:

$ ./osiam-shell.jar

given that one has installed binfmt stuff beforehand. nevertheless, we can still provide a start script too. i don't think we should distribute every single jar-packaged dependency - it just feels totally antiquated to do so.

@tpick
Copy link
Contributor

tpick commented Oct 2, 2014

+1 for uberjar

@tkrille
Copy link
Member Author

tkrille commented Oct 2, 2014

i just looked at the pom and you are already create a jar with all dependencies contained via the maven-assembly-plugin. the resulting artifact is also already taken for the main artifact and will be installed and certainly deployed, too, during the normal maven lifecycle, though i have not tried to deploy it yet. maybe this can further be improved by using the maven-shade-plugin? i think it's better suited for the job.

i think we should also make a separate distribution of the shell, if we want to not only ship a runnable jar but also a start script or other supporting files.

but we should move this discussion to https://github.com/osiam/shell. i opened these 2 issues: osiam/shell#4, osiam/shell#3

@wallner
Copy link
Member

wallner commented Oct 4, 2015

I'm closing this issue, since discussion is taking place in osiam/shell#3

@wallner wallner closed this as completed Oct 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants