Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow encoder subclasses to customize the message before it is converted to String #40

Merged
merged 13 commits into from
Dec 26, 2019
Merged

Allow encoder subclasses to customize the message before it is converted to String #40

merged 13 commits into from
Dec 26, 2019

Conversation

nemecec
Copy link

@nemecec nemecec commented Nov 27, 2019

Fix for issue #39

Copy link
Owner

@osiegmar osiegmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written in #39 this might not be enough, and a test case is missing.

@nemecec
Copy link
Author

nemecec commented Dec 26, 2019

Added a test and sample usage.

@osiegmar osiegmar merged commit 4d0204e into osiegmar:master Dec 26, 2019
@osiegmar
Copy link
Owner

Thanks!

@nemecec nemecec deleted the encoder-customization branch December 26, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants