Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary live update artifacts when downloading a network route gpx #20122

Closed
Velomeloman opened this issue Jun 18, 2024 · 7 comments
Closed
Assignees
Milestone

Comments

@Velomeloman
Copy link
Contributor

Velomeloman commented Jun 18, 2024

Description

After editing the network route in osm, outdated parts appear when trying to download gpx. At the same time, the route is rendered correctly.

Steps to reproduce

  1. Find the recently edited route. Example
  2. Download Live updates
  3. Make sure that the route is rendered correctly 55.61985 37.50595
  1. Tap on the Name or Ref to display info about the route

Actual result

Outdated parts appears:

Expected result

The actual route GPX is loaded and displayed correctly same as render

Your Environment (required)

OsmAnd Version:
OsmAnd~ 4.8.0#2528m, released: 2024-06-18

@vshcherb
Copy link
Member

I suspect that Network Load Route doesn't take into account deleted ways (osm_way_delete tag) which is important to produce correct gpx

@ivanPyrohivskyi
Copy link
Contributor

ivanPyrohivskyi commented Jul 26, 2024

Maps for test:
Russia_moscow_asia.obf on 01 June 2024
Russia_moscow_asia_24_06_00.obf live-updates for June 2024

How to test.
Disable live-updates and remove newly Russia_moscow map (June/Aug 2024).
After put files into net.osmand.plus/files/Russia_moscow_asia.obf and net.osmand.plus/files/live/Russia_moscow_asia_24_06_00.obf .
First test on night build before change (26.07.2024) and take attention on place 55.62120, 37.50140 . After using new build and compare change.

@ivanPyrohivskyi
Copy link
Contributor

Old part of Зелёное Kольцо Москвы https://www.openstreetmap.org/way/1184447587

@ivanPyrohivskyi
Copy link
Contributor

Tried tested on iOS.
Track is not show on the map.

@Velomeloman
Copy link
Contributor Author

Maps for test:
Russia_moscow_asia.obf on 01 June 2024
Russia_moscow_asia_24_06_00.obf live-updates for June 2024

How to test.
Disable live-updates and remove newly Russia_moscow map (June/Aug 2024).
After put files into net.osmand.plus/files/Russia_moscow_asia.obf and net.osmand.plus/files/live/Russia_moscow_asia_24_06_00.obf .
First test on night build before change (26.07.2024) and take attention on place 55.62120, 37.50140 . After using new build and compare change.

Both links on same file Russia_moscow_asia.obf

@DmitryAlexei
Copy link
Contributor

OsmAnd~ 4.8.0#2855m, released: 2024-07-29
tested with maps provided in the post above (from June) > issue fixed

OsmAnd TestFlight 4.8.0.4
tested with June maps from the post above > no action needed

@Velomeloman
Copy link
Contributor Author

Velomeloman commented Jul 30, 2024

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants