-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destinations are announced even though there is no destination tag on the way being turned onto #18180
Comments
To reproduce the bug, I followed these steps:
By comparing the Turn-by-turn instructions displayed above with the ones I reviewed, I found some similarities. Specifically, the fourth instruction in the screenshot matches your fifth instruction, and the fifth instruction in the screenshot corresponds to your seventh instruction. Also it has been noticed that there are incomprehensible destination tags with almost every route change. However, it's worth noting that the current Turn-by-turn instructions differ from the ones you initially provided. You can access the route through this link: OsmAnd~ 4.6.0#829m, released: 2023-10-02 |
Thank you for trying to reproduce this. From what I can tell, the link you provided doesn't calculate the route both you and I got, it seems to use OSRM which takes a different route via Neuhaufenstraße. But the route in your screenshot seems to be exactly the one I got too. As you can see, the fourth and fifth instructions tell the user to head "towards Graz, Linz, Budapest etc.", which is wrong, there are no destination signs there either in OSM or in reality; those destination signs are only there where you enter the motorway. If anyone needs more information, do not hesitate to ask me. |
Destination tags are read ahead for several ways, otherwise there will be a problem for complex intersections and small connecting segments without all tags |
@yuriiurshuliak please record video of the issue to analyze and provide the link to Osm route / ways |
The bug has been confirmed. During navigation, non-existent destinations are announced at turns. This issue is visible in instructions 4 and 5 in the screenshot. Here are the route segments without any destination tags: OsmAnd~ 4.8.0#2568m, released: 2024-06-24
|
I guess destinations are taken from https://www.openstreetmap.org/way/11809610 which is 1 km away. So we need to be less agressive when propagating tags and we shouldn't take destinations if it's not current "intersection group" (so it could multiple turns) - here it's 2 intersections away |
Describe the bug (required)
On some routes when navigating, OsmAnd announces destinations on turns that don't exist on the way being turned onto.
Describe how the bug can be reproduced (required)
Describe the actual result (required)
I get these instructions (leaving out ones unrelated to navigation):
then further instructions not relevant to the bug.
Describe the expected result (required)
I expect instructions 5 and 7 to not contain destinations because neither https://www.openstreetmap.org/way/1042430065 nor https://www.openstreetmap.org/way/208344985 has any destination tags on it (rightly, because there are no destination signs there in reality).
That is, I expect instruction 5 to be "nach 250 Metern rechts abbiegen auf die Stadlauer Straße" (after 250 meters turn right onto Stadlauer Straße). I expect instruction 7 to be "nach 250 Metern links abbiegen auf die B3 Erzherzog-Karl-Straße" (after 250 meters turn left onto B3 Erzherzog-Karl-Straße).
This happens for some other routes too; this is merely an example. I suspect that OsmAnd for some reason reads these destination tags from https://www.openstreetmap.org/way/11809610 which is a way that I will turn onto later during the example route, but not at the times that these instructions are announced.
Your Environment (required)
OsmAnd Version: OsmAnd~ 4.5.8 from F-Droid
Android/iOS version: Android 13
Device model: Samsung Galaxy S22
The text was updated successfully, but these errors were encountered: