Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTS: Destinations listing cut (probably because of slash '/') #19957

Closed
1 of 3 tasks
vmicho opened this issue May 26, 2024 · 3 comments
Closed
1 of 3 tasks

TTS: Destinations listing cut (probably because of slash '/') #19957

vmicho opened this issue May 26, 2024 · 3 comments

Comments

@vmicho
Copy link

vmicho commented May 26, 2024

Describe the routing engine used (required)

  • [ x] OsmAnd's in-app offline routing
  • Any online routing provider (YOURS, openrouteservice, OSRM, etc.)

Describe your routing Profile (required)

The reading of destinations is cut.
I observed the problem on when one of the destiantions is 'Biel/Bienne'.
On openstreetmap all looks OK. Even the destination:ref tags are not present

Screenshot_20240526-133136_OsmAnd+
Here the reading stops after "Biel" (Bienne is omitted)
when turning onto: https://www.openstreetmap.org/way/307451529
route: https://osmand.net/map/navigate/?start=46.968909,7.460130&end=46.972354,7.471350&profile=car#16/46.9709/7.4626

Screenshot_20240526-134913_OsmAnd+
It reads "turn slightly right onto exit 38, towards A6, Biel Bienne" (Schonbuhl is omitted)
when turning onto: https://www.openstreetmap.org/way/4482242
route: https://osmand.net/map/navigate/?start=47.008203,7.496409&end=47.011952,7.497573&profile=car#17/47.01018/7.49699

Here are used destination (which I suppose should be read) "Biel/Bienne;Schönbühl", destination:ref="A6" (OK, shown and read) and destination:lanes="Biel/Bienne|Biel/Bienne;Schönbühl;Einkaufszentrum" (which is useless(?) here when turning onto it, this is more like what will come next)

All destinations are correctly shown on top of the screen. It's just the are not all read.
My suspicion is the slash character (might escape something?)

Describe your start and end points (required)

included in description

Describe the actual route (required)

route is OK

Describe the expected route (required)

in description

Describe what Maps you used (online or offline) (required)

  • Offline maps offered within the OsmAnd app for download.
  • Online (tile / raster) maps

Your Environment (required)

OsmAnd Version: 4.7.10 - 2024-04-18
Android/iOS version: 12 (lineageos 19-20230722)
Device model: xiaomi mi10T

Anything else? (optional)

No response

@sonora
Copy link
Member

sonora commented May 26, 2024

Yes, a lot of TTS engines have issues with slashs, at least used to, some time ago. But we replace by a comma before passing it on. Will need to investigate closer , at first sight it's odd.

EDIT: Upon a quick test I can confirm that the TTS engine receives the text with the slash behind "Biel" replaced by a comma ok, but also truncated behind it, so there seems an issue before the character replacement.

EDIT 2: Upon further inspection, it seems by design. Looks like we shorten destination announcements to 3, probably makes sense to avoid endless reading of navigation prompts. So the only bug to fixing here is we should shorten first, then do the comma replacement, to avoid cutting between words which belong together.

@sonora
Copy link
Member

sonora commented May 26, 2024

Fixed here: ec91a71. Thanks for reporting!

@sonora sonora closed this as completed May 26, 2024
@vmicho
Copy link
Author

vmicho commented May 26, 2024

wow that was fast. From the commit, it looks like reasonable fix ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants