Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing contourlines.addon.render.xml file to give a custom color to contour lines does not fully work. #19958

Closed
patdu1 opened this issue May 26, 2024 · 7 comments
Assignees
Milestone

Comments

@patdu1
Copy link

patdu1 commented May 26, 2024

Description

With the attached contourlines.addon.render.xml file (had to zip it to upload) when selecting my custom color (magenta) only the text (elevation) is displayed with the proper color, the lines keep their brownish (default?) color, as seen in the screenshot (color_issue.png).
contourlines.addon.render.zip

Steps to reproduce

Trying to understand what mistake I made I finally found that the contourline colors are also defined in topo.render.xml, and it seems that the values coming from this file take precedence over the ones from contourlines.addon.render.xml
In the attached topo.render.xml I commented out some lines defining the attribute contourLineColor (see comments labeled with PAT) and one line using the $contourLineColor value.
After these edits I get the expected contour lines color (see screenshot color_OK.png).
The topo.render.xml contains several additional occurrences of contour line or text color definition, but always in commented out blocs, so I think that the block that I had to comment out had just been missed so far...
Regarding the single line using $contourLineColor I had to take it out because otherwise Osmand would crash, but I have no idea about the real impact on other parts of the application.
topo.render.zip

Finally one more point that I don't understand, but it's only cosmetic: in the render file the color names are defined in lowercase but in the Osmand window they appear with the first letter capitalized... except for the additional custom color I added into contourlines.addon.render.xml (see color_menu.png). Are these color names defined somewhere else again? This is just a cosmetic point, it doesn't impact the functionality.
color_menu

Actual result

Magenta elevation text and brown contour lines
color_issue

Expected result

Magenta contour lines & text
color_OK

Your Environment (required)

Osmand version: 4.7.17 (SRTM plugin activated)
Android version: 14
Device: Pixel 6a

@yuriiurshuliak
Copy link

This feature isn't available in the release version yet. Please try our nightly build: https://osmand.net/docs/versions/nightly_versions#nightly-builds

@patdu1
Copy link
Author

patdu1 commented May 27, 2024

Not sure how to do that:

  1. I don't want to mess up my working Osmand install
  2. The nightly build is the free version and does not include the SRTM plugin... which I am not going to buy again
    Also "this feature" being now available and working with my edited files on my phone...

@yuriiurshuliak
Copy link

Please be aware that we are still in the process of implementing this feature.
Related to #6636

@patdu1
Copy link
Author

patdu1 commented May 29, 2024

OK, thanks for the info.
Scope of issue 6636 is much bigger, I was just trying to adjust contour lines visibility (and text size) to my old eyes ;-)

@xmd5a2 xmd5a2 self-assigned this Jun 5, 2024
@DmitryAlexei DmitryAlexei added this to the 4.8-map milestone Jun 6, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Jun 7, 2024
@xmd5a2
Copy link
Contributor

xmd5a2 commented Jun 7, 2024

Fixed. Contour lines code moved from topo to contourlines.addon.render.xml. Dark orange and purple color schemes added.

@xmd5a2 xmd5a2 closed this as completed Jun 7, 2024
@patdu1
Copy link
Author

patdu1 commented Jun 9, 2024

Great! Thanks a lot.

xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Jun 26, 2024
@DmitryAlexei
Copy link
Contributor

Dark orange and purple color schemes are now available on Android OsmAnd~ 4.8.0#2598m, released: 2024-06-26
For iOS new TestFlight build is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants