-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing contourlines.addon.render.xml file to give a custom color to contour lines does not fully work. #19958
Comments
This feature isn't available in the release version yet. Please try our nightly build: https://osmand.net/docs/versions/nightly_versions#nightly-builds |
Not sure how to do that:
|
Please be aware that we are still in the process of implementing this feature. |
OK, thanks for the info. |
Fixed. Contour lines code moved from topo to contourlines.addon.render.xml. Dark orange and purple color schemes added. |
Great! Thanks a lot. |
Description
With the attached contourlines.addon.render.xml file (had to zip it to upload) when selecting my custom color (magenta) only the text (elevation) is displayed with the proper color, the lines keep their brownish (default?) color, as seen in the screenshot (color_issue.png).
contourlines.addon.render.zip
Steps to reproduce
Trying to understand what mistake I made I finally found that the contourline colors are also defined in topo.render.xml, and it seems that the values coming from this file take precedence over the ones from contourlines.addon.render.xml
In the attached topo.render.xml I commented out some lines defining the attribute contourLineColor (see comments labeled with PAT) and one line using the $contourLineColor value.
After these edits I get the expected contour lines color (see screenshot color_OK.png).
The topo.render.xml contains several additional occurrences of contour line or text color definition, but always in commented out blocs, so I think that the block that I had to comment out had just been missed so far...
Regarding the single line using $contourLineColor I had to take it out because otherwise Osmand would crash, but I have no idea about the real impact on other parts of the application.
topo.render.zip
Finally one more point that I don't understand, but it's only cosmetic: in the render file the color names are defined in lowercase but in the Osmand window they appear with the first letter capitalized... except for the additional custom color I added into contourlines.addon.render.xml (see color_menu.png). Are these color names defined somewhere else again? This is just a cosmetic point, it doesn't impact the functionality.
Actual result
Magenta elevation text and brown contour lines
Expected result
Magenta contour lines & text
Your Environment (required)
Osmand version: 4.7.17 (SRTM plugin activated)
Android version: 14
Device: Pixel 6a
The text was updated successfully, but these errors were encountered: