Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide underground does not hide Operatunnelen / Festningstunnelen in Oslo, Norway #20224

Closed
gjvons opened this issue Jul 1, 2024 · 18 comments
Closed
Assignees
Labels
Observed Needs more clarification, feedback, or research
Milestone

Comments

@gjvons
Copy link

gjvons commented Jul 1, 2024

Description

The underground tunnels named Operatunnelen / Festningstunnelen in the Oslo city center are showing up on the map even when hide underground objects is enabled.
The location of the tunnels: https://www.openstreetmap.org/search?query=oslo#map=15/59.9085/10.7367
These objects are tagged as tunnels with layer -2.

Steps to reproduce

Open OsmAnd, navigate to Oslo, Norway.
Hide underground objects.
Look at the map.

Actual result

Expected result

As these tunnels are underground objects, the expectation is that they are not visible when underground objects are hidden.

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive.
Review this CAREFULLY before posting your issue!

OsmAnd Version: 4.7.17
Android/iOS version: 14
Device model: grus (Xiaomi Mi 9 SE)
Crash-Logs: ?
@yuriiurshuliak
Copy link

The bug has been confirmed. To reproduce it, go to coordinates 59.91041, 10.7356 and enable the "Hide underground objects" option. This should hide the tunnels, but the Operatunnelen / Festningstunnelen remain visible.

Web version link: link
OSM object link: link

OsmAnd~ 4.8.0#2652m, released: 2024-07-02

@DmitryAlexei DmitryAlexei added this to the 4.9-map milestone Jul 17, 2024
@DmitryAlexei DmitryAlexei added the ! label Jul 17, 2024
@DmitryAlexei DmitryAlexei removed this from the 4.9-map milestone Jul 17, 2024
@vshcherb
Copy link
Member

tunnels are important for highway network and not consinder as underground objects such as rivers, tram lines...

@vshcherb vshcherb added Observed Needs more clarification, feedback, or research and removed ! labels Jul 19, 2024
@gjvons
Copy link
Author

gjvons commented Jul 21, 2024

tunnels are important for highway network and not consinder as underground objects such as rivers, tram lines...

...but not important for pedestrians or cyclists, as they usually are not allowed to use this kind of tunnels.

@vshcherb
Copy link
Member

True we could hide for pedestrian / cyclists

@vshcherb vshcherb added this to the 4.9-map milestone Jul 22, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Jul 26, 2024
@xmd5a2
Copy link
Contributor

xmd5a2 commented Jul 26, 2024

Fixed. No new maps required.

@xmd5a2 xmd5a2 closed this as completed Jul 26, 2024
@dmpr0
Copy link
Contributor

dmpr0 commented Jul 31, 2024

Review

  • Todo is missing

@dmpr0 dmpr0 reopened this Jul 31, 2024
@vshcherb
Copy link
Member

we hide for pedestrian / cyclists

@dmpr0 dmpr0 reopened this Jul 31, 2024
@dmpr0
Copy link
Contributor

dmpr0 commented Jul 31, 2024

Review 2

Car Pedestrian
  • Tunnels should be hidden for pedestrian / cyclists by default without applying Hide underground objects.

xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Aug 12, 2024
@xmd5a2 xmd5a2 closed this as completed Aug 12, 2024
@Velomeloman
Copy link
Contributor

The user should be able to enable the display of tunnels if necessary. Please add a switch to the Configure map - Details menu.

@xmd5a2
Copy link
Contributor

xmd5a2 commented Aug 21, 2024

In addition, cyclists and pedestrians are generally allowed to travel through tunnels.

@DmitryAlexei
Copy link
Contributor

OsmAnd~ 4.9.0#3044m, released: 2024-08-21
Some tunnels that are allowed for pedestrians (and cyclists) are hidden on the map (see screenshots).
https://www.openstreetmap.org/way/750280494

  • It is proposed to hide only tunnels prohibited for pedestrians / cyclists

@DmitryAlexei DmitryAlexei reopened this Aug 21, 2024
@Velomeloman
Copy link
Contributor

Velomeloman commented Aug 21, 2024

The basic request was to hide the tunnels when underground objects hidden.
I think you should add an extra setting to the Configure map - Hide menu and not link it to cyclists and pedestrians.

Gh0stz0x added a commit to Gh0stz0x/OsmAnd-Resources that referenced this issue Aug 28, 2024
* Add icons to routes without name and ref (osmandapp/OsmAnd#19617)

* Add shields for routes without name (osmandapp/OsmAnd#19617)

* Fix tunnels in touring view and LightRS (osmandapp/OsmAnd#20032)

* Touring view: Some code polishing

* Introduce a new road-style "pale" (osmandapp#1085)

* Fixes for osmandapp/OsmAnd#20208

* Fix osmandapp/OsmAnd#20208

* Fix osmandapp/OsmAnd#20208

* Add icons for steps (https://github.com/osmandapp/OsmAnd-Issues/issues/706)

* OSM carto style: admin borders & parking spaces (osmandapp#1088)

* admin borders & parking spaces

* admin color attributes

* Added updated 3D Models

* Update fr_tts.js

Differentiate "left/right_keep" and "left/right_bear" + other minor changes

* Add stairs to default rendering mode (https://github.com/osmandapp/OsmAnd-Issues/issues/706)

* Fix lt_tts.js by replacing "let" into "var"

Otherwise Lithuanian TTS may not work in OsmAnd

* Add lang support for top_index

* Add turn-lanes-test 85 (Issue #20262) (osmandapp#1092)

* Limit visibility of emergency=access_point (osmandapp/OsmAnd#20230)

* Rename kiev and nordrhein-westfalen (osmandapp/OsmAnd#20323)

* Rename regions (osmandapp/OsmAnd#20323)

* Fix icon (https://github.com/osmandapp/OsmAnd-Issues/issues/706)

* Added 3D Model for Car icon

* Fix icon (https://github.com/osmandapp/OsmAnd-Issues/issues/706)

* Added 3D Model for Car icon

* Updates for Serbian Lating TTS

* Updates for Serbian Lating TTS

* Avoid traffic_calming=no

* Added updated 3D Models

* Added updated 3D Models

* Hide most icons and some objects for car mode zoom<=17 (osmandapp/OsmAnd#18894)

* Hide house names from car mode (osmandapp/OsmAnd#18894)

* Hide high-level tunnels for all except car mode with hideUnderground option (osmandapp/OsmAnd#20224)

* Prepare data for GPX-approximation tests

* Add Approximation tests round03, round04

* Add sample poiGroup (https://github.com/osmandapp/OsmAnd-Issues/issues/2620)

* Fix turn lanes

* Update fr_tts.js

* Add tests for Issue #19773 vehicle:conditional=no

* Fix lt_tts.js by replacing "let" into "var"

Otherwise Lithuanian TTS may not work in OsmAnd

* Add routing test 70, verify and outdate test 10.1

* Update default.render.xml

* Fixed shields

* Fix blue pentagon road shield

* Revert "Add sample poiGroup (https://github.com/osmandapp/OsmAnd-Issues/issues/2620)"

This reverts commit c4c2251.

* Add test renderingAssociations (shops, transport_car, transport_bicycle) (https://github.com/osmandapp/OsmAnd-Issues/issues/2620)

* Fix

* Check keep instruction after merge turn lanes

* Hide main tunnels in pedestrian and bicycle mode by default (osmandapp/OsmAnd#20224)

* Fix routing

* Add associations (https://github.com/osmandapp/OsmAnd-Issues/issues/2620)

* Fix ford rendering

* Add cash_in filter for ATM (osmandapp/OsmAnd#20574)

* Show cycle routes also at zoom 11/12 (osmandapp#1106)

* Lower minzoom for bicycle routes to 11

* Render cycle routes wider at zoom 11

* Try to fix diet filter (osmandapp/OsmAnd#20583)

* Remove some diet tags because they are already combined to 'diet_*_filter' (osmandapp/OsmAnd#20583)

* Update synthetic test

* Add more rt/roundabout GPX approximation tests (osmandapp#1109)

* Improve tests 68,69 (find exact point-in-segment)

* Updated Gate icons and shields

* ignore tests for now

* Fix tests

* Add svg-web-res to gitignore

* Add current OSM source for Routing_test_68_69

* Update gate icons

* Add vice-versa tests for vehicle:conditional=no

* Revert "Update gate icons"

This reverts commit 6f2c676.

* Ignore test for now

* Ignore test for now

* Added list of travel activities

* Add new Norway regions, fix translations (osmandapp/OsmAnd#20127)

* Add osmand_avalanche_protector=yes tag (osmandapp/OsmAnd#20637)

* Forbid footways and paths for cars (osmandapp/OsmAnd#20117)

* Touring view: Fix highway=road Rendering Issue (#20357)

* Update et_tts.js

Translate some missing strings.
Fixed dictionary keys being passed to tts in distance().

* Update et_tts.js

Added integer declension, fixed bugs

* Update et_tts.js

Bugfixes

* Update et_tts.js

idk

* Update et_tts.js

Fixed language/pronunciation errors.

* Implement OBF-GPX customizations (generation/rendering rules) (osmandapp#1103)

* Support "width" for GPX in OBF files (gen/render)

* Append gpx_icon as additional=true into generation

* Implement OBF-GPX route:point icons customization

* Move OBF-GPX tracks/points to addon (common) style

* Add OBF-GPX track extensions tags to poi_types.xml

* Remove comments and add textDy for OBF-GPX points

* Prettify OBF-GPX track/point tags schema

* Implement OBF-GPX osmand:points_groups tags

---------

Co-authored-by: xmd5a <lornaderek@mail.ru>
Co-authored-by: Hardy <hardy.mueller@web.de>
Co-authored-by: Reto Kaiser <reto@retoonline.com>
Co-authored-by: MeijiRestored <42336759+MeijiRestored@users.noreply.github.com>
Co-authored-by: dmpr0 <dmpr0.ua@gmail.com>
Co-authored-by: breversa <breversa@gmail.com>
Co-authored-by: embar- <embar-@users.noreply.github.com>
Co-authored-by: ivanPyrohivskyi <ivan.pirogovsky@gmail.com>
Co-authored-by: vshcherb <victor.shcherb@gmail.com>
Co-authored-by: RZR-UA <90444451+RZR-UA@users.noreply.github.com>
Co-authored-by: alex-osm <alex.morozov.osm@gmail.com>
Co-authored-by: RZR-UA <youonly@ukr.net>
Co-authored-by: Matthijs Kooijman <matthijs@stdin.nl>
Co-authored-by: Kristjan Arusalu <kristjan.arusalu001@gmail.com>
@Velomeloman
Copy link
Contributor

Velomeloman commented Sep 5, 2024

Some thoughts about this issue. Now, when hiding tunnels, interrupted road lines are formed that look incomplete. The idea is to show an icon at the ends of hidden tunnels, as it is now done for stairs.

@dmpr0
Copy link
Contributor

dmpr0 commented Sep 5, 2024

Subway platforms should be hidden to.

@vshcherb
Copy link
Member

vshcherb commented Sep 6, 2024

Yes makes sense to have icon tunnel entrance.
However it makes sense to have separate issue

xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Sep 9, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Oct 9, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Oct 11, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Oct 11, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Oct 14, 2024
* Add tunnel icon and some rules (osmandapp/OsmAnd#20224)

* Add multiple propagate to tunnel=yes (osmandapp/OsmAnd#20224)

* Try to fix (osmandapp/OsmAnd#20224)

* Support multiple propagation per entity

* Add propagate network if

* Try to fix tunnel icons

---------

Co-authored-by: Victor Shcherb <victor.shcherb@gmail.com>
@xmd5a2
Copy link
Contributor

xmd5a2 commented Oct 14, 2024

Icons for hidden tunnels were added but there is a bug: if tunnel without foot/bicycle=no touches highway= + tunnel=yes + foot=no then no icon is added
изображение

@vshcherb
Copy link
Member

We need maps for testing @xmd5a2

xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Oct 17, 2024
xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Oct 17, 2024
@xmd5a2
Copy link
Contributor

xmd5a2 commented Oct 18, 2024

norway_oslo map was regenerated

xmd5a2 added a commit to osmandapp/OsmAnd-resources that referenced this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Observed Needs more clarification, feedback, or research
Projects
None yet
Development

No branches or pull requests

8 participants