Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle pumps #6

Closed
1 of 3 tasks
joostschouppe opened this issue Jul 13, 2020 · 5 comments
Closed
1 of 3 tasks

Cycle pumps #6

joostschouppe opened this issue Jul 13, 2020 · 5 comments

Comments

@joostschouppe
Copy link
Member

joostschouppe commented Jul 13, 2020

TODO

  • extend with other tags
  • document on the docs website
  • document on the wiki discussion page and put a link on the OSMBE riot

How things are mapped now:

Main tag

Decision:

  • we will show everything with the tag service:bicycle:pump=yes
  • for independent pumps, we will use amenity=bicycle_repair_station + service:bicycle:pump=yes/no
  • for pumps offered at other places service:bicycle:pump=yes indicates that "has a free bicycle pump which can be used by anybody" (already like this on the wiki)
    So we need three different icons?
  • an independent pump (amenity=bicycle_repair_station + service:bicycle:pump=yes + [no other service:bicycle:* tags)
  • a repair station with a pump (amenity=bicycle_repair_station + service:bicycle:pump=yes + [one or more other service:bicycle:* tags)
  • another feature (most like a shop) with a free pump ( !amenity=bicycle_repair_station+ service:bicycle:pump=yes). This includes amenity=compressed_air that has been explicitely marked as oriented to cyclists)

Reasoning for independent pumps:

Option 1)
amenity=bicycle_repair_station service:bicycle:pump=yes/no
downside: this is a little weird, as there is no "real" repair station**
but: a repair station with just this one service is relatively un-ambigious)

Option 2)
amenity=compressed_air + some clarifying tag
downside: it's hard to filter those meant for bicycles (there is more than one option to indicate this) and it makes it very hard for car-oriented data-users to filter away those NOT meant for cars

Note the subtags at https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcompressed_air aren't in the same logic as those for repair stations

@joostschouppe
Copy link
Member Author

valves

Tag is valves
Values: ; separated . Common values: sclaverand; dunlop; schrader; regina
How to model in the tool:

  • show a picture of the common situation with a double valve and two types of cycle tires and ask "Does it look like this?".
    If yes, write valves=sclaverand;schrader
    If no: add a description or aks to make sure the valve is visible in their picture

@joostschouppe
Copy link
Member Author

Who owns/operates the object?

Tag is operator
Lets NOT ask in the Mapathon, but ask the owners

@joostschouppe
Copy link
Member Author

joostschouppe commented Jul 14, 2020

Is there a pressure indicator / drukmeter-manometer / gauge de pression?

tag is manometer = yes/no

@joostschouppe
Copy link
Member Author

joostschouppe commented Jul 14, 2020

When can I use it?

tag is opening_hours

Outdoor: value 24/7 but that's a default, so not needed. There are edge cases, but let's ignore them for now

App behaviour for cycle shops:

  • only map if "free for everyone always" when shop is open
    -- if it's inside: add service:bicycle:pump=yes to the shop
    -- outside: give back text "please add a cycle pump outdoors after you finish with the shop" and add service:bicycle:pump=oudoor

Nice to have: opening hours editor so that people can add them while they visit a shop!

We need to account for pumps that are taken back inside
"Does this pump belong to a shop?"
if yes > fill in "operator" with name of that shop
if yes > ASK "Is this pump only available when the shop is open?"
if YES: opening_hours=linked (on the compressed_air wiki but otherwise undocumented it seems)
if NO: opening_hours=24/7

@joostschouppe
Copy link
Member Author

Migrated to osmbe/cyclofix-website#4 for public review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants