Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC constexpr issues #34

Closed
joto opened this issue Aug 20, 2014 · 4 comments
Closed

MSVC constexpr issues #34

joto opened this issue Aug 20, 2014 · 4 comments
Labels
windows

Comments

@joto
Copy link
Member

joto commented Aug 20, 2014

It seems MSVC does not support constexpr properly. Instead of littering the code with ifdefs, does it make sense to define a 'OSMIUM_CONSTEXPR' once depending on compiler and use that? Are all cases of constexpr problematic, or only some of them?

@alex85k: Opinions?
@joto joto mentioned this issue Aug 20, 2014
Closed
30 tasks
@joto joto added the windows label Aug 20, 2014
@alex85k
Copy link

alex85k commented Aug 20, 2014

Only the most "hard" constexpr are not supported by November CTP. For example, ones returning objects. Nothing wrong with "compiler-calculated constants".

We can use OSMIUM_CONSTEXPR for them (including some common header?)
The support will be better in VS 14 but it is better to have compilable version before it.

@alex85k
Copy link

alex85k commented Aug 20, 2014

Many of the remaining constexpr are ignored currently, but the situation will improve next year.

@joto joto closed this as completed in efaffc3 Aug 21, 2014
@alex85k
Copy link

alex85k commented Aug 22, 2014

Please also check (and include) alex85k@d07f43e

@joto
Copy link
Member Author

joto commented Aug 22, 2014

Merged as 72844f4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
windows
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joto @alex85k