Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-imagery from index #124

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Remove non-imagery from index #124

merged 1 commit into from
Jan 7, 2016

Conversation

pnorman
Copy link
Contributor

@pnorman pnorman commented Jan 7, 2016

Fixes #119
Fixes #66
Fixes #15

@bhousel
Copy link
Member

bhousel commented Jan 7, 2016

LGTM 👍

pnorman added a commit that referenced this pull request Jan 7, 2016
@pnorman pnorman merged commit 959c09b into osmlab:gh-pages Jan 7, 2016
@simonpoole
Copy link
Contributor

Ahemm the layer is quite popular and further there are quite a few non-imagery layers that you missed ... in general the clean up is silly, because the editor maintainers will then simply add them back again manually which seems to make the whole project rather pointless.

@pnorman
Copy link
Contributor Author

pnorman commented Jan 7, 2016

It's not about non-imagery, it's about OSM-derived layers.

@simonpoole
Copy link
Contributor

Of the 26 global layers 18 are derived from OSM. While theoretically
naturally the information contained in the layers could be re-created
from OSM data, in practical terms providing it via a layer is the
most-cost effective and likely only practical solution.

Not to mention that there are dozen of non-imagery layers at a regional level.

Am 07.01.2016 um 17:37 schrieb Paul Norman:

It's not about non-imagery, it's about OSM-derived layers.


Reply to this email directly or view it on GitHub
#124 (comment).

@pnorman pnorman deleted the prune_osm_derived branch January 8, 2016 01:09
@tyrasd
Copy link
Member

tyrasd commented Jan 9, 2016

I think @simonpoole has a point here, and a solution like simonpoole/osm-layer-index@5472443 seems to be much more elegant (iD could choose to exclude all or most non-imagery layers while another editor may want to use all of them).

bhousel added a commit to openstreetmap/iD that referenced this pull request Jan 20, 2016
@jfirebaugh
Copy link
Contributor

I agree with @tyrasd and @simonpoole -- the intent of this repository was to be an inclusive collection of layers useful to editors, not to be exclusively aerial imagery sources. This and this move us back toward editors each having their own custom lists of imagery. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants