Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check.py improvements #510

Merged
merged 49 commits into from
Jun 14, 2018
Merged

Check.py improvements #510

merged 49 commits into from
Jun 14, 2018

Conversation

grischard
Copy link
Collaborator

Partially addresses #428

Usage improvements:

  • Show progress bar instead of dots
  • Add -v argument to increase verbosity
  • Colour output and better logging

Check improvements:

  • Report embedded icons. Disembedding all icons would save 578.54 KB - worth it on a 1.71 MB file, I think!
  • Check for missing license_url - see Sources missing a license #439
  • Check for wms/tms tokens in URLs - we've had some missing {proj} before.
  • Check for either default or geometry polygon. Many layers have neither, and will never be shown.

@grischard grischard self-assigned this Jun 13, 2018
@grischard
Copy link
Collaborator Author

The build is failing because of the missing geometries.

@grischard
Copy link
Collaborator Author

As part of this, I'll mark all the layers in sources/world as default. @bhousel I think that you intentionally blacklist many of these layers in iD, do you want to preemptively add them?

Heads up to @bryceco @simonpoole too.

simon04 and others added 2 commits June 13, 2018 12:32
@simon04 @grischard
feat: add license to schema.json (#344)
0fb15b4 
* feat: add license to schema.json

This allows other users of this index to determine layers with
compatible licenses.

* feat: validate licenses using SPDX identifier

* chore: add licenses to AT layers

* chore: add licenses to DE layers

* feat: add permission_osm to schema.json

* chore: add permission_osm to AT layers

Reference: https://wiki.openstreetmap.org/wiki/Contributors#Austria
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
49e9899 
…dex.git:gh-pages
@simonpoole
Copy link
Contributor

@grischard we currently only use the default attribute in sorting, so likely no big impact. I'm not that convinced that it really has useful semantics, or if it is suppose to have them, then maybe they have to be spelled out more clearly.

@bhousel
Copy link
Member

bhousel commented Jun 13, 2018

as part of this, I'll mark all the layers in sources/world as default. @bhousel I think that you intentionally blacklist many of these layers in iD, do you want to preemptively add them?

I'm not sure what you mean by this? I just did a search and I don't think iD is using the default property, so feel free to change it..

Marc-marc-marc and others added 18 commits June 13, 2018 19:00
@Marc-marc-marc
BE : add OpenStreetMap-BelgianStyle
9c9ebff
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
735ec81 
…dex.git:gh-pages
@grischard
Linter improvements: see #428
7ec0378
@grischard
Fixed style, adjusted assumptions on global layers
70cef21
@grischard
pep8
ed847bb
@bhousel
make txpull
38e2324
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
33f752a 
…dex.git:gh-pages
@grischard
rebase
b626295
@grischard
fix rebase junk
978b0f9
@grischard
Update requirements.txt
3abb8f6
@tbertels @grischard
Make Belgium sources translatable (#508)
dfbb342 
* +"i18n": true
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
f72f069 
…dex.git:gh-pages
@grischard
txpull
c6f7e6c
@grischard
Added transifex-client to requirements.txt
3dde462
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
31aee24 
…dex.git:gh-pages
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
99e351c 
…dex.git:gh-pages
@grischard
Use unique resolver to cache json schema references. Speed up checks …
cad0ccb 
…massively.
@grischard
Merge branch 'gh-pages' of github.com:osmlab/editor-layer-index into …
0da1be1 
…gh-pages
grischard and others added 25 commits June 14, 2018 14:18
@grischard
Set preview map maxzoom
1c87c86
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
0ad0761 
…dex.git:gh-pages
@grischard
Setting preview map maxzoom to 25
d09290d 
Maxzoom 24 exists in the wild, this should allow testing of all layers.
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
802b058 
…dex.git:gh-pages
@grischard
Set maxzoom for tile layers too
36624f9
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
fb10a79 
…dex.git:gh-pages
@grischard
max_zoom for AGRIblack-and-white25m.geojson
3110251
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
59b4d51 
…dex.git:gh-pages
@grischard
Missing maxzoom
98574c0
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
b3b044d 
…dex.git:gh-pages
@grischard
Missing max_zoom, better Uster polygon
4526cd0
@grischard
Merge branch 'gh-pages' of github.com:osmlab/editor-layer-index into …
6fff79b 
…gh-pages
@grischard
Make max_zoom mandatory for tms
6de691c
@traviscibot
Deploy osmlab/editor-layer-index to github.com/osmlab/editor-layer-in…
1c74bac 
…dex.git:gh-pages
@grischard
rebase on gh-pages
5ea7a57
@grischard
Linter improvements: see #428
2fec0d1
@grischard
Linter improvements: see #428
80b605a
@grischard
Fixed style, adjusted assumptions on global layers
89b6790
@grischard
pep8
21a6959
@grischard
Update requirements.txt
a1a4151
@grischard
Use unique resolver to cache json schema references. Speed up checks …
f4160d0 
…massively.
@grischard
Make max_zoom mandatory for tms
b05f0b1
@grischard
rebase on gh-pages
86b07a6
@grischard
Merge branch 'geojsonlint' of github.com:osmlab/editor-layer-index in…
8744692 
…to geojsonlint
@grischard
Add RU geometries from geofabrik to Scanex. Thanks @Zverik
347434d
@grischard
Copy link
Collaborator Author

Ok, I think I'm happy with this and will merge it.

@grischard grischard merged commit 1242d0d into gh-pages Jun 14, 2018
@cicku cicku deleted the geojsonlint branch January 10, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@grischard grischard

Labels
code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grischard @simonpoole @bhousel @simon04 @traviscibot @Marc-marc-marc @tbertels