Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orthophotos for Helsinki region #532

Merged
merged 5 commits into from
Aug 9, 2018
Merged

Add orthophotos for Helsinki region #532

merged 5 commits into from
Aug 9, 2018

Conversation

NKAmapper
Copy link
Contributor

@NKAmapper NKAmapper commented Aug 8, 2018

This PR adds orthophotos for the Helsinki region, including Espoo and Vantaa

In some areas they are better than the existing national orthophotos from MML, so both have been given a "best" attribute.

Please note that tile size is 512 for this wms (tile_size).

Permission: Link

@grischard
Copy link
Collaborator

See #522 for the tile_size attribute.

@grischard
Copy link
Collaborator

But if it's a wms, I'm not sure I understand the 'tile_size' attribute?

We don't have the 'valid-georeference' attribute in ELI either. Maybe we should, but that's probably for another PR.

Can you add https://storage.theel0ja.info/imgup3/Screen%20Shot%202018-08-07%20at%2019.15.29.png to the sources/europe/fi directory and link to it like we did on https://osmlab.github.io/editor-layer-index/sources/australia/au/act/ACTmapi-Imagery.PDF ?

I'm happy merging Espoo and Vantaa in the same PR too.

Removed tile_size and valid-georeference attributes + moved permission to ELI folder
@NKAmapper
Copy link
Contributor Author

NKAmapper commented Aug 8, 2018

Ok, done. Please ignore tile size, my mistake.

Espoo, Vantaa and Helsinki are already included in this PR, so no additional imagery needed (one combined wms for all three cities).

@grischard grischard merged commit 78179c4 into osmlab:gh-pages Aug 9, 2018
@grischard
Copy link
Collaborator

Thank you!

@NKAmapper
Copy link
Contributor Author

NKAmapper commented Aug 15, 2018

#339 may be closed now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants