Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new channel types: homepage, github, youtube, wiki #200

Closed
planemad opened this issue Nov 30, 2018 · 5 comments
Closed

Support new channel types: homepage, github, youtube, wiki #200

planemad opened this issue Nov 30, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@planemad
Copy link

planemad commented Nov 30, 2018

From
#199 (comment)

It looks like for India we need new channel types that are not currently supported:

Any objections to adding this?

cc @naveenpf

@planemad planemad added the enhancement New feature or request label Nov 30, 2018
@naveenpf
Copy link
Contributor

github is not supported ?

@planemad
Copy link
Author

Possibly because it is not considered a medium primarily for community discussions, just as youtube and the wiki.

Theres value in adding this though as it does make it easier to find all this information in a single place especially for someone new.

@planemad planemad changed the title Support new channel types: youtube and wiki Support new channel types: homepage, github, youtube, wiki Nov 30, 2018
planemad pushed a commit that referenced this issue Nov 30, 2018
Ref #200

Support new channel types: homepage, github, youtube, wiki
@bhousel
Copy link
Member

bhousel commented Dec 2, 2018

Thanks @planemad - I merged #201

I'm going to

  • update the contributing document
  • make sure all the new types have icons generated
  • (edited: see below) leave "group" but change "homepage" to "url"

@bhousel
Copy link
Member

bhousel commented Dec 2, 2018

Actually thinking about it more, it seems reasonable to leave "group" for local chapters and add "url" for other sites (as long as we communicate this clearly in the docs)

@bhousel bhousel closed this as completed in dd4c162 Dec 3, 2018
@bhousel
Copy link
Member

bhousel commented Dec 3, 2018

ok, this was done! The new complete list of types is now:

  • "discord"
  • "discourse"
  • "facebook"
  • "forum" - For example, on forum.openstreetmap.org
  • "github"
  • "group" - A site for a local group with a url (such as a local OSM chapter page)
  • "irc" - url should be a clickable web join link, server details can go in description
  • "mailinglist" - url should be a link to the listinfo page, e.g. https://lists.openstreetmap.org/listinfo/talk-us
  • "matrix" - e.g. Riot Chat
  • "meetup"
  • "osm" - a local OpenStreetMap page
  • "reddit"
  • "slack" - url should link to the Slack itself, and signupUrl can link to an inviter service (see example above)
  • "telegram"
  • "twitter"
  • "url" - Generic catchall for anything with a url
  • "wiki" - An OpenStreetMap wiki project page
  • "youtube"

also, each type maps to an icon under dist/img/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants