-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9 RC Blocker] Upgrade Main to Cosmwasm v0.27.0.rc3 #1502
Comments
I'm trying |
Having a problem with upgrading wasmd. Osmosis depends on cosmos-sdk from our own fork while wasmd utilizes the upstream. When I bump up the version for wasmd to 0.26 it complains about needing to depend on our fork. As I've done before, I tried to just switch wasmd 0.26 to depend on our own fork and tag it. However, that broke some tests. Seems that the new wasmd relies on some updates from the latest v0.45.4 release of the sdk upstream. Any suggestions on how to deal with this? |
The problem is resolved. Went with |
Ran into another issue where I cannot build images with the new cosmwasm: https://github.com/osmosis-labs/osmosis/runs/6459547928?check_suite_focus=true I made sure to match the wasmvm and wasmd versions according to: https://github.com/osmosis-labs/wasmd#compatibility Also, as previously, Dockerfile changes are adapted from: https://github.com/CosmWasm/wasmd/blob/dc5ef6fe84f0a5e3b0894692a18cc48fb5b00adf/Dockerfile#L22 This is the failing job that attempts to build this image If anyone is familiar with these issues, I would appreciate any pointers |
hey, I would like to recommend:
Happy to help with either |
I am intimately familiar with these dockerfile issues. I recommend: ghcr.io/faddat/cosmos it is designed specifically as the solution to the docker issues mentioned. |
@p0mvn I am hopping onto the wasmd issue. 27 gets us state sync |
@faddat thanks. I'm concerned that 0.27 is an rc though. Has it been used by other chains? |
Also, the wasmd problem is solved for 0.26 on this branch: https://github.com/osmosis-labs/wasmd/tree/v0.26.0-osmo I suspect that the fix for v0.27 would require similar changes |
actually reading through that branch now. v27 hasn't been tested on other chains, but -- wait-- yes it has.it is on juno (not quite v27 but very close) and (pieces of it?) are on scrt I think |
We shouldn't cut an osmosis release with it as an rc, though it's worth noting that Juno hasn't had issues. We needed sudo for the implementation of prop 16 iirc I'll prep 27, you proceed with the other pieces, @p0mvn ? |
Essentially, what's done on the linked branch of wasmd is making it use the same SDK and IAVL as Osmosis. Once go.mod is changed accordingly, there will be a few places requiring manual code changes |
yep -- in fact I just used your commit :) but need to update our SDK it seems, would you like me to? |
Yeah I'll keep trying to figure out the Docker images issue. Will try the images you shared. Thanks |
awesome :D. I'll check back when progress or computer has exploded |
ah, I almost forgot -- here's the source for those docker images: https://github.com/faddat/archlinux-docker
|
Why do you need to update the SDK? When we update the version of SDK in go.mod of wasmd, there will be some issues post-update. I think wasmd needs to be updated to match our SDK fork API |
I might not-- I found your work on osmosis-labs/cosmos-sdk :) |
So wait...are we using 0.26 or 0.27? |
My thoughts: We should prep with v0.26.0 If I can finish v0.27.0 we should consider it. Currently getting snapshots over the line, I think. There were changes to the wasm snapshots, which would affect our cosmos-sdk. Also, if we would like to go fast fast-- might as well use v0.26 + ibc v2.2.0 as - is, and come back to this at a later time. |
Unfortunately, @faddat's images did not help and had the same problem. I opened an issue in wasmd: CosmWasm/wasmd#861 and going to continue debugging in the meantime |
Also, I switched to trying to integrate |
thank you @p0mvn ! Really excited about this. |
Created: https://github.com/osmosis-labs/wasmd/releases/tag/v0.27.0.rc3-osmo Next, need to upgrade the following in Osmosis:
|
Background
We need to upgrade main from wasmd 0.24 to either 0.26 or 0.27. This is a blocker for RC0 release of v9. This change should be competed by tomorrow, Tuesday May 17th.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: