Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwapRouter] misc: Delete duplication of SwapAmountInRoute between gamm module and swap router module #3921

Closed
mattverse opened this issue Jan 4, 2023 · 6 comments · Fixed by #4039
Assignees
Labels
C:x/swaprouter F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board Help wanted

Comments

@mattverse
Copy link
Member

Background

cref: #3880 (comment)

Right now, we have two implementations of SwapAmountInRoute, one in the gamm module(legacy) and the new SwapAmountInRoute struct / proto that has been introduced in the swap router module.

There is no reason to keep both structs: the goal of this issue is to delete the SwapAmountInRoute from the gamm module and remove duplication of the struct between modules.

The same goes for SwapAmountOutRoute.

Suggested Design

  • Remove SwapAmountInRoute from gamm module
  • Remove SwapAmountOutRoute from gamm module
@hieuvubk
Copy link
Contributor

hieuvubk commented Jan 5, 2023

Could I work with it

@mattverse
Copy link
Member Author

@hieuvubk We're trying to get the swap router / concentrated liquidity asap, but as long as this doesn't take to long, yeah go for it!

@p0mvn
Copy link
Member

p0mvn commented Jan 7, 2023

Would like to note that this is blocked on #3880. Please wait for that to be merged

@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jan 13, 2023
@p0mvn p0mvn added this to the CL 8: Fees and Misc Bug Fixes milestone Jan 13, 2023
@p0mvn
Copy link
Member

p0mvn commented Jan 13, 2023

Marked this as "Help wanted" since this is not on the critical path.

@phamminh0811
Copy link
Contributor

Could I work with it?

@mattverse
Copy link
Member Author

@phamminh0811 yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/swaprouter F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board Help wanted
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants