Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete osmomath.BigDec.ApproxRoot #8007

Open
ValarDragon opened this issue Apr 10, 2024 · 2 comments
Open

Delete osmomath.BigDec.ApproxRoot #8007

ValarDragon opened this issue Apr 10, 2024 · 2 comments

Comments

@ValarDragon
Copy link
Member

Summary

As far as I can tell, this is only used to derive some constants in a stableswap test. We can just hardcode those constants, and get this code out of the repo.

Problem Definition

.

Proposed Feature

Delete code

@jbsummoner
Copy link

used here too

@ValarDragon
Copy link
Member Author

ValarDragon commented Apr 22, 2024

Ah thanks! Maybe we should just move that solve_cfmm_direct function to testing and approx root to testing in stableswap then.

Neither is used in the production state machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

2 participants