Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing symlinks #18

Closed
csarven opened this issue Jan 2, 2021 · 1 comment · Fixed by #29
Closed

Changing symlinks #18

csarven opened this issue Jan 2, 2021 · 1 comment · Fixed by #29

Comments

@csarven
Copy link

csarven commented Jan 2, 2021

Symlinks appear to change on ls but I'm not certain if is the true cause. It also appears to change after the symlink is broken and there is subsequent read event.

$ uname -a
Linux 5.4.0-58-generic #64-Ubuntu SMP Wed Dec 9 08:16:25 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux )

$ fsck -N /dev/sda2
fsck from util-linux 2.34
[/sbin/fsck.ext4 (1) -- /] fsck.ext4 /dev/sda2

$ mount | grep "^/dev"
/dev/sda2 on / type ext4 (rw,relatime,errors=remount-ro)
/dev/fuse on /run/user/1000/doc type fuse (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)

I've tried the extension in Firefox Nightly 86.0a1 (2020-12-31) (64-bit) and Chromium Version 83.0.4103.116 (Developer Build) built on Debian bullseye/sid, running on Debian bullseye/sid (64-bit)

The symlinks in mnt/tabs/by-title/ appear to be dangling when broken eg:

Sarven_Capadisli_35 -> ../by-id/35ndows/10

Once the add-on is reloaded, everything is back to normal ie. when working:

Sarven_Capadisli_35 -> ../by-id/35

And when working in mnt/tabs/:

last-focused -> 'by-id/35'$'\004'

and when broken:

last-focused -> by-id/35/11

also noted when broken:

last-focused -> by-id/35/windows/10

and:

last-focused -> by-id/35/35ndows/10

The last two appears to happen if I cause an event related to 35 eg. reading a file under tab 35.

Happy to run commands if you'd like to get to the bottom of it.


Edit:

How to reproduce:

csarven@nevrasc:/var/www/TabFS$ ls -la fs/mnt/tabs/
total 0
drwxr-xr-x 3 root root   0 Jan  1  1970 .
drwxr-xr-x 3 root root   0 Jan  1  1970 ..
drwxr-xr-x 3 root root   0 Jan  1  1970 by-id
drwxrwxrwx 3 root root   0 Jan  1  1970 by-title
--w--w--w- 1 root root 100 Jan  1  1970 create
lr--r--r-- 1 root root   9 Jan  1  1970 last-focused -> 'by-id/14'$'\004'

csarven@nevrasc:/var/www/TabFS$ ls -la fs/mnt/tabs/by-title/
total 0
drwxrwxrwx 3 root root  0 Jan  1  1970 .
drwxr-xr-x 3 root root  0 Jan  1  1970 ..
lr--r--r-- 1 root root 12 Jan  1  1970 Extensions_14 -> ../by-id/14
lr--r--r-- 1 root root 12 Jan  1  1970 Sarven_Capadisli_35 -> ../by-id/35

csarven@nevrasc:/var/www/TabFS$ ls -la fs/mnt/tabs/by-title/Sarven_Capadisli_35/
ls: cannot access 'fs/mnt/tabs/by-title/Sarven_Capadisli_35/control': No such file or directory
ls: cannot access 'fs/mnt/tabs/by-title/Sarven_Capadisli_35/debugger': No such file or directory
total 0
drwxr-xr-x 3 root root     0 Jan  1  1970 .
drwxr-xr-x 3 root root     0 Jan  1  1970 ..
-r--r--r-- 1 root root     0 Jan  1  1970 console
?????????? ? ?    ?        ?            ? control
?????????? ? ?    ?        ?            ? debugger
-r--r--r-- 1 root root 69627 Jan  1  1970 dom.html
--w--w--w- 1 root root   100 Jan  1  1970 execute-script
-r--r--r-- 1 root root   419 Jan  1  1970 text.txt
-r--r--r-- 1 root root    17 Jan  1  1970 title.txt
-rw-rw-rw- 1 root root    20 Jan  1  1970 url.txt
lr--r--r-- 1 root root    20 Jan  1  1970 window -> ../../../windows/10

csarven@nevrasc:/var/www/TabFS$ cat fs/mnt/tabs/by-title/Sarven_Capadisli_35/url.txt
cat: fs/mnt/tabs/by-title/Sarven_Capadisli_35/url.txt: No such file or directory

I've reloaded the extension and then:

csarven@nevrasc:/var/www/TabFS$ cat fs/mnt/tabs/by-title/Sarven_Capadisli_35/url.txt
https://csarven.ca/
@csarven csarven changed the title Mount appears to drop randomly Changing in symlinks Jan 2, 2021
@csarven csarven changed the title Changing in symlinks Changing symlinks Jan 2, 2021
@rareranger
Copy link
Contributor

rareranger commented Jan 3, 2021

I don't know why but this workaround seems to work

Workaround

And it doesn't appear to break anything

#26

@osnr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants