Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MOI v0.9.5 #66

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Update to MOI v0.9.5 #66

merged 1 commit into from
Oct 25, 2019

Conversation

blegat
Copy link
Collaborator

@blegat blegat commented Oct 12, 2019

Closes #64

@blegat
Copy link
Collaborator Author

blegat commented Oct 12, 2019

@bstellato
Copy link
Collaborator

We compile the solver with default options for the binaries (see here for windows). Default options are: DLONG=ON and DFLOAT=OFF.

As @tkoolen mentioned, we define c_int and c_float here according to the option.

In OSQP.jl we map the short/long int C type to the julia one in here. This made it work for 32bit until now. Did anything in Julia change to make it fail? Our binary build system did not change since last OSQP.jl release.

@blegat
Copy link
Collaborator Author

blegat commented Oct 25, 2019

I am merging to allow to check that OSQP master work with MOI master (see https://travis-ci.com/blegat/SolverTests/jobs/249637424) before releasing MOI v0.9.6. I am opening a separate issue about the 32-bit issue.

@blegat blegat merged commit 45a436f into master Oct 25, 2019
@blegat blegat mentioned this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing with MOI 0.9.5
3 participants