Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDNS virtual table #17

Closed
marpaia opened this issue Aug 1, 2014 · 1 comment
Closed

MDNS virtual table #17

marpaia opened this issue Aug 1, 2014 · 1 comment

Comments

@marpaia
Copy link
Contributor

marpaia commented Aug 1, 2014

Create a virtual table on OS X which exposes MDNS settings. This may be a good stand-alone virtual table or a set of platform specific columns for #10.

@marpaia marpaia added this to the Deploy on OS X milestone Aug 1, 2014
@marpaia marpaia modified the milestone: Deploy on OS X Sep 2, 2014
@theopolis
Copy link
Member

Using a master task of issues: #619

muffins added a commit to muffins/osquery that referenced this issue Oct 19, 2019
Summary:

This adds tests for the windows and darwin conversions strings helper
classes. Darwin currently has tests, but they are not hooked up and
being run. Windows does not have tests, this adds two simple unit tests
against the logic for our string conversions.

Test Plan:

Run the tests, unsure what's up with the config tests failing, will
investigate but I think they're unrelated to this change?:
```
PS C:\Users\thor\work\repos\osquery\build\windows10> cmake --build .
--config RelWithDebInfo -j10 --target run_tests
Microsoft (R) Build Engine version 16.3.1+1def00d3d for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Test project C:/Users/thor/work/repos/osquery/build/windows10
          Start  1: osquery_dispatcher_tests-test
	     1/70 Test  #1: osquery_dispatcher_tests-test
	     .................................   Passed    3.21 sec
	             Start  2: osquery_dispatcher_tests_scheduler-test
		        2/70 Test  #2:
			osquery_dispatcher_tests_scheduler-test
			.......................   Passed    6.91 sec
			        Start  3: osquery_sql_tests-test
				   3/70 Test  #3: osquery_sql_tests-test
				   ........................................
				   Passed    2.81 sec
				           Start  4:
					   osquery_sql_tests_virtualtabletests-test
					      4/70 Test  #4:
					      osquery_sql_tests_virtualtabletests-test
					      ......................
					      Passed    3.24 sec
					              Start  5:
						      osquery_sql_tests_sqliteutilstests-test
						         5/70 Test  #5:
							 osquery_sql_tests_sqliteutilstests-test
							 .......................
							 Passed    3.39
							 sec
							         Start
								 6:
								 osquery_sdk_tests_pluginsdktests-test
								    6/70
								    Test
								    #6:
								    osquery_sdk_tests_pluginsdktests-test
								    .........................
								    Passed
								    2.84
								    sec
								            Start
									    7:
									    osquery_numericmonitoring_tests-test
									       7/70
									       Test
									       #7:
									       osquery_numericmonitoring_tests-test
									       ..........................
									       Passed
									       3.01
									       sec
									               Start
										       8:
										       osquery_numericmonitoring_tests_preaggregationcache-test
										          8/70
											  Test
											  #8:
											  osquery_numericmonitoring_tests_preaggregationcache-test
											  ......
											  Passed
											  2.90
											  sec
											          Start
												  9:
												  osquery_killswitch_tests-test
												     9/70
												     Test
												     #9:
												     osquery_killswitch_tests-test
												     .................................
												     Passed
												     2.72
												     sec
												             Start
													     10:
													     osquery_registry_tests-test
													       10/70
													       Test
													       #10:
													       osquery_registry_tests-test
													       ...................................
													       Passed
													       2.95
													       sec
													               Start
														       11:
														       osquery_logger_tests-test
														         11/70
															 Test
															 #11:
															 osquery_logger_tests-test
															 .....................................
															 Passed
															 2.91
															 sec
															         Start
																 12:
																 osquery_distributed_tests-test
																   12/70
																   Test
																   #12:
																   osquery_distributed_tests-test
																   ................................
																   Passed
																   3.02
																   sec
																           Start
																	   13:
																	   osquery_carver_tests-test
																	     13/70
																	     Test
																	     #13:
																	     osquery_carver_tests-test
																	     .....................................
																	     Passed
																	     2.88
																	     sec
																	             Start
																		     14:
																		     osquery_tables_events_tests_fileeventstests-test
																		       14/70
																		       Test
																		       #14:
																		       osquery_tables_events_tests_fileeventstests-test
																		       ..............
																		       Passed
																		       3.09
																		       sec
																		               Start
																			       15:
																			       osquery_tables_networking_tests_networkingtablestests-test
																			         15/70
																				 Test
																				 #15:
																				 osquery_tables_networking_tests_networkingtablestests-test
																				 ....
																				 Passed
																				 5.22
																				 sec
																				         Start
																					 16:
																					 osquery_tables_system_tests_certificatestests-test
																					   16/70
																					   Test
																					   #16:
																					   osquery_tables_system_tests_certificatestests-test
																					   ............
																					   Passed
																					   2.99
																					   sec
																					           Start
																						   17:
																						   osquery_tables_system_tests_registrytests-test
																						     17/70
																						     Test
																						     #17:
																						     osquery_tables_system_tests_registrytests-test
																						     ................
																						     Passed
																						     3.65
																						     sec
																						             Start
																							     18:
																							     osquery_tables_system_tests_systemtablestests-test
																							       18/70
																							       Test
																							       #18:
																							       osquery_tables_system_tests_systemtablestests-test
																							       ............
																							       Passed
																							       7.32
																							       sec
																							               Start
																								       19:
																								       osquery_remote_tests_requeststests-test
																								         19/70
																									 Test
																									 #19:
																									 osquery_remote_tests_requeststests-test
																									 .......................
																									 Passed
																									 2.37
																									 sec
																									         Start
																										 20:
																										 osquery_remote_serializers_remotejsonserializerstests-test
																										   20/70
																										   Test
																										   #20:
																										   osquery_remote_serializers_remotejsonserializerstests-test
																										   ....
																										   Passed
																										   1.59
																										   sec
																										           Start
																											   21:
																											   osquery_remote_enroll_remoteenrolltests-test
																											     21/70
																											     Test
																											     #21:
																											     osquery_remote_enroll_remoteenrolltests-test
																											     ..................
																											     Passed
																											     2.89
																											     sec
																											             Start
																												     22:
																												     osquery_core_tests_flagstests-test
																												       22/70
																												       Test
																												       #22:
																												       osquery_core_tests_flagstests-test
																												       ............................
																												       Passed
																												       3.18
																												       sec
																												               Start
																													       23:
																													       osquery_core_tests_systemtests-test
																													         23/70
																														 Test
																														 #23:
																														 osquery_core_tests_systemtests-test
																														 ...........................
																														 Passed
																														 3.19
																														 sec
																														         Start
																															 24:
																															 osquery_core_tests_tablestests-test
																															   24/70
																															   Test
																															   #24:
																															   osquery_core_tests_tablestests-test
																															   ...........................
																															   Passed
																															   2.97
																															   sec
																															           Start
																																   25:
																																   osquery_core_tests_watcherpermissionstests-test
																																     25/70
																																     Test
																																     #25:
																																     osquery_core_tests_watcherpermissionstests-test
																																     ...............
																																     Passed
																																     3.27
																																     sec
																																             Start
																																	     26:
																																	     osquery_core_tests_querytests-test
																																	       26/70
																																	       Test
																																	       #26:
																																	       osquery_core_tests_querytests-test
																																	       ............................
																																	       Passed
																																	       3.50
																																	       sec
																																	               Start
																																		       27:
																																		       osquery_core_tests_processtests-test
																																		         27/70
																																			 Test
																																			 #27:
																																			 osquery_core_tests_processtests-test
																																			 ..........................
																																			 Passed
																																			 4.31
																																			 sec
																																			         Start
																																				 28:
																																				 osquery_config_tests-test
																																				   28/70
																																				   Test
																																				   #28:
																																				   osquery_config_tests-test
																																				   .....................................***Failed
																																				   14.43
																																				   sec
																																				           Start
																																					   29:
																																					   osquery_config_tests_packs-test
																																					     29/70
																																					     Test
																																					     #29:
																																					     osquery_config_tests_packs-test
																																					     ...............................
																																					     Passed
																																					     2.90
																																					     sec
																																					             Start
																																						     30:
																																						     osquery_utils_utilstests-test
																																						       30/70
																																						       Test
																																						       #30:
																																						       osquery_utils_utilstests-test
																																						       .................................
																																						       Passed
																																						       2.09
																																						       sec
																																						               Start
																																							       31:
																																							       osquery_utils_aws_tests-test
																																							         31/70
																																								 Test
																																								 #31:
																																								 osquery_utils_aws_tests-test
																																								 ..................................
																																								 Passed
																																								 3.11
																																								 sec
																																								         Start
																																									 32:
																																									 osquery_utils_caches_tests_lrutests-test
																																									   32/70
																																									   Test
																																									   #32:
																																									   osquery_utils_caches_tests_lrutests-test
																																									   ......................
																																									   Passed
																																									   1.49
																																									   sec
																																									           Start
																																										   33:
																																										   osquery_utils_system_errno_errnotests-test
																																										     33/70
																																										     Test
																																										     #33:
																																										     osquery_utils_system_errno_errnotests-test
																																										     ....................
																																										     Passed
																																										     1.53
																																										     sec
																																										             Start
																																											     34:
																																											     osquery_utils_system_time_timetest-test
																																											       34/70
																																											       Test
																																											       #34:
																																											       osquery_utils_system_time_timetest-test
																																											       .......................
																																											       Passed
																																											       1.45
																																											       sec
																																											               Start
																																												       35:
																																												       osquery_utils_system_linux_proc_proctests-test
																																												         35/70
																																													 Test
																																													 #35:
																																													 osquery_utils_system_linux_proc_proctests-test
																																													 ................
																																													 Passed
																																													 0.96
																																													 sec
																																													         Start
																																														 36:
																																														 osquery_utils_status_statustests-test
																																														   36/70
																																														   Test
																																														   #36:
																																														   osquery_utils_status_statustests-test
																																														   .........................
																																														   Passed
																																														   1.50
																																														   sec
																																														           Start
																																															   37:
																																															   osquery_utils_json_jsontests-test
																																															     37/70
																																															     Test
																																															     #37:
																																															     osquery_utils_json_jsontests-test
																																															     .............................
																																															     Passed
																																															     1.71
																																															     sec
																																															             Start
																																																     38:
																																																     osquery_utils_error_errortests-test
																																																       38/70
																																																       Test
																																																       #38:
																																																       osquery_utils_error_errortests-test
																																																       ...........................
																																																       Passed
																																																       2.09
																																																       sec
																																																               Start
																																																	       39:
																																																	       osquery_utils_debug_debugtests-test
																																																	         39/70
																																																		 Test
																																																		 #39:
																																																		 osquery_utils_debug_debugtests-test
																																																		 ...........................
																																																		 Passed
																																																		 1.60
																																																		 sec
																																																		         Start
																																																			 40:
																																																			 osquery_utils_expected_expectedtests-test
																																																			   40/70
																																																			   Test
																																																			   #40:
																																																			   osquery_utils_expected_expectedtests-test
																																																			   .....................
																																																			   Passed
																																																			   1.64
																																																			   sec
																																																			           Start
																																																				   41:
																																																				   osquery_utils_conversions_windowstests-test
																																																				     41/70
																																																				     Test
																																																				     #41:
																																																				     osquery_utils_conversions_windowstests-test
																																																				     ...................
																																																				     Passed
																																																				     3.00
																																																				     sec
																																																				             Start
																																																					     42:
																																																					     osquery_utils_conversions_conversionstests-test
																																																					       42/70
																																																					       Test
																																																					       #42:
																																																					       osquery_utils_conversions_conversionstests-test
																																																					       ...............
																																																					       Passed
																																																					       1.43
																																																					       sec
																																																					               Start
																																																						       43:
																																																						       osquery_utils_conversions_totests-test
																																																						         43/70
																																																							 Test
																																																							 #43:
																																																							 osquery_utils_conversions_totests-test
																																																							 ........................
																																																							 Passed
																																																							 1.37
																																																							 sec
																																																							         Start
																																																								 44:
																																																								 osquery_utils_versioning_semanticversiontest-test
																																																								   44/70
																																																								   Test
																																																								   #44:
																																																								   osquery_utils_versioning_semanticversiontest-test
																																																								   .............
																																																								   Passed
																																																								   1.95
																																																								   sec
																																																								           Start
																																																									   45:
																																																									   osquery_utils_schemer_tests_schemertests-test
																																																									     45/70
																																																									     Test
																																																									     #45:
																																																									     osquery_utils_schemer_tests_schemertests-test
																																																									     .................
																																																									     Passed
																																																									     1.76
																																																									     sec
																																																									             Start
																																																										     46:
																																																										     osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       46/70
																																																										       Test
																																																										       #46:
																																																										       osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       ........
																																																										       Passed
																																																										       1.78
																																																										       sec
																																																										               Start
																																																											       47:
																																																											       osquery_filesystem_filesystemtests-test
																																																											         47/70
																																																												 Test
																																																												 #47:
																																																												 osquery_filesystem_filesystemtests-test
																																																												 .......................
																																																												 Passed
																																																												 3.86
																																																												 sec
																																																												         Start
																																																													 48:
																																																													 osquery_database_tests-test
																																																													   48/70
																																																													   Test
																																																													   #48:
																																																													   osquery_database_tests-test
																																																													   ...................................
																																																													   Passed
																																																													   2.79
																																																													   sec
																																																													           Start
																																																														   49:
																																																														   osquery_database_tests_results-test
																																																														     49/70
																																																														     Test
																																																														     #49:
																																																														     osquery_database_tests_results-test
																																																														     ...........................
																																																														     Passed
																																																														     3.12
																																																														     sec
																																																														             Start
																																																															     50:
																																																															     osquery_devtools_tests_printertests-test
																																																															       50/70
																																																															       Test
																																																															       #50:
																																																															       osquery_devtools_tests_printertests-test
																																																															       ......................
																																																															       Passed
																																																															       2.96
																																																															       sec
																																																															               Start
																																																																       51:
																																																																       osquery_extensions_extensiontests-test
																																																																         51/70
																																																																	 Test
																																																																	 #51:
																																																																	 osquery_extensions_extensiontests-test
																																																																	 ........................
																																																																	 Passed
																																																																	 7.42
																																																																	 sec
																																																																	         Start
																																																																		 52:
																																																																		 osquery_events_tests_eventsdatabasetests-test
																																																																		   52/70
																																																																		   Test
																																																																		   #52:
																																																																		   osquery_events_tests_eventsdatabasetests-test
																																																																		   .................
																																																																		   Passed
																																																																		   3.03
																																																																		   sec
																																																																		           Start
																																																																			   53:
																																																																			   osquery_events_tests_windowseventlogtests-test
																																																																			     53/70
																																																																			     Test
																																																																			     #53:
																																																																			     osquery_events_tests_windowseventlogtests-test
																																																																			     ................
																																																																			     Passed
																																																																			     3.00
																																																																			     sec
																																																																			             Start
																																																																				     54:
																																																																				     osquery_events_tests-test
																																																																				       54/70
																																																																				       Test
																																																																				       #54:
																																																																				       osquery_events_tests-test
																																																																				       .....................................
																																																																				       Passed
																																																																				       3.40
																																																																				       sec
																																																																				               Start
																																																																					       55:
																																																																					       osquery_ev2_ev2tests-test
																																																																					         55/70
																																																																						 Test
																																																																						 #55:
																																																																						 osquery_ev2_ev2tests-test
																																																																						 .....................................
																																																																						 Passed
																																																																						 1.62
																																																																						 sec
																																																																						         Start
																																																																							 56:
																																																																							 osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   56/70
																																																																							   Test
																																																																							   #56:
																																																																							   osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   ...
																																																																							   Passed
																																																																							   2.95
																																																																							   sec
																																																																							           Start
																																																																								   57:
																																																																								   plugins_config_parsers_tests_decoratorstests-test
																																																																								     57/70
																																																																								     Test
																																																																								     #57:
																																																																								     plugins_config_parsers_tests_decoratorstests-test
																																																																								     .............
																																																																								     Passed
																																																																								     5.43
																																																																								     sec
																																																																								             Start
																																																																									     58:
																																																																									     plugins_config_parsers_tests_eventsparsertests-test
																																																																									       58/70
																																																																									       Test
																																																																									       #58:
																																																																									       plugins_config_parsers_tests_eventsparsertests-test
																																																																									       ...........
																																																																									       Passed
																																																																									       3.82
																																																																									       sec
																																																																									               Start
																																																																										       59:
																																																																										       plugins_config_parsers_tests_filepathstests-test
																																																																										         59/70
																																																																											 Test
																																																																											 #59:
																																																																											 plugins_config_parsers_tests_filepathstests-test
																																																																											 ..............
																																																																											 Passed
																																																																											 6.13
																																																																											 sec
																																																																											         Start
																																																																												 60:
																																																																												 plugins_config_parsers_tests_optionstests-test
																																																																												   60/70
																																																																												   Test
																																																																												   #60:
																																																																												   plugins_config_parsers_tests_optionstests-test
																																																																												   ................
																																																																												   Passed
																																																																												   3.85
																																																																												   sec
																																																																												           Start
																																																																													   61:
																																																																													   plugins_config_parsers_tests_viewstests-test
																																																																													     61/70
																																																																													     Test
																																																																													     #61:
																																																																													     plugins_config_parsers_tests_viewstests-test
																																																																													     ..................
																																																																													     Passed
																																																																													     4.13
																																																																													     sec
																																																																													             Start
																																																																														     62:
																																																																														     plugins_database_tests_rocksdbtests-test
																																																																														       62/70
																																																																														       Test
																																																																														       #62:
																																																																														       plugins_database_tests_rocksdbtests-test
																																																																														       ......................
																																																																														       Passed
																																																																														       4.00
																																																																														       sec
																																																																														               Start
																																																																															       63:
																																																																															       plugins_database_tests_sqliteplugintests-test
																																																																															         63/70
																																																																																 Test
																																																																																 #63:
																																																																																 plugins_database_tests_sqliteplugintests-test
																																																																																 .................
																																																																																 Passed
																																																																																 3.56
																																																																																 sec
																																																																																         Start
																																																																																	 64:
																																																																																	 plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   64/70
																																																																																	   Test
																																																																																	   #64:
																																																																																	   plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   .......
																																																																																	   Passed
																																																																																	   3.17
																																																																																	   sec
																																																																																	           Start
																																																																																		   65:
																																																																																		   plugins_logger_tests_awskinesisloggertests-test
																																																																																		     65/70
																																																																																		     Test
																																																																																		     #65:
																																																																																		     plugins_logger_tests_awskinesisloggertests-test
																																																																																		     ...............
																																																																																		     Passed
																																																																																		     3.60
																																																																																		     sec
																																																																																		             Start
																																																																																			     66:
																																																																																			     plugins_logger_tests_bufferedloggertests-test
																																																																																			       66/70
																																																																																			       Test
																																																																																			       #66:
																																																																																			       plugins_logger_tests_bufferedloggertests-test
																																																																																			       .................
																																																																																			       Passed
																																																																																			       3.00
																																																																																			       sec
																																																																																			               Start
																																																																																				       67:
																																																																																				       plugins_logger_tests_filesystemloggertests-test
																																																																																				         67/70
																																																																																					 Test
																																																																																					 #67:
																																																																																					 plugins_logger_tests_filesystemloggertests-test
																																																																																					 ...............
																																																																																					 Passed
																																																																																					 3.20
																																																																																					 sec
																																																																																					         Start
																																																																																						 68:
																																																																																						 plugins_logger_tests_tlsloggertests-test
																																																																																						   68/70
																																																																																						   Test
																																																																																						   #68:
																																																																																						   plugins_logger_tests_tlsloggertests-test
																																																																																						   ......................
																																																																																						   Passed
																																																																																						   11.05
																																																																																						   sec
																																																																																						           Start
																																																																																							   69:
																																																																																							   plugins_numericmonitoring_tests_filesystem-test
																																																																																							     69/70
																																																																																							     Test
																																																																																							     #69:
																																																																																							     plugins_numericmonitoring_tests_filesystem-test
																																																																																							     ...............
																																																																																							     Passed
																																																																																							     3.03
																																																																																							     sec
																																																																																							             Start
																																																																																								     70:
																																																																																								     tests_integration_tables-test
																																																																																								       70/70
																																																																																								       Test
																																																																																								       #70:
																																																																																								       tests_integration_tables-test
																																																																																								       .................................
																																																																																								       Passed
																																																																																								       24.91
																																																																																								       sec

																																																																																								         99%
																																																																																									 tests
																																																																																									 passed,
																																																																																									 1
																																																																																									 tests
																																																																																									 failed
																																																																																									 out
																																																																																									 of
																																																																																									 70

																																																																																									   Total
																																																																																									   Test
																																																																																									   time
																																																																																									   (real)
																																																																																									   =
																																																																																									   258.07
																																																																																									   sec

																																																																																									     The
																																																																																									     following
																																																																																									     tests
																																																																																									     FAILED:
																																																																																									              28
																																																																																										      -
																																																																																										      osquery_config_tests-test
																																																																																										      (Failed)
																																																																																										        Errors
																																																																																											while
																																																																																											running
																																																																																											CTest
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											The
																																																																																											command
																																																																																											"setlocal
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											"C:\Program
																																																																																											Files\CMake\bin\ctest.exe"
																																																																																											--force-new-ctest-process
																																																																																											-C
																																																																																											RelWithDebInfo
																																																																																											[C:\Users\thor\work\repos\osquery\build\
																																																																																											windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											endlocal
																																																																																											&
																																																																																											call
																																																																																											:cmErrorLevel
																																																																																											%errorlevel%
																																																																																											&
																																																																																											goto
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxpr
																																																																																											oj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmErrorLevel
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											exit
																																																																																											/b
																																																																																											%1
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:VCEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:VCEnd"
																																																																																											exited
																																																																																											with
																																																																																											code
																																																																																											8.
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
```
muffins added a commit to muffins/osquery that referenced this issue Oct 19, 2019
Summary:

This adds tests for the windows and darwin conversions strings helper
classes. Darwin currently has tests, but they are not hooked up and
being run. Windows does not have tests, this adds two simple unit tests
against the logic for our string conversions.

Test Plan:

Run the tests, unsure what's up with the config tests failing, will
investigate but I think they're unrelated to this change?:
```
PS C:\Users\thor\work\repos\osquery\build\windows10> cmake --build .
--config RelWithDebInfo -j10 --target run_tests
Microsoft (R) Build Engine version 16.3.1+1def00d3d for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Test project C:/Users/thor/work/repos/osquery/build/windows10
          Start  1: osquery_dispatcher_tests-test
	     1/70 Test  #1: osquery_dispatcher_tests-test
	     .................................   Passed    3.21 sec
	             Start  2: osquery_dispatcher_tests_scheduler-test
		        2/70 Test  #2:
			osquery_dispatcher_tests_scheduler-test
			.......................   Passed    6.91 sec
			        Start  3: osquery_sql_tests-test
				   3/70 Test  #3: osquery_sql_tests-test
				   ........................................
				   Passed    2.81 sec
				           Start  4:
					   osquery_sql_tests_virtualtabletests-test
					      4/70 Test  #4:
					      osquery_sql_tests_virtualtabletests-test
					      ......................
					      Passed    3.24 sec
					              Start  5:
						      osquery_sql_tests_sqliteutilstests-test
						         5/70 Test  #5:
							 osquery_sql_tests_sqliteutilstests-test
							 .......................
							 Passed    3.39
							 sec
							         Start
								 6:
								 osquery_sdk_tests_pluginsdktests-test
								    6/70
								    Test
								    #6:
								    osquery_sdk_tests_pluginsdktests-test
								    .........................
								    Passed
								    2.84
								    sec
								            Start
									    7:
									    osquery_numericmonitoring_tests-test
									       7/70
									       Test
									       #7:
									       osquery_numericmonitoring_tests-test
									       ..........................
									       Passed
									       3.01
									       sec
									               Start
										       8:
										       osquery_numericmonitoring_tests_preaggregationcache-test
										          8/70
											  Test
											  #8:
											  osquery_numericmonitoring_tests_preaggregationcache-test
											  ......
											  Passed
											  2.90
											  sec
											          Start
												  9:
												  osquery_killswitch_tests-test
												     9/70
												     Test
												     #9:
												     osquery_killswitch_tests-test
												     .................................
												     Passed
												     2.72
												     sec
												             Start
													     10:
													     osquery_registry_tests-test
													       10/70
													       Test
													       #10:
													       osquery_registry_tests-test
													       ...................................
													       Passed
													       2.95
													       sec
													               Start
														       11:
														       osquery_logger_tests-test
														         11/70
															 Test
															 #11:
															 osquery_logger_tests-test
															 .....................................
															 Passed
															 2.91
															 sec
															         Start
																 12:
																 osquery_distributed_tests-test
																   12/70
																   Test
																   #12:
																   osquery_distributed_tests-test
																   ................................
																   Passed
																   3.02
																   sec
																           Start
																	   13:
																	   osquery_carver_tests-test
																	     13/70
																	     Test
																	     #13:
																	     osquery_carver_tests-test
																	     .....................................
																	     Passed
																	     2.88
																	     sec
																	             Start
																		     14:
																		     osquery_tables_events_tests_fileeventstests-test
																		       14/70
																		       Test
																		       #14:
																		       osquery_tables_events_tests_fileeventstests-test
																		       ..............
																		       Passed
																		       3.09
																		       sec
																		               Start
																			       15:
																			       osquery_tables_networking_tests_networkingtablestests-test
																			         15/70
																				 Test
																				 #15:
																				 osquery_tables_networking_tests_networkingtablestests-test
																				 ....
																				 Passed
																				 5.22
																				 sec
																				         Start
																					 16:
																					 osquery_tables_system_tests_certificatestests-test
																					   16/70
																					   Test
																					   #16:
																					   osquery_tables_system_tests_certificatestests-test
																					   ............
																					   Passed
																					   2.99
																					   sec
																					           Start
																						   17:
																						   osquery_tables_system_tests_registrytests-test
																						     17/70
																						     Test
																						     #17:
																						     osquery_tables_system_tests_registrytests-test
																						     ................
																						     Passed
																						     3.65
																						     sec
																						             Start
																							     18:
																							     osquery_tables_system_tests_systemtablestests-test
																							       18/70
																							       Test
																							       #18:
																							       osquery_tables_system_tests_systemtablestests-test
																							       ............
																							       Passed
																							       7.32
																							       sec
																							               Start
																								       19:
																								       osquery_remote_tests_requeststests-test
																								         19/70
																									 Test
																									 #19:
																									 osquery_remote_tests_requeststests-test
																									 .......................
																									 Passed
																									 2.37
																									 sec
																									         Start
																										 20:
																										 osquery_remote_serializers_remotejsonserializerstests-test
																										   20/70
																										   Test
																										   #20:
																										   osquery_remote_serializers_remotejsonserializerstests-test
																										   ....
																										   Passed
																										   1.59
																										   sec
																										           Start
																											   21:
																											   osquery_remote_enroll_remoteenrolltests-test
																											     21/70
																											     Test
																											     #21:
																											     osquery_remote_enroll_remoteenrolltests-test
																											     ..................
																											     Passed
																											     2.89
																											     sec
																											             Start
																												     22:
																												     osquery_core_tests_flagstests-test
																												       22/70
																												       Test
																												       #22:
																												       osquery_core_tests_flagstests-test
																												       ............................
																												       Passed
																												       3.18
																												       sec
																												               Start
																													       23:
																													       osquery_core_tests_systemtests-test
																													         23/70
																														 Test
																														 #23:
																														 osquery_core_tests_systemtests-test
																														 ...........................
																														 Passed
																														 3.19
																														 sec
																														         Start
																															 24:
																															 osquery_core_tests_tablestests-test
																															   24/70
																															   Test
																															   #24:
																															   osquery_core_tests_tablestests-test
																															   ...........................
																															   Passed
																															   2.97
																															   sec
																															           Start
																																   25:
																																   osquery_core_tests_watcherpermissionstests-test
																																     25/70
																																     Test
																																     #25:
																																     osquery_core_tests_watcherpermissionstests-test
																																     ...............
																																     Passed
																																     3.27
																																     sec
																																             Start
																																	     26:
																																	     osquery_core_tests_querytests-test
																																	       26/70
																																	       Test
																																	       #26:
																																	       osquery_core_tests_querytests-test
																																	       ............................
																																	       Passed
																																	       3.50
																																	       sec
																																	               Start
																																		       27:
																																		       osquery_core_tests_processtests-test
																																		         27/70
																																			 Test
																																			 #27:
																																			 osquery_core_tests_processtests-test
																																			 ..........................
																																			 Passed
																																			 4.31
																																			 sec
																																			         Start
																																				 28:
																																				 osquery_config_tests-test
																																				   28/70
																																				   Test
																																				   #28:
																																				   osquery_config_tests-test
																																				   .....................................***Failed
																																				   14.43
																																				   sec
																																				           Start
																																					   29:
																																					   osquery_config_tests_packs-test
																																					     29/70
																																					     Test
																																					     #29:
																																					     osquery_config_tests_packs-test
																																					     ...............................
																																					     Passed
																																					     2.90
																																					     sec
																																					             Start
																																						     30:
																																						     osquery_utils_utilstests-test
																																						       30/70
																																						       Test
																																						       #30:
																																						       osquery_utils_utilstests-test
																																						       .................................
																																						       Passed
																																						       2.09
																																						       sec
																																						               Start
																																							       31:
																																							       osquery_utils_aws_tests-test
																																							         31/70
																																								 Test
																																								 #31:
																																								 osquery_utils_aws_tests-test
																																								 ..................................
																																								 Passed
																																								 3.11
																																								 sec
																																								         Start
																																									 32:
																																									 osquery_utils_caches_tests_lrutests-test
																																									   32/70
																																									   Test
																																									   #32:
																																									   osquery_utils_caches_tests_lrutests-test
																																									   ......................
																																									   Passed
																																									   1.49
																																									   sec
																																									           Start
																																										   33:
																																										   osquery_utils_system_errno_errnotests-test
																																										     33/70
																																										     Test
																																										     #33:
																																										     osquery_utils_system_errno_errnotests-test
																																										     ....................
																																										     Passed
																																										     1.53
																																										     sec
																																										             Start
																																											     34:
																																											     osquery_utils_system_time_timetest-test
																																											       34/70
																																											       Test
																																											       #34:
																																											       osquery_utils_system_time_timetest-test
																																											       .......................
																																											       Passed
																																											       1.45
																																											       sec
																																											               Start
																																												       35:
																																												       osquery_utils_system_linux_proc_proctests-test
																																												         35/70
																																													 Test
																																													 #35:
																																													 osquery_utils_system_linux_proc_proctests-test
																																													 ................
																																													 Passed
																																													 0.96
																																													 sec
																																													         Start
																																														 36:
																																														 osquery_utils_status_statustests-test
																																														   36/70
																																														   Test
																																														   #36:
																																														   osquery_utils_status_statustests-test
																																														   .........................
																																														   Passed
																																														   1.50
																																														   sec
																																														           Start
																																															   37:
																																															   osquery_utils_json_jsontests-test
																																															     37/70
																																															     Test
																																															     #37:
																																															     osquery_utils_json_jsontests-test
																																															     .............................
																																															     Passed
																																															     1.71
																																															     sec
																																															             Start
																																																     38:
																																																     osquery_utils_error_errortests-test
																																																       38/70
																																																       Test
																																																       #38:
																																																       osquery_utils_error_errortests-test
																																																       ...........................
																																																       Passed
																																																       2.09
																																																       sec
																																																               Start
																																																	       39:
																																																	       osquery_utils_debug_debugtests-test
																																																	         39/70
																																																		 Test
																																																		 #39:
																																																		 osquery_utils_debug_debugtests-test
																																																		 ...........................
																																																		 Passed
																																																		 1.60
																																																		 sec
																																																		         Start
																																																			 40:
																																																			 osquery_utils_expected_expectedtests-test
																																																			   40/70
																																																			   Test
																																																			   #40:
																																																			   osquery_utils_expected_expectedtests-test
																																																			   .....................
																																																			   Passed
																																																			   1.64
																																																			   sec
																																																			           Start
																																																				   41:
																																																				   osquery_utils_conversions_windowstests-test
																																																				     41/70
																																																				     Test
																																																				     #41:
																																																				     osquery_utils_conversions_windowstests-test
																																																				     ...................
																																																				     Passed
																																																				     3.00
																																																				     sec
																																																				             Start
																																																					     42:
																																																					     osquery_utils_conversions_conversionstests-test
																																																					       42/70
																																																					       Test
																																																					       #42:
																																																					       osquery_utils_conversions_conversionstests-test
																																																					       ...............
																																																					       Passed
																																																					       1.43
																																																					       sec
																																																					               Start
																																																						       43:
																																																						       osquery_utils_conversions_totests-test
																																																						         43/70
																																																							 Test
																																																							 #43:
																																																							 osquery_utils_conversions_totests-test
																																																							 ........................
																																																							 Passed
																																																							 1.37
																																																							 sec
																																																							         Start
																																																								 44:
																																																								 osquery_utils_versioning_semanticversiontest-test
																																																								   44/70
																																																								   Test
																																																								   #44:
																																																								   osquery_utils_versioning_semanticversiontest-test
																																																								   .............
																																																								   Passed
																																																								   1.95
																																																								   sec
																																																								           Start
																																																									   45:
																																																									   osquery_utils_schemer_tests_schemertests-test
																																																									     45/70
																																																									     Test
																																																									     #45:
																																																									     osquery_utils_schemer_tests_schemertests-test
																																																									     .................
																																																									     Passed
																																																									     1.76
																																																									     sec
																																																									             Start
																																																										     46:
																																																										     osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       46/70
																																																										       Test
																																																										       #46:
																																																										       osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       ........
																																																										       Passed
																																																										       1.78
																																																										       sec
																																																										               Start
																																																											       47:
																																																											       osquery_filesystem_filesystemtests-test
																																																											         47/70
																																																												 Test
																																																												 #47:
																																																												 osquery_filesystem_filesystemtests-test
																																																												 .......................
																																																												 Passed
																																																												 3.86
																																																												 sec
																																																												         Start
																																																													 48:
																																																													 osquery_database_tests-test
																																																													   48/70
																																																													   Test
																																																													   #48:
																																																													   osquery_database_tests-test
																																																													   ...................................
																																																													   Passed
																																																													   2.79
																																																													   sec
																																																													           Start
																																																														   49:
																																																														   osquery_database_tests_results-test
																																																														     49/70
																																																														     Test
																																																														     #49:
																																																														     osquery_database_tests_results-test
																																																														     ...........................
																																																														     Passed
																																																														     3.12
																																																														     sec
																																																														             Start
																																																															     50:
																																																															     osquery_devtools_tests_printertests-test
																																																															       50/70
																																																															       Test
																																																															       #50:
																																																															       osquery_devtools_tests_printertests-test
																																																															       ......................
																																																															       Passed
																																																															       2.96
																																																															       sec
																																																															               Start
																																																																       51:
																																																																       osquery_extensions_extensiontests-test
																																																																         51/70
																																																																	 Test
																																																																	 #51:
																																																																	 osquery_extensions_extensiontests-test
																																																																	 ........................
																																																																	 Passed
																																																																	 7.42
																																																																	 sec
																																																																	         Start
																																																																		 52:
																																																																		 osquery_events_tests_eventsdatabasetests-test
																																																																		   52/70
																																																																		   Test
																																																																		   #52:
																																																																		   osquery_events_tests_eventsdatabasetests-test
																																																																		   .................
																																																																		   Passed
																																																																		   3.03
																																																																		   sec
																																																																		           Start
																																																																			   53:
																																																																			   osquery_events_tests_windowseventlogtests-test
																																																																			     53/70
																																																																			     Test
																																																																			     #53:
																																																																			     osquery_events_tests_windowseventlogtests-test
																																																																			     ................
																																																																			     Passed
																																																																			     3.00
																																																																			     sec
																																																																			             Start
																																																																				     54:
																																																																				     osquery_events_tests-test
																																																																				       54/70
																																																																				       Test
																																																																				       #54:
																																																																				       osquery_events_tests-test
																																																																				       .....................................
																																																																				       Passed
																																																																				       3.40
																																																																				       sec
																																																																				               Start
																																																																					       55:
																																																																					       osquery_ev2_ev2tests-test
																																																																					         55/70
																																																																						 Test
																																																																						 #55:
																																																																						 osquery_ev2_ev2tests-test
																																																																						 .....................................
																																																																						 Passed
																																																																						 1.62
																																																																						 sec
																																																																						         Start
																																																																							 56:
																																																																							 osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   56/70
																																																																							   Test
																																																																							   #56:
																																																																							   osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   ...
																																																																							   Passed
																																																																							   2.95
																																																																							   sec
																																																																							           Start
																																																																								   57:
																																																																								   plugins_config_parsers_tests_decoratorstests-test
																																																																								     57/70
																																																																								     Test
																																																																								     #57:
																																																																								     plugins_config_parsers_tests_decoratorstests-test
																																																																								     .............
																																																																								     Passed
																																																																								     5.43
																																																																								     sec
																																																																								             Start
																																																																									     58:
																																																																									     plugins_config_parsers_tests_eventsparsertests-test
																																																																									       58/70
																																																																									       Test
																																																																									       #58:
																																																																									       plugins_config_parsers_tests_eventsparsertests-test
																																																																									       ...........
																																																																									       Passed
																																																																									       3.82
																																																																									       sec
																																																																									               Start
																																																																										       59:
																																																																										       plugins_config_parsers_tests_filepathstests-test
																																																																										         59/70
																																																																											 Test
																																																																											 #59:
																																																																											 plugins_config_parsers_tests_filepathstests-test
																																																																											 ..............
																																																																											 Passed
																																																																											 6.13
																																																																											 sec
																																																																											         Start
																																																																												 60:
																																																																												 plugins_config_parsers_tests_optionstests-test
																																																																												   60/70
																																																																												   Test
																																																																												   #60:
																																																																												   plugins_config_parsers_tests_optionstests-test
																																																																												   ................
																																																																												   Passed
																																																																												   3.85
																																																																												   sec
																																																																												           Start
																																																																													   61:
																																																																													   plugins_config_parsers_tests_viewstests-test
																																																																													     61/70
																																																																													     Test
																																																																													     #61:
																																																																													     plugins_config_parsers_tests_viewstests-test
																																																																													     ..................
																																																																													     Passed
																																																																													     4.13
																																																																													     sec
																																																																													             Start
																																																																														     62:
																																																																														     plugins_database_tests_rocksdbtests-test
																																																																														       62/70
																																																																														       Test
																																																																														       #62:
																																																																														       plugins_database_tests_rocksdbtests-test
																																																																														       ......................
																																																																														       Passed
																																																																														       4.00
																																																																														       sec
																																																																														               Start
																																																																															       63:
																																																																															       plugins_database_tests_sqliteplugintests-test
																																																																															         63/70
																																																																																 Test
																																																																																 #63:
																																																																																 plugins_database_tests_sqliteplugintests-test
																																																																																 .................
																																																																																 Passed
																																																																																 3.56
																																																																																 sec
																																																																																         Start
																																																																																	 64:
																																																																																	 plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   64/70
																																																																																	   Test
																																																																																	   #64:
																																																																																	   plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   .......
																																																																																	   Passed
																																																																																	   3.17
																																																																																	   sec
																																																																																	           Start
																																																																																		   65:
																																																																																		   plugins_logger_tests_awskinesisloggertests-test
																																																																																		     65/70
																																																																																		     Test
																																																																																		     #65:
																																																																																		     plugins_logger_tests_awskinesisloggertests-test
																																																																																		     ...............
																																																																																		     Passed
																																																																																		     3.60
																																																																																		     sec
																																																																																		             Start
																																																																																			     66:
																																																																																			     plugins_logger_tests_bufferedloggertests-test
																																																																																			       66/70
																																																																																			       Test
																																																																																			       #66:
																																																																																			       plugins_logger_tests_bufferedloggertests-test
																																																																																			       .................
																																																																																			       Passed
																																																																																			       3.00
																																																																																			       sec
																																																																																			               Start
																																																																																				       67:
																																																																																				       plugins_logger_tests_filesystemloggertests-test
																																																																																				         67/70
																																																																																					 Test
																																																																																					 #67:
																																																																																					 plugins_logger_tests_filesystemloggertests-test
																																																																																					 ...............
																																																																																					 Passed
																																																																																					 3.20
																																																																																					 sec
																																																																																					         Start
																																																																																						 68:
																																																																																						 plugins_logger_tests_tlsloggertests-test
																																																																																						   68/70
																																																																																						   Test
																																																																																						   #68:
																																																																																						   plugins_logger_tests_tlsloggertests-test
																																																																																						   ......................
																																																																																						   Passed
																																																																																						   11.05
																																																																																						   sec
																																																																																						           Start
																																																																																							   69:
																																																																																							   plugins_numericmonitoring_tests_filesystem-test
																																																																																							     69/70
																																																																																							     Test
																																																																																							     #69:
																																																																																							     plugins_numericmonitoring_tests_filesystem-test
																																																																																							     ...............
																																																																																							     Passed
																																																																																							     3.03
																																																																																							     sec
																																																																																							             Start
																																																																																								     70:
																																																																																								     tests_integration_tables-test
																																																																																								       70/70
																																																																																								       Test
																																																																																								       #70:
																																																																																								       tests_integration_tables-test
																																																																																								       .................................
																																																																																								       Passed
																																																																																								       24.91
																																																																																								       sec

																																																																																								         99%
																																																																																									 tests
																																																																																									 passed,
																																																																																									 1
																																																																																									 tests
																																																																																									 failed
																																																																																									 out
																																																																																									 of
																																																																																									 70

																																																																																									   Total
																																																																																									   Test
																																																																																									   time
																																																																																									   (real)
																																																																																									   =
																																																																																									   258.07
																																																																																									   sec

																																																																																									     The
																																																																																									     following
																																																																																									     tests
																																																																																									     FAILED:
																																																																																									              28
																																																																																										      -
																																																																																										      osquery_config_tests-test
																																																																																										      (Failed)
																																																																																										        Errors
																																																																																											while
																																																																																											running
																																																																																											CTest
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											The
																																																																																											command
																																																																																											"setlocal
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											"C:\Program
																																																																																											Files\CMake\bin\ctest.exe"
																																																																																											--force-new-ctest-process
																																																																																											-C
																																																																																											RelWithDebInfo
																																																																																											[C:\Users\thor\work\repos\osquery\build\
																																																																																											windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											endlocal
																																																																																											&
																																																																																											call
																																																																																											:cmErrorLevel
																																																																																											%errorlevel%
																																																																																											&
																																																																																											goto
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxpr
																																																																																											oj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmErrorLevel
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											exit
																																																																																											/b
																																																																																											%1
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:VCEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:VCEnd"
																																																																																											exited
																																																																																											with
																																																																																											code
																																																																																											8.
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
```
muffins added a commit to muffins/osquery that referenced this issue Oct 19, 2019
Summary:

This adds tests for the windows and darwin conversions strings helper
classes. Darwin currently has tests, but they are not hooked up and
being run. Windows does not have tests, this adds two simple unit tests
against the logic for our string conversions.

Test Plan:

Run the tests, unsure what's up with the config tests failing, will
investigate but I think they're unrelated to this change?:
```
PS C:\Users\thor\work\repos\osquery\build\windows10> cmake --build .
--config RelWithDebInfo -j10 --target run_tests
Microsoft (R) Build Engine version 16.3.1+1def00d3d for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Test project C:/Users/thor/work/repos/osquery/build/windows10
          Start  1: osquery_dispatcher_tests-test
	     1/70 Test  #1: osquery_dispatcher_tests-test
	     .................................   Passed    3.21 sec
	             Start  2: osquery_dispatcher_tests_scheduler-test
		        2/70 Test  #2:
			osquery_dispatcher_tests_scheduler-test
			.......................   Passed    6.91 sec
			        Start  3: osquery_sql_tests-test
				   3/70 Test  #3: osquery_sql_tests-test
				   ........................................
				   Passed    2.81 sec
				           Start  4:
					   osquery_sql_tests_virtualtabletests-test
					      4/70 Test  #4:
					      osquery_sql_tests_virtualtabletests-test
					      ......................
					      Passed    3.24 sec
					              Start  5:
						      osquery_sql_tests_sqliteutilstests-test
						         5/70 Test  #5:
							 osquery_sql_tests_sqliteutilstests-test
							 .......................
							 Passed    3.39
							 sec
							         Start
								 6:
								 osquery_sdk_tests_pluginsdktests-test
								    6/70
								    Test
								    #6:
								    osquery_sdk_tests_pluginsdktests-test
								    .........................
								    Passed
								    2.84
								    sec
								            Start
									    7:
									    osquery_numericmonitoring_tests-test
									       7/70
									       Test
									       #7:
									       osquery_numericmonitoring_tests-test
									       ..........................
									       Passed
									       3.01
									       sec
									               Start
										       8:
										       osquery_numericmonitoring_tests_preaggregationcache-test
										          8/70
											  Test
											  #8:
											  osquery_numericmonitoring_tests_preaggregationcache-test
											  ......
											  Passed
											  2.90
											  sec
											          Start
												  9:
												  osquery_killswitch_tests-test
												     9/70
												     Test
												     #9:
												     osquery_killswitch_tests-test
												     .................................
												     Passed
												     2.72
												     sec
												             Start
													     10:
													     osquery_registry_tests-test
													       10/70
													       Test
													       #10:
													       osquery_registry_tests-test
													       ...................................
													       Passed
													       2.95
													       sec
													               Start
														       11:
														       osquery_logger_tests-test
														         11/70
															 Test
															 #11:
															 osquery_logger_tests-test
															 .....................................
															 Passed
															 2.91
															 sec
															         Start
																 12:
																 osquery_distributed_tests-test
																   12/70
																   Test
																   #12:
																   osquery_distributed_tests-test
																   ................................
																   Passed
																   3.02
																   sec
																           Start
																	   13:
																	   osquery_carver_tests-test
																	     13/70
																	     Test
																	     #13:
																	     osquery_carver_tests-test
																	     .....................................
																	     Passed
																	     2.88
																	     sec
																	             Start
																		     14:
																		     osquery_tables_events_tests_fileeventstests-test
																		       14/70
																		       Test
																		       #14:
																		       osquery_tables_events_tests_fileeventstests-test
																		       ..............
																		       Passed
																		       3.09
																		       sec
																		               Start
																			       15:
																			       osquery_tables_networking_tests_networkingtablestests-test
																			         15/70
																				 Test
																				 #15:
																				 osquery_tables_networking_tests_networkingtablestests-test
																				 ....
																				 Passed
																				 5.22
																				 sec
																				         Start
																					 16:
																					 osquery_tables_system_tests_certificatestests-test
																					   16/70
																					   Test
																					   #16:
																					   osquery_tables_system_tests_certificatestests-test
																					   ............
																					   Passed
																					   2.99
																					   sec
																					           Start
																						   17:
																						   osquery_tables_system_tests_registrytests-test
																						     17/70
																						     Test
																						     #17:
																						     osquery_tables_system_tests_registrytests-test
																						     ................
																						     Passed
																						     3.65
																						     sec
																						             Start
																							     18:
																							     osquery_tables_system_tests_systemtablestests-test
																							       18/70
																							       Test
																							       #18:
																							       osquery_tables_system_tests_systemtablestests-test
																							       ............
																							       Passed
																							       7.32
																							       sec
																							               Start
																								       19:
																								       osquery_remote_tests_requeststests-test
																								         19/70
																									 Test
																									 #19:
																									 osquery_remote_tests_requeststests-test
																									 .......................
																									 Passed
																									 2.37
																									 sec
																									         Start
																										 20:
																										 osquery_remote_serializers_remotejsonserializerstests-test
																										   20/70
																										   Test
																										   #20:
																										   osquery_remote_serializers_remotejsonserializerstests-test
																										   ....
																										   Passed
																										   1.59
																										   sec
																										           Start
																											   21:
																											   osquery_remote_enroll_remoteenrolltests-test
																											     21/70
																											     Test
																											     #21:
																											     osquery_remote_enroll_remoteenrolltests-test
																											     ..................
																											     Passed
																											     2.89
																											     sec
																											             Start
																												     22:
																												     osquery_core_tests_flagstests-test
																												       22/70
																												       Test
																												       #22:
																												       osquery_core_tests_flagstests-test
																												       ............................
																												       Passed
																												       3.18
																												       sec
																												               Start
																													       23:
																													       osquery_core_tests_systemtests-test
																													         23/70
																														 Test
																														 #23:
																														 osquery_core_tests_systemtests-test
																														 ...........................
																														 Passed
																														 3.19
																														 sec
																														         Start
																															 24:
																															 osquery_core_tests_tablestests-test
																															   24/70
																															   Test
																															   #24:
																															   osquery_core_tests_tablestests-test
																															   ...........................
																															   Passed
																															   2.97
																															   sec
																															           Start
																																   25:
																																   osquery_core_tests_watcherpermissionstests-test
																																     25/70
																																     Test
																																     #25:
																																     osquery_core_tests_watcherpermissionstests-test
																																     ...............
																																     Passed
																																     3.27
																																     sec
																																             Start
																																	     26:
																																	     osquery_core_tests_querytests-test
																																	       26/70
																																	       Test
																																	       #26:
																																	       osquery_core_tests_querytests-test
																																	       ............................
																																	       Passed
																																	       3.50
																																	       sec
																																	               Start
																																		       27:
																																		       osquery_core_tests_processtests-test
																																		         27/70
																																			 Test
																																			 #27:
																																			 osquery_core_tests_processtests-test
																																			 ..........................
																																			 Passed
																																			 4.31
																																			 sec
																																			         Start
																																				 28:
																																				 osquery_config_tests-test
																																				   28/70
																																				   Test
																																				   #28:
																																				   osquery_config_tests-test
																																				   .....................................***Failed
																																				   14.43
																																				   sec
																																				           Start
																																					   29:
																																					   osquery_config_tests_packs-test
																																					     29/70
																																					     Test
																																					     #29:
																																					     osquery_config_tests_packs-test
																																					     ...............................
																																					     Passed
																																					     2.90
																																					     sec
																																					             Start
																																						     30:
																																						     osquery_utils_utilstests-test
																																						       30/70
																																						       Test
																																						       #30:
																																						       osquery_utils_utilstests-test
																																						       .................................
																																						       Passed
																																						       2.09
																																						       sec
																																						               Start
																																							       31:
																																							       osquery_utils_aws_tests-test
																																							         31/70
																																								 Test
																																								 #31:
																																								 osquery_utils_aws_tests-test
																																								 ..................................
																																								 Passed
																																								 3.11
																																								 sec
																																								         Start
																																									 32:
																																									 osquery_utils_caches_tests_lrutests-test
																																									   32/70
																																									   Test
																																									   #32:
																																									   osquery_utils_caches_tests_lrutests-test
																																									   ......................
																																									   Passed
																																									   1.49
																																									   sec
																																									           Start
																																										   33:
																																										   osquery_utils_system_errno_errnotests-test
																																										     33/70
																																										     Test
																																										     #33:
																																										     osquery_utils_system_errno_errnotests-test
																																										     ....................
																																										     Passed
																																										     1.53
																																										     sec
																																										             Start
																																											     34:
																																											     osquery_utils_system_time_timetest-test
																																											       34/70
																																											       Test
																																											       #34:
																																											       osquery_utils_system_time_timetest-test
																																											       .......................
																																											       Passed
																																											       1.45
																																											       sec
																																											               Start
																																												       35:
																																												       osquery_utils_system_linux_proc_proctests-test
																																												         35/70
																																													 Test
																																													 #35:
																																													 osquery_utils_system_linux_proc_proctests-test
																																													 ................
																																													 Passed
																																													 0.96
																																													 sec
																																													         Start
																																														 36:
																																														 osquery_utils_status_statustests-test
																																														   36/70
																																														   Test
																																														   #36:
																																														   osquery_utils_status_statustests-test
																																														   .........................
																																														   Passed
																																														   1.50
																																														   sec
																																														           Start
																																															   37:
																																															   osquery_utils_json_jsontests-test
																																															     37/70
																																															     Test
																																															     #37:
																																															     osquery_utils_json_jsontests-test
																																															     .............................
																																															     Passed
																																															     1.71
																																															     sec
																																															             Start
																																																     38:
																																																     osquery_utils_error_errortests-test
																																																       38/70
																																																       Test
																																																       #38:
																																																       osquery_utils_error_errortests-test
																																																       ...........................
																																																       Passed
																																																       2.09
																																																       sec
																																																               Start
																																																	       39:
																																																	       osquery_utils_debug_debugtests-test
																																																	         39/70
																																																		 Test
																																																		 #39:
																																																		 osquery_utils_debug_debugtests-test
																																																		 ...........................
																																																		 Passed
																																																		 1.60
																																																		 sec
																																																		         Start
																																																			 40:
																																																			 osquery_utils_expected_expectedtests-test
																																																			   40/70
																																																			   Test
																																																			   #40:
																																																			   osquery_utils_expected_expectedtests-test
																																																			   .....................
																																																			   Passed
																																																			   1.64
																																																			   sec
																																																			           Start
																																																				   41:
																																																				   osquery_utils_conversions_windowstests-test
																																																				     41/70
																																																				     Test
																																																				     #41:
																																																				     osquery_utils_conversions_windowstests-test
																																																				     ...................
																																																				     Passed
																																																				     3.00
																																																				     sec
																																																				             Start
																																																					     42:
																																																					     osquery_utils_conversions_conversionstests-test
																																																					       42/70
																																																					       Test
																																																					       #42:
																																																					       osquery_utils_conversions_conversionstests-test
																																																					       ...............
																																																					       Passed
																																																					       1.43
																																																					       sec
																																																					               Start
																																																						       43:
																																																						       osquery_utils_conversions_totests-test
																																																						         43/70
																																																							 Test
																																																							 #43:
																																																							 osquery_utils_conversions_totests-test
																																																							 ........................
																																																							 Passed
																																																							 1.37
																																																							 sec
																																																							         Start
																																																								 44:
																																																								 osquery_utils_versioning_semanticversiontest-test
																																																								   44/70
																																																								   Test
																																																								   #44:
																																																								   osquery_utils_versioning_semanticversiontest-test
																																																								   .............
																																																								   Passed
																																																								   1.95
																																																								   sec
																																																								           Start
																																																									   45:
																																																									   osquery_utils_schemer_tests_schemertests-test
																																																									     45/70
																																																									     Test
																																																									     #45:
																																																									     osquery_utils_schemer_tests_schemertests-test
																																																									     .................
																																																									     Passed
																																																									     1.76
																																																									     sec
																																																									             Start
																																																										     46:
																																																										     osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       46/70
																																																										       Test
																																																										       #46:
																																																										       osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       ........
																																																										       Passed
																																																										       1.78
																																																										       sec
																																																										               Start
																																																											       47:
																																																											       osquery_filesystem_filesystemtests-test
																																																											         47/70
																																																												 Test
																																																												 #47:
																																																												 osquery_filesystem_filesystemtests-test
																																																												 .......................
																																																												 Passed
																																																												 3.86
																																																												 sec
																																																												         Start
																																																													 48:
																																																													 osquery_database_tests-test
																																																													   48/70
																																																													   Test
																																																													   #48:
																																																													   osquery_database_tests-test
																																																													   ...................................
																																																													   Passed
																																																													   2.79
																																																													   sec
																																																													           Start
																																																														   49:
																																																														   osquery_database_tests_results-test
																																																														     49/70
																																																														     Test
																																																														     #49:
																																																														     osquery_database_tests_results-test
																																																														     ...........................
																																																														     Passed
																																																														     3.12
																																																														     sec
																																																														             Start
																																																															     50:
																																																															     osquery_devtools_tests_printertests-test
																																																															       50/70
																																																															       Test
																																																															       #50:
																																																															       osquery_devtools_tests_printertests-test
																																																															       ......................
																																																															       Passed
																																																															       2.96
																																																															       sec
																																																															               Start
																																																																       51:
																																																																       osquery_extensions_extensiontests-test
																																																																         51/70
																																																																	 Test
																																																																	 #51:
																																																																	 osquery_extensions_extensiontests-test
																																																																	 ........................
																																																																	 Passed
																																																																	 7.42
																																																																	 sec
																																																																	         Start
																																																																		 52:
																																																																		 osquery_events_tests_eventsdatabasetests-test
																																																																		   52/70
																																																																		   Test
																																																																		   #52:
																																																																		   osquery_events_tests_eventsdatabasetests-test
																																																																		   .................
																																																																		   Passed
																																																																		   3.03
																																																																		   sec
																																																																		           Start
																																																																			   53:
																																																																			   osquery_events_tests_windowseventlogtests-test
																																																																			     53/70
																																																																			     Test
																																																																			     #53:
																																																																			     osquery_events_tests_windowseventlogtests-test
																																																																			     ................
																																																																			     Passed
																																																																			     3.00
																																																																			     sec
																																																																			             Start
																																																																				     54:
																																																																				     osquery_events_tests-test
																																																																				       54/70
																																																																				       Test
																																																																				       #54:
																																																																				       osquery_events_tests-test
																																																																				       .....................................
																																																																				       Passed
																																																																				       3.40
																																																																				       sec
																																																																				               Start
																																																																					       55:
																																																																					       osquery_ev2_ev2tests-test
																																																																					         55/70
																																																																						 Test
																																																																						 #55:
																																																																						 osquery_ev2_ev2tests-test
																																																																						 .....................................
																																																																						 Passed
																																																																						 1.62
																																																																						 sec
																																																																						         Start
																																																																							 56:
																																																																							 osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   56/70
																																																																							   Test
																																																																							   #56:
																																																																							   osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   ...
																																																																							   Passed
																																																																							   2.95
																																																																							   sec
																																																																							           Start
																																																																								   57:
																																																																								   plugins_config_parsers_tests_decoratorstests-test
																																																																								     57/70
																																																																								     Test
																																																																								     #57:
																																																																								     plugins_config_parsers_tests_decoratorstests-test
																																																																								     .............
																																																																								     Passed
																																																																								     5.43
																																																																								     sec
																																																																								             Start
																																																																									     58:
																																																																									     plugins_config_parsers_tests_eventsparsertests-test
																																																																									       58/70
																																																																									       Test
																																																																									       #58:
																																																																									       plugins_config_parsers_tests_eventsparsertests-test
																																																																									       ...........
																																																																									       Passed
																																																																									       3.82
																																																																									       sec
																																																																									               Start
																																																																										       59:
																																																																										       plugins_config_parsers_tests_filepathstests-test
																																																																										         59/70
																																																																											 Test
																																																																											 #59:
																																																																											 plugins_config_parsers_tests_filepathstests-test
																																																																											 ..............
																																																																											 Passed
																																																																											 6.13
																																																																											 sec
																																																																											         Start
																																																																												 60:
																																																																												 plugins_config_parsers_tests_optionstests-test
																																																																												   60/70
																																																																												   Test
																																																																												   #60:
																																																																												   plugins_config_parsers_tests_optionstests-test
																																																																												   ................
																																																																												   Passed
																																																																												   3.85
																																																																												   sec
																																																																												           Start
																																																																													   61:
																																																																													   plugins_config_parsers_tests_viewstests-test
																																																																													     61/70
																																																																													     Test
																																																																													     #61:
																																																																													     plugins_config_parsers_tests_viewstests-test
																																																																													     ..................
																																																																													     Passed
																																																																													     4.13
																																																																													     sec
																																																																													             Start
																																																																														     62:
																																																																														     plugins_database_tests_rocksdbtests-test
																																																																														       62/70
																																																																														       Test
																																																																														       #62:
																																																																														       plugins_database_tests_rocksdbtests-test
																																																																														       ......................
																																																																														       Passed
																																																																														       4.00
																																																																														       sec
																																																																														               Start
																																																																															       63:
																																																																															       plugins_database_tests_sqliteplugintests-test
																																																																															         63/70
																																																																																 Test
																																																																																 #63:
																																																																																 plugins_database_tests_sqliteplugintests-test
																																																																																 .................
																																																																																 Passed
																																																																																 3.56
																																																																																 sec
																																																																																         Start
																																																																																	 64:
																																																																																	 plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   64/70
																																																																																	   Test
																																																																																	   #64:
																																																																																	   plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   .......
																																																																																	   Passed
																																																																																	   3.17
																																																																																	   sec
																																																																																	           Start
																																																																																		   65:
																																																																																		   plugins_logger_tests_awskinesisloggertests-test
																																																																																		     65/70
																																																																																		     Test
																																																																																		     #65:
																																																																																		     plugins_logger_tests_awskinesisloggertests-test
																																																																																		     ...............
																																																																																		     Passed
																																																																																		     3.60
																																																																																		     sec
																																																																																		             Start
																																																																																			     66:
																																																																																			     plugins_logger_tests_bufferedloggertests-test
																																																																																			       66/70
																																																																																			       Test
																																																																																			       #66:
																																																																																			       plugins_logger_tests_bufferedloggertests-test
																																																																																			       .................
																																																																																			       Passed
																																																																																			       3.00
																																																																																			       sec
																																																																																			               Start
																																																																																				       67:
																																																																																				       plugins_logger_tests_filesystemloggertests-test
																																																																																				         67/70
																																																																																					 Test
																																																																																					 #67:
																																																																																					 plugins_logger_tests_filesystemloggertests-test
																																																																																					 ...............
																																																																																					 Passed
																																																																																					 3.20
																																																																																					 sec
																																																																																					         Start
																																																																																						 68:
																																																																																						 plugins_logger_tests_tlsloggertests-test
																																																																																						   68/70
																																																																																						   Test
																																																																																						   #68:
																																																																																						   plugins_logger_tests_tlsloggertests-test
																																																																																						   ......................
																																																																																						   Passed
																																																																																						   11.05
																																																																																						   sec
																																																																																						           Start
																																																																																							   69:
																																																																																							   plugins_numericmonitoring_tests_filesystem-test
																																																																																							     69/70
																																																																																							     Test
																																																																																							     #69:
																																																																																							     plugins_numericmonitoring_tests_filesystem-test
																																																																																							     ...............
																																																																																							     Passed
																																																																																							     3.03
																																																																																							     sec
																																																																																							             Start
																																																																																								     70:
																																																																																								     tests_integration_tables-test
																																																																																								       70/70
																																																																																								       Test
																																																																																								       #70:
																																																																																								       tests_integration_tables-test
																																																																																								       .................................
																																																																																								       Passed
																																																																																								       24.91
																																																																																								       sec

																																																																																								         99%
																																																																																									 tests
																																																																																									 passed,
																																																																																									 1
																																																																																									 tests
																																																																																									 failed
																																																																																									 out
																																																																																									 of
																																																																																									 70

																																																																																									   Total
																																																																																									   Test
																																																																																									   time
																																																																																									   (real)
																																																																																									   =
																																																																																									   258.07
																																																																																									   sec

																																																																																									     The
																																																																																									     following
																																																																																									     tests
																																																																																									     FAILED:
																																																																																									              28
																																																																																										      -
																																																																																										      osquery_config_tests-test
																																																																																										      (Failed)
																																																																																										        Errors
																																																																																											while
																																																																																											running
																																																																																											CTest
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											The
																																																																																											command
																																																																																											"setlocal
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											"C:\Program
																																																																																											Files\CMake\bin\ctest.exe"
																																																																																											--force-new-ctest-process
																																																																																											-C
																																																																																											RelWithDebInfo
																																																																																											[C:\Users\thor\work\repos\osquery\build\
																																																																																											windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											endlocal
																																																																																											&
																																																																																											call
																																																																																											:cmErrorLevel
																																																																																											%errorlevel%
																																																																																											&
																																																																																											goto
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxpr
																																																																																											oj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmErrorLevel
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											exit
																																																																																											/b
																																																																																											%1
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:VCEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:VCEnd"
																																																																																											exited
																																																																																											with
																																																																																											code
																																																																																											8.
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
```
muffins added a commit to muffins/osquery that referenced this issue Oct 20, 2019
Summary:

This adds tests for the windows and darwin conversions strings helper
classes. Darwin currently has tests, but they are not hooked up and
being run. Windows does not have tests, this adds two simple unit tests
against the logic for our string conversions.

Test Plan:

Run the tests, unsure what's up with the config tests failing, will
investigate but I think they're unrelated to this change?:
```
PS C:\Users\thor\work\repos\osquery\build\windows10> cmake --build .
--config RelWithDebInfo -j10 --target run_tests
Microsoft (R) Build Engine version 16.3.1+1def00d3d for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Test project C:/Users/thor/work/repos/osquery/build/windows10
          Start  1: osquery_dispatcher_tests-test
	     1/70 Test  #1: osquery_dispatcher_tests-test
	     .................................   Passed    3.21 sec
	             Start  2: osquery_dispatcher_tests_scheduler-test
		        2/70 Test  #2:
			osquery_dispatcher_tests_scheduler-test
			.......................   Passed    6.91 sec
			        Start  3: osquery_sql_tests-test
				   3/70 Test  #3: osquery_sql_tests-test
				   ........................................
				   Passed    2.81 sec
				           Start  4:
					   osquery_sql_tests_virtualtabletests-test
					      4/70 Test  #4:
					      osquery_sql_tests_virtualtabletests-test
					      ......................
					      Passed    3.24 sec
					              Start  5:
						      osquery_sql_tests_sqliteutilstests-test
						         5/70 Test  #5:
							 osquery_sql_tests_sqliteutilstests-test
							 .......................
							 Passed    3.39
							 sec
							         Start
								 6:
								 osquery_sdk_tests_pluginsdktests-test
								    6/70
								    Test
								    #6:
								    osquery_sdk_tests_pluginsdktests-test
								    .........................
								    Passed
								    2.84
								    sec
								            Start
									    7:
									    osquery_numericmonitoring_tests-test
									       7/70
									       Test
									       #7:
									       osquery_numericmonitoring_tests-test
									       ..........................
									       Passed
									       3.01
									       sec
									               Start
										       8:
										       osquery_numericmonitoring_tests_preaggregationcache-test
										          8/70
											  Test
											  #8:
											  osquery_numericmonitoring_tests_preaggregationcache-test
											  ......
											  Passed
											  2.90
											  sec
											          Start
												  9:
												  osquery_killswitch_tests-test
												     9/70
												     Test
												     #9:
												     osquery_killswitch_tests-test
												     .................................
												     Passed
												     2.72
												     sec
												             Start
													     10:
													     osquery_registry_tests-test
													       10/70
													       Test
													       #10:
													       osquery_registry_tests-test
													       ...................................
													       Passed
													       2.95
													       sec
													               Start
														       11:
														       osquery_logger_tests-test
														         11/70
															 Test
															 #11:
															 osquery_logger_tests-test
															 .....................................
															 Passed
															 2.91
															 sec
															         Start
																 12:
																 osquery_distributed_tests-test
																   12/70
																   Test
																   #12:
																   osquery_distributed_tests-test
																   ................................
																   Passed
																   3.02
																   sec
																           Start
																	   13:
																	   osquery_carver_tests-test
																	     13/70
																	     Test
																	     #13:
																	     osquery_carver_tests-test
																	     .....................................
																	     Passed
																	     2.88
																	     sec
																	             Start
																		     14:
																		     osquery_tables_events_tests_fileeventstests-test
																		       14/70
																		       Test
																		       #14:
																		       osquery_tables_events_tests_fileeventstests-test
																		       ..............
																		       Passed
																		       3.09
																		       sec
																		               Start
																			       15:
																			       osquery_tables_networking_tests_networkingtablestests-test
																			         15/70
																				 Test
																				 #15:
																				 osquery_tables_networking_tests_networkingtablestests-test
																				 ....
																				 Passed
																				 5.22
																				 sec
																				         Start
																					 16:
																					 osquery_tables_system_tests_certificatestests-test
																					   16/70
																					   Test
																					   #16:
																					   osquery_tables_system_tests_certificatestests-test
																					   ............
																					   Passed
																					   2.99
																					   sec
																					           Start
																						   17:
																						   osquery_tables_system_tests_registrytests-test
																						     17/70
																						     Test
																						     #17:
																						     osquery_tables_system_tests_registrytests-test
																						     ................
																						     Passed
																						     3.65
																						     sec
																						             Start
																							     18:
																							     osquery_tables_system_tests_systemtablestests-test
																							       18/70
																							       Test
																							       #18:
																							       osquery_tables_system_tests_systemtablestests-test
																							       ............
																							       Passed
																							       7.32
																							       sec
																							               Start
																								       19:
																								       osquery_remote_tests_requeststests-test
																								         19/70
																									 Test
																									 #19:
																									 osquery_remote_tests_requeststests-test
																									 .......................
																									 Passed
																									 2.37
																									 sec
																									         Start
																										 20:
																										 osquery_remote_serializers_remotejsonserializerstests-test
																										   20/70
																										   Test
																										   #20:
																										   osquery_remote_serializers_remotejsonserializerstests-test
																										   ....
																										   Passed
																										   1.59
																										   sec
																										           Start
																											   21:
																											   osquery_remote_enroll_remoteenrolltests-test
																											     21/70
																											     Test
																											     #21:
																											     osquery_remote_enroll_remoteenrolltests-test
																											     ..................
																											     Passed
																											     2.89
																											     sec
																											             Start
																												     22:
																												     osquery_core_tests_flagstests-test
																												       22/70
																												       Test
																												       #22:
																												       osquery_core_tests_flagstests-test
																												       ............................
																												       Passed
																												       3.18
																												       sec
																												               Start
																													       23:
																													       osquery_core_tests_systemtests-test
																													         23/70
																														 Test
																														 #23:
																														 osquery_core_tests_systemtests-test
																														 ...........................
																														 Passed
																														 3.19
																														 sec
																														         Start
																															 24:
																															 osquery_core_tests_tablestests-test
																															   24/70
																															   Test
																															   #24:
																															   osquery_core_tests_tablestests-test
																															   ...........................
																															   Passed
																															   2.97
																															   sec
																															           Start
																																   25:
																																   osquery_core_tests_watcherpermissionstests-test
																																     25/70
																																     Test
																																     #25:
																																     osquery_core_tests_watcherpermissionstests-test
																																     ...............
																																     Passed
																																     3.27
																																     sec
																																             Start
																																	     26:
																																	     osquery_core_tests_querytests-test
																																	       26/70
																																	       Test
																																	       #26:
																																	       osquery_core_tests_querytests-test
																																	       ............................
																																	       Passed
																																	       3.50
																																	       sec
																																	               Start
																																		       27:
																																		       osquery_core_tests_processtests-test
																																		         27/70
																																			 Test
																																			 #27:
																																			 osquery_core_tests_processtests-test
																																			 ..........................
																																			 Passed
																																			 4.31
																																			 sec
																																			         Start
																																				 28:
																																				 osquery_config_tests-test
																																				   28/70
																																				   Test
																																				   #28:
																																				   osquery_config_tests-test
																																				   .....................................***Failed
																																				   14.43
																																				   sec
																																				           Start
																																					   29:
																																					   osquery_config_tests_packs-test
																																					     29/70
																																					     Test
																																					     #29:
																																					     osquery_config_tests_packs-test
																																					     ...............................
																																					     Passed
																																					     2.90
																																					     sec
																																					             Start
																																						     30:
																																						     osquery_utils_utilstests-test
																																						       30/70
																																						       Test
																																						       #30:
																																						       osquery_utils_utilstests-test
																																						       .................................
																																						       Passed
																																						       2.09
																																						       sec
																																						               Start
																																							       31:
																																							       osquery_utils_aws_tests-test
																																							         31/70
																																								 Test
																																								 #31:
																																								 osquery_utils_aws_tests-test
																																								 ..................................
																																								 Passed
																																								 3.11
																																								 sec
																																								         Start
																																									 32:
																																									 osquery_utils_caches_tests_lrutests-test
																																									   32/70
																																									   Test
																																									   #32:
																																									   osquery_utils_caches_tests_lrutests-test
																																									   ......................
																																									   Passed
																																									   1.49
																																									   sec
																																									           Start
																																										   33:
																																										   osquery_utils_system_errno_errnotests-test
																																										     33/70
																																										     Test
																																										     #33:
																																										     osquery_utils_system_errno_errnotests-test
																																										     ....................
																																										     Passed
																																										     1.53
																																										     sec
																																										             Start
																																											     34:
																																											     osquery_utils_system_time_timetest-test
																																											       34/70
																																											       Test
																																											       #34:
																																											       osquery_utils_system_time_timetest-test
																																											       .......................
																																											       Passed
																																											       1.45
																																											       sec
																																											               Start
																																												       35:
																																												       osquery_utils_system_linux_proc_proctests-test
																																												         35/70
																																													 Test
																																													 #35:
																																													 osquery_utils_system_linux_proc_proctests-test
																																													 ................
																																													 Passed
																																													 0.96
																																													 sec
																																													         Start
																																														 36:
																																														 osquery_utils_status_statustests-test
																																														   36/70
																																														   Test
																																														   #36:
																																														   osquery_utils_status_statustests-test
																																														   .........................
																																														   Passed
																																														   1.50
																																														   sec
																																														           Start
																																															   37:
																																															   osquery_utils_json_jsontests-test
																																															     37/70
																																															     Test
																																															     #37:
																																															     osquery_utils_json_jsontests-test
																																															     .............................
																																															     Passed
																																															     1.71
																																															     sec
																																															             Start
																																																     38:
																																																     osquery_utils_error_errortests-test
																																																       38/70
																																																       Test
																																																       #38:
																																																       osquery_utils_error_errortests-test
																																																       ...........................
																																																       Passed
																																																       2.09
																																																       sec
																																																               Start
																																																	       39:
																																																	       osquery_utils_debug_debugtests-test
																																																	         39/70
																																																		 Test
																																																		 #39:
																																																		 osquery_utils_debug_debugtests-test
																																																		 ...........................
																																																		 Passed
																																																		 1.60
																																																		 sec
																																																		         Start
																																																			 40:
																																																			 osquery_utils_expected_expectedtests-test
																																																			   40/70
																																																			   Test
																																																			   #40:
																																																			   osquery_utils_expected_expectedtests-test
																																																			   .....................
																																																			   Passed
																																																			   1.64
																																																			   sec
																																																			           Start
																																																				   41:
																																																				   osquery_utils_conversions_windowstests-test
																																																				     41/70
																																																				     Test
																																																				     #41:
																																																				     osquery_utils_conversions_windowstests-test
																																																				     ...................
																																																				     Passed
																																																				     3.00
																																																				     sec
																																																				             Start
																																																					     42:
																																																					     osquery_utils_conversions_conversionstests-test
																																																					       42/70
																																																					       Test
																																																					       #42:
																																																					       osquery_utils_conversions_conversionstests-test
																																																					       ...............
																																																					       Passed
																																																					       1.43
																																																					       sec
																																																					               Start
																																																						       43:
																																																						       osquery_utils_conversions_totests-test
																																																						         43/70
																																																							 Test
																																																							 #43:
																																																							 osquery_utils_conversions_totests-test
																																																							 ........................
																																																							 Passed
																																																							 1.37
																																																							 sec
																																																							         Start
																																																								 44:
																																																								 osquery_utils_versioning_semanticversiontest-test
																																																								   44/70
																																																								   Test
																																																								   #44:
																																																								   osquery_utils_versioning_semanticversiontest-test
																																																								   .............
																																																								   Passed
																																																								   1.95
																																																								   sec
																																																								           Start
																																																									   45:
																																																									   osquery_utils_schemer_tests_schemertests-test
																																																									     45/70
																																																									     Test
																																																									     #45:
																																																									     osquery_utils_schemer_tests_schemertests-test
																																																									     .................
																																																									     Passed
																																																									     1.76
																																																									     sec
																																																									             Start
																																																										     46:
																																																										     osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       46/70
																																																										       Test
																																																										       #46:
																																																										       osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       ........
																																																										       Passed
																																																										       1.78
																																																										       sec
																																																										               Start
																																																											       47:
																																																											       osquery_filesystem_filesystemtests-test
																																																											         47/70
																																																												 Test
																																																												 #47:
																																																												 osquery_filesystem_filesystemtests-test
																																																												 .......................
																																																												 Passed
																																																												 3.86
																																																												 sec
																																																												         Start
																																																													 48:
																																																													 osquery_database_tests-test
																																																													   48/70
																																																													   Test
																																																													   #48:
																																																													   osquery_database_tests-test
																																																													   ...................................
																																																													   Passed
																																																													   2.79
																																																													   sec
																																																													           Start
																																																														   49:
																																																														   osquery_database_tests_results-test
																																																														     49/70
																																																														     Test
																																																														     #49:
																																																														     osquery_database_tests_results-test
																																																														     ...........................
																																																														     Passed
																																																														     3.12
																																																														     sec
																																																														             Start
																																																															     50:
																																																															     osquery_devtools_tests_printertests-test
																																																															       50/70
																																																															       Test
																																																															       #50:
																																																															       osquery_devtools_tests_printertests-test
																																																															       ......................
																																																															       Passed
																																																															       2.96
																																																															       sec
																																																															               Start
																																																																       51:
																																																																       osquery_extensions_extensiontests-test
																																																																         51/70
																																																																	 Test
																																																																	 #51:
																																																																	 osquery_extensions_extensiontests-test
																																																																	 ........................
																																																																	 Passed
																																																																	 7.42
																																																																	 sec
																																																																	         Start
																																																																		 52:
																																																																		 osquery_events_tests_eventsdatabasetests-test
																																																																		   52/70
																																																																		   Test
																																																																		   #52:
																																																																		   osquery_events_tests_eventsdatabasetests-test
																																																																		   .................
																																																																		   Passed
																																																																		   3.03
																																																																		   sec
																																																																		           Start
																																																																			   53:
																																																																			   osquery_events_tests_windowseventlogtests-test
																																																																			     53/70
																																																																			     Test
																																																																			     #53:
																																																																			     osquery_events_tests_windowseventlogtests-test
																																																																			     ................
																																																																			     Passed
																																																																			     3.00
																																																																			     sec
																																																																			             Start
																																																																				     54:
																																																																				     osquery_events_tests-test
																																																																				       54/70
																																																																				       Test
																																																																				       #54:
																																																																				       osquery_events_tests-test
																																																																				       .....................................
																																																																				       Passed
																																																																				       3.40
																																																																				       sec
																																																																				               Start
																																																																					       55:
																																																																					       osquery_ev2_ev2tests-test
																																																																					         55/70
																																																																						 Test
																																																																						 #55:
																																																																						 osquery_ev2_ev2tests-test
																																																																						 .....................................
																																																																						 Passed
																																																																						 1.62
																																																																						 sec
																																																																						         Start
																																																																							 56:
																																																																							 osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   56/70
																																																																							   Test
																																																																							   #56:
																																																																							   osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   ...
																																																																							   Passed
																																																																							   2.95
																																																																							   sec
																																																																							           Start
																																																																								   57:
																																																																								   plugins_config_parsers_tests_decoratorstests-test
																																																																								     57/70
																																																																								     Test
																																																																								     #57:
																																																																								     plugins_config_parsers_tests_decoratorstests-test
																																																																								     .............
																																																																								     Passed
																																																																								     5.43
																																																																								     sec
																																																																								             Start
																																																																									     58:
																																																																									     plugins_config_parsers_tests_eventsparsertests-test
																																																																									       58/70
																																																																									       Test
																																																																									       #58:
																																																																									       plugins_config_parsers_tests_eventsparsertests-test
																																																																									       ...........
																																																																									       Passed
																																																																									       3.82
																																																																									       sec
																																																																									               Start
																																																																										       59:
																																																																										       plugins_config_parsers_tests_filepathstests-test
																																																																										         59/70
																																																																											 Test
																																																																											 #59:
																																																																											 plugins_config_parsers_tests_filepathstests-test
																																																																											 ..............
																																																																											 Passed
																																																																											 6.13
																																																																											 sec
																																																																											         Start
																																																																												 60:
																																																																												 plugins_config_parsers_tests_optionstests-test
																																																																												   60/70
																																																																												   Test
																																																																												   #60:
																																																																												   plugins_config_parsers_tests_optionstests-test
																																																																												   ................
																																																																												   Passed
																																																																												   3.85
																																																																												   sec
																																																																												           Start
																																																																													   61:
																																																																													   plugins_config_parsers_tests_viewstests-test
																																																																													     61/70
																																																																													     Test
																																																																													     #61:
																																																																													     plugins_config_parsers_tests_viewstests-test
																																																																													     ..................
																																																																													     Passed
																																																																													     4.13
																																																																													     sec
																																																																													             Start
																																																																														     62:
																																																																														     plugins_database_tests_rocksdbtests-test
																																																																														       62/70
																																																																														       Test
																																																																														       #62:
																																																																														       plugins_database_tests_rocksdbtests-test
																																																																														       ......................
																																																																														       Passed
																																																																														       4.00
																																																																														       sec
																																																																														               Start
																																																																															       63:
																																																																															       plugins_database_tests_sqliteplugintests-test
																																																																															         63/70
																																																																																 Test
																																																																																 #63:
																																																																																 plugins_database_tests_sqliteplugintests-test
																																																																																 .................
																																																																																 Passed
																																																																																 3.56
																																																																																 sec
																																																																																         Start
																																																																																	 64:
																																																																																	 plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   64/70
																																																																																	   Test
																																																																																	   #64:
																																																																																	   plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   .......
																																																																																	   Passed
																																																																																	   3.17
																																																																																	   sec
																																																																																	           Start
																																																																																		   65:
																																																																																		   plugins_logger_tests_awskinesisloggertests-test
																																																																																		     65/70
																																																																																		     Test
																																																																																		     #65:
																																																																																		     plugins_logger_tests_awskinesisloggertests-test
																																																																																		     ...............
																																																																																		     Passed
																																																																																		     3.60
																																																																																		     sec
																																																																																		             Start
																																																																																			     66:
																																																																																			     plugins_logger_tests_bufferedloggertests-test
																																																																																			       66/70
																																																																																			       Test
																																																																																			       #66:
																																																																																			       plugins_logger_tests_bufferedloggertests-test
																																																																																			       .................
																																																																																			       Passed
																																																																																			       3.00
																																																																																			       sec
																																																																																			               Start
																																																																																				       67:
																																																																																				       plugins_logger_tests_filesystemloggertests-test
																																																																																				         67/70
																																																																																					 Test
																																																																																					 #67:
																																																																																					 plugins_logger_tests_filesystemloggertests-test
																																																																																					 ...............
																																																																																					 Passed
																																																																																					 3.20
																																																																																					 sec
																																																																																					         Start
																																																																																						 68:
																																																																																						 plugins_logger_tests_tlsloggertests-test
																																																																																						   68/70
																																																																																						   Test
																																																																																						   #68:
																																																																																						   plugins_logger_tests_tlsloggertests-test
																																																																																						   ......................
																																																																																						   Passed
																																																																																						   11.05
																																																																																						   sec
																																																																																						           Start
																																																																																							   69:
																																																																																							   plugins_numericmonitoring_tests_filesystem-test
																																																																																							     69/70
																																																																																							     Test
																																																																																							     #69:
																																																																																							     plugins_numericmonitoring_tests_filesystem-test
																																																																																							     ...............
																																																																																							     Passed
																																																																																							     3.03
																																																																																							     sec
																																																																																							             Start
																																																																																								     70:
																																																																																								     tests_integration_tables-test
																																																																																								       70/70
																																																																																								       Test
																																																																																								       #70:
																																																																																								       tests_integration_tables-test
																																																																																								       .................................
																																																																																								       Passed
																																																																																								       24.91
																																																																																								       sec

																																																																																								         99%
																																																																																									 tests
																																																																																									 passed,
																																																																																									 1
																																																																																									 tests
																																																																																									 failed
																																																																																									 out
																																																																																									 of
																																																																																									 70

																																																																																									   Total
																																																																																									   Test
																																																																																									   time
																																																																																									   (real)
																																																																																									   =
																																																																																									   258.07
																																																																																									   sec

																																																																																									     The
																																																																																									     following
																																																																																									     tests
																																																																																									     FAILED:
																																																																																									              28
																																																																																										      -
																																																																																										      osquery_config_tests-test
																																																																																										      (Failed)
																																																																																										        Errors
																																																																																											while
																																																																																											running
																																																																																											CTest
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											The
																																																																																											command
																																																																																											"setlocal
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											"C:\Program
																																																																																											Files\CMake\bin\ctest.exe"
																																																																																											--force-new-ctest-process
																																																																																											-C
																																																																																											RelWithDebInfo
																																																																																											[C:\Users\thor\work\repos\osquery\build\
																																																																																											windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											endlocal
																																																																																											&
																																																																																											call
																																																																																											:cmErrorLevel
																																																																																											%errorlevel%
																																																																																											&
																																																																																											goto
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxpr
																																																																																											oj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmErrorLevel
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											exit
																																																																																											/b
																																																																																											%1
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:VCEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:VCEnd"
																																																																																											exited
																																																																																											with
																																																																																											code
																																																																																											8.
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
```
muffins added a commit to muffins/osquery that referenced this issue Oct 27, 2019
Summary:

This adds tests for the windows and darwin conversions strings helper
classes. Darwin currently has tests, but they are not hooked up and
being run. Windows does not have tests, this adds two simple unit tests
against the logic for our string conversions.

Test Plan:

Run the tests, unsure what's up with the config tests failing, will
investigate but I think they're unrelated to this change?:
```
PS C:\Users\thor\work\repos\osquery\build\windows10> cmake --build .
--config RelWithDebInfo -j10 --target run_tests
Microsoft (R) Build Engine version 16.3.1+1def00d3d for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Test project C:/Users/thor/work/repos/osquery/build/windows10
          Start  1: osquery_dispatcher_tests-test
	     1/70 Test  #1: osquery_dispatcher_tests-test
	     .................................   Passed    3.21 sec
	             Start  2: osquery_dispatcher_tests_scheduler-test
		        2/70 Test  #2:
			osquery_dispatcher_tests_scheduler-test
			.......................   Passed    6.91 sec
			        Start  3: osquery_sql_tests-test
				   3/70 Test  #3: osquery_sql_tests-test
				   ........................................
				   Passed    2.81 sec
				           Start  4:
					   osquery_sql_tests_virtualtabletests-test
					      4/70 Test  #4:
					      osquery_sql_tests_virtualtabletests-test
					      ......................
					      Passed    3.24 sec
					              Start  5:
						      osquery_sql_tests_sqliteutilstests-test
						         5/70 Test  #5:
							 osquery_sql_tests_sqliteutilstests-test
							 .......................
							 Passed    3.39
							 sec
							         Start
								 6:
								 osquery_sdk_tests_pluginsdktests-test
								    6/70
								    Test
								    #6:
								    osquery_sdk_tests_pluginsdktests-test
								    .........................
								    Passed
								    2.84
								    sec
								            Start
									    7:
									    osquery_numericmonitoring_tests-test
									       7/70
									       Test
									       #7:
									       osquery_numericmonitoring_tests-test
									       ..........................
									       Passed
									       3.01
									       sec
									               Start
										       8:
										       osquery_numericmonitoring_tests_preaggregationcache-test
										          8/70
											  Test
											  #8:
											  osquery_numericmonitoring_tests_preaggregationcache-test
											  ......
											  Passed
											  2.90
											  sec
											          Start
												  9:
												  osquery_killswitch_tests-test
												     9/70
												     Test
												     #9:
												     osquery_killswitch_tests-test
												     .................................
												     Passed
												     2.72
												     sec
												             Start
													     10:
													     osquery_registry_tests-test
													       10/70
													       Test
													       #10:
													       osquery_registry_tests-test
													       ...................................
													       Passed
													       2.95
													       sec
													               Start
														       11:
														       osquery_logger_tests-test
														         11/70
															 Test
															 #11:
															 osquery_logger_tests-test
															 .....................................
															 Passed
															 2.91
															 sec
															         Start
																 12:
																 osquery_distributed_tests-test
																   12/70
																   Test
																   #12:
																   osquery_distributed_tests-test
																   ................................
																   Passed
																   3.02
																   sec
																           Start
																	   13:
																	   osquery_carver_tests-test
																	     13/70
																	     Test
																	     #13:
																	     osquery_carver_tests-test
																	     .....................................
																	     Passed
																	     2.88
																	     sec
																	             Start
																		     14:
																		     osquery_tables_events_tests_fileeventstests-test
																		       14/70
																		       Test
																		       #14:
																		       osquery_tables_events_tests_fileeventstests-test
																		       ..............
																		       Passed
																		       3.09
																		       sec
																		               Start
																			       15:
																			       osquery_tables_networking_tests_networkingtablestests-test
																			         15/70
																				 Test
																				 #15:
																				 osquery_tables_networking_tests_networkingtablestests-test
																				 ....
																				 Passed
																				 5.22
																				 sec
																				         Start
																					 16:
																					 osquery_tables_system_tests_certificatestests-test
																					   16/70
																					   Test
																					   #16:
																					   osquery_tables_system_tests_certificatestests-test
																					   ............
																					   Passed
																					   2.99
																					   sec
																					           Start
																						   17:
																						   osquery_tables_system_tests_registrytests-test
																						     17/70
																						     Test
																						     #17:
																						     osquery_tables_system_tests_registrytests-test
																						     ................
																						     Passed
																						     3.65
																						     sec
																						             Start
																							     18:
																							     osquery_tables_system_tests_systemtablestests-test
																							       18/70
																							       Test
																							       #18:
																							       osquery_tables_system_tests_systemtablestests-test
																							       ............
																							       Passed
																							       7.32
																							       sec
																							               Start
																								       19:
																								       osquery_remote_tests_requeststests-test
																								         19/70
																									 Test
																									 #19:
																									 osquery_remote_tests_requeststests-test
																									 .......................
																									 Passed
																									 2.37
																									 sec
																									         Start
																										 20:
																										 osquery_remote_serializers_remotejsonserializerstests-test
																										   20/70
																										   Test
																										   #20:
																										   osquery_remote_serializers_remotejsonserializerstests-test
																										   ....
																										   Passed
																										   1.59
																										   sec
																										           Start
																											   21:
																											   osquery_remote_enroll_remoteenrolltests-test
																											     21/70
																											     Test
																											     #21:
																											     osquery_remote_enroll_remoteenrolltests-test
																											     ..................
																											     Passed
																											     2.89
																											     sec
																											             Start
																												     22:
																												     osquery_core_tests_flagstests-test
																												       22/70
																												       Test
																												       #22:
																												       osquery_core_tests_flagstests-test
																												       ............................
																												       Passed
																												       3.18
																												       sec
																												               Start
																													       23:
																													       osquery_core_tests_systemtests-test
																													         23/70
																														 Test
																														 #23:
																														 osquery_core_tests_systemtests-test
																														 ...........................
																														 Passed
																														 3.19
																														 sec
																														         Start
																															 24:
																															 osquery_core_tests_tablestests-test
																															   24/70
																															   Test
																															   #24:
																															   osquery_core_tests_tablestests-test
																															   ...........................
																															   Passed
																															   2.97
																															   sec
																															           Start
																																   25:
																																   osquery_core_tests_watcherpermissionstests-test
																																     25/70
																																     Test
																																     #25:
																																     osquery_core_tests_watcherpermissionstests-test
																																     ...............
																																     Passed
																																     3.27
																																     sec
																																             Start
																																	     26:
																																	     osquery_core_tests_querytests-test
																																	       26/70
																																	       Test
																																	       #26:
																																	       osquery_core_tests_querytests-test
																																	       ............................
																																	       Passed
																																	       3.50
																																	       sec
																																	               Start
																																		       27:
																																		       osquery_core_tests_processtests-test
																																		         27/70
																																			 Test
																																			 #27:
																																			 osquery_core_tests_processtests-test
																																			 ..........................
																																			 Passed
																																			 4.31
																																			 sec
																																			         Start
																																				 28:
																																				 osquery_config_tests-test
																																				   28/70
																																				   Test
																																				   #28:
																																				   osquery_config_tests-test
																																				   .....................................***Failed
																																				   14.43
																																				   sec
																																				           Start
																																					   29:
																																					   osquery_config_tests_packs-test
																																					     29/70
																																					     Test
																																					     #29:
																																					     osquery_config_tests_packs-test
																																					     ...............................
																																					     Passed
																																					     2.90
																																					     sec
																																					             Start
																																						     30:
																																						     osquery_utils_utilstests-test
																																						       30/70
																																						       Test
																																						       #30:
																																						       osquery_utils_utilstests-test
																																						       .................................
																																						       Passed
																																						       2.09
																																						       sec
																																						               Start
																																							       31:
																																							       osquery_utils_aws_tests-test
																																							         31/70
																																								 Test
																																								 #31:
																																								 osquery_utils_aws_tests-test
																																								 ..................................
																																								 Passed
																																								 3.11
																																								 sec
																																								         Start
																																									 32:
																																									 osquery_utils_caches_tests_lrutests-test
																																									   32/70
																																									   Test
																																									   #32:
																																									   osquery_utils_caches_tests_lrutests-test
																																									   ......................
																																									   Passed
																																									   1.49
																																									   sec
																																									           Start
																																										   33:
																																										   osquery_utils_system_errno_errnotests-test
																																										     33/70
																																										     Test
																																										     #33:
																																										     osquery_utils_system_errno_errnotests-test
																																										     ....................
																																										     Passed
																																										     1.53
																																										     sec
																																										             Start
																																											     34:
																																											     osquery_utils_system_time_timetest-test
																																											       34/70
																																											       Test
																																											       #34:
																																											       osquery_utils_system_time_timetest-test
																																											       .......................
																																											       Passed
																																											       1.45
																																											       sec
																																											               Start
																																												       35:
																																												       osquery_utils_system_linux_proc_proctests-test
																																												         35/70
																																													 Test
																																													 #35:
																																													 osquery_utils_system_linux_proc_proctests-test
																																													 ................
																																													 Passed
																																													 0.96
																																													 sec
																																													         Start
																																														 36:
																																														 osquery_utils_status_statustests-test
																																														   36/70
																																														   Test
																																														   #36:
																																														   osquery_utils_status_statustests-test
																																														   .........................
																																														   Passed
																																														   1.50
																																														   sec
																																														           Start
																																															   37:
																																															   osquery_utils_json_jsontests-test
																																															     37/70
																																															     Test
																																															     #37:
																																															     osquery_utils_json_jsontests-test
																																															     .............................
																																															     Passed
																																															     1.71
																																															     sec
																																															             Start
																																																     38:
																																																     osquery_utils_error_errortests-test
																																																       38/70
																																																       Test
																																																       #38:
																																																       osquery_utils_error_errortests-test
																																																       ...........................
																																																       Passed
																																																       2.09
																																																       sec
																																																               Start
																																																	       39:
																																																	       osquery_utils_debug_debugtests-test
																																																	         39/70
																																																		 Test
																																																		 #39:
																																																		 osquery_utils_debug_debugtests-test
																																																		 ...........................
																																																		 Passed
																																																		 1.60
																																																		 sec
																																																		         Start
																																																			 40:
																																																			 osquery_utils_expected_expectedtests-test
																																																			   40/70
																																																			   Test
																																																			   #40:
																																																			   osquery_utils_expected_expectedtests-test
																																																			   .....................
																																																			   Passed
																																																			   1.64
																																																			   sec
																																																			           Start
																																																				   41:
																																																				   osquery_utils_conversions_windowstests-test
																																																				     41/70
																																																				     Test
																																																				     #41:
																																																				     osquery_utils_conversions_windowstests-test
																																																				     ...................
																																																				     Passed
																																																				     3.00
																																																				     sec
																																																				             Start
																																																					     42:
																																																					     osquery_utils_conversions_conversionstests-test
																																																					       42/70
																																																					       Test
																																																					       #42:
																																																					       osquery_utils_conversions_conversionstests-test
																																																					       ...............
																																																					       Passed
																																																					       1.43
																																																					       sec
																																																					               Start
																																																						       43:
																																																						       osquery_utils_conversions_totests-test
																																																						         43/70
																																																							 Test
																																																							 #43:
																																																							 osquery_utils_conversions_totests-test
																																																							 ........................
																																																							 Passed
																																																							 1.37
																																																							 sec
																																																							         Start
																																																								 44:
																																																								 osquery_utils_versioning_semanticversiontest-test
																																																								   44/70
																																																								   Test
																																																								   #44:
																																																								   osquery_utils_versioning_semanticversiontest-test
																																																								   .............
																																																								   Passed
																																																								   1.95
																																																								   sec
																																																								           Start
																																																									   45:
																																																									   osquery_utils_schemer_tests_schemertests-test
																																																									     45/70
																																																									     Test
																																																									     #45:
																																																									     osquery_utils_schemer_tests_schemertests-test
																																																									     .................
																																																									     Passed
																																																									     1.76
																																																									     sec
																																																									             Start
																																																										     46:
																																																										     osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       46/70
																																																										       Test
																																																										       #46:
																																																										       osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       ........
																																																										       Passed
																																																										       1.78
																																																										       sec
																																																										               Start
																																																											       47:
																																																											       osquery_filesystem_filesystemtests-test
																																																											         47/70
																																																												 Test
																																																												 #47:
																																																												 osquery_filesystem_filesystemtests-test
																																																												 .......................
																																																												 Passed
																																																												 3.86
																																																												 sec
																																																												         Start
																																																													 48:
																																																													 osquery_database_tests-test
																																																													   48/70
																																																													   Test
																																																													   #48:
																																																													   osquery_database_tests-test
																																																													   ...................................
																																																													   Passed
																																																													   2.79
																																																													   sec
																																																													           Start
																																																														   49:
																																																														   osquery_database_tests_results-test
																																																														     49/70
																																																														     Test
																																																														     #49:
																																																														     osquery_database_tests_results-test
																																																														     ...........................
																																																														     Passed
																																																														     3.12
																																																														     sec
																																																														             Start
																																																															     50:
																																																															     osquery_devtools_tests_printertests-test
																																																															       50/70
																																																															       Test
																																																															       #50:
																																																															       osquery_devtools_tests_printertests-test
																																																															       ......................
																																																															       Passed
																																																															       2.96
																																																															       sec
																																																															               Start
																																																																       51:
																																																																       osquery_extensions_extensiontests-test
																																																																         51/70
																																																																	 Test
																																																																	 #51:
																																																																	 osquery_extensions_extensiontests-test
																																																																	 ........................
																																																																	 Passed
																																																																	 7.42
																																																																	 sec
																																																																	         Start
																																																																		 52:
																																																																		 osquery_events_tests_eventsdatabasetests-test
																																																																		   52/70
																																																																		   Test
																																																																		   #52:
																																																																		   osquery_events_tests_eventsdatabasetests-test
																																																																		   .................
																																																																		   Passed
																																																																		   3.03
																																																																		   sec
																																																																		           Start
																																																																			   53:
																																																																			   osquery_events_tests_windowseventlogtests-test
																																																																			     53/70
																																																																			     Test
																																																																			     #53:
																																																																			     osquery_events_tests_windowseventlogtests-test
																																																																			     ................
																																																																			     Passed
																																																																			     3.00
																																																																			     sec
																																																																			             Start
																																																																				     54:
																																																																				     osquery_events_tests-test
																																																																				       54/70
																																																																				       Test
																																																																				       #54:
																																																																				       osquery_events_tests-test
																																																																				       .....................................
																																																																				       Passed
																																																																				       3.40
																																																																				       sec
																																																																				               Start
																																																																					       55:
																																																																					       osquery_ev2_ev2tests-test
																																																																					         55/70
																																																																						 Test
																																																																						 #55:
																																																																						 osquery_ev2_ev2tests-test
																																																																						 .....................................
																																																																						 Passed
																																																																						 1.62
																																																																						 sec
																																																																						         Start
																																																																							 56:
																																																																							 osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   56/70
																																																																							   Test
																																																																							   #56:
																																																																							   osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   ...
																																																																							   Passed
																																																																							   2.95
																																																																							   sec
																																																																							           Start
																																																																								   57:
																																																																								   plugins_config_parsers_tests_decoratorstests-test
																																																																								     57/70
																																																																								     Test
																																																																								     #57:
																																																																								     plugins_config_parsers_tests_decoratorstests-test
																																																																								     .............
																																																																								     Passed
																																																																								     5.43
																																																																								     sec
																																																																								             Start
																																																																									     58:
																																																																									     plugins_config_parsers_tests_eventsparsertests-test
																																																																									       58/70
																																																																									       Test
																																																																									       #58:
																																																																									       plugins_config_parsers_tests_eventsparsertests-test
																																																																									       ...........
																																																																									       Passed
																																																																									       3.82
																																																																									       sec
																																																																									               Start
																																																																										       59:
																																																																										       plugins_config_parsers_tests_filepathstests-test
																																																																										         59/70
																																																																											 Test
																																																																											 #59:
																																																																											 plugins_config_parsers_tests_filepathstests-test
																																																																											 ..............
																																																																											 Passed
																																																																											 6.13
																																																																											 sec
																																																																											         Start
																																																																												 60:
																																																																												 plugins_config_parsers_tests_optionstests-test
																																																																												   60/70
																																																																												   Test
																																																																												   #60:
																																																																												   plugins_config_parsers_tests_optionstests-test
																																																																												   ................
																																																																												   Passed
																																																																												   3.85
																																																																												   sec
																																																																												           Start
																																																																													   61:
																																																																													   plugins_config_parsers_tests_viewstests-test
																																																																													     61/70
																																																																													     Test
																																																																													     #61:
																																																																													     plugins_config_parsers_tests_viewstests-test
																																																																													     ..................
																																																																													     Passed
																																																																													     4.13
																																																																													     sec
																																																																													             Start
																																																																														     62:
																																																																														     plugins_database_tests_rocksdbtests-test
																																																																														       62/70
																																																																														       Test
																																																																														       #62:
																																																																														       plugins_database_tests_rocksdbtests-test
																																																																														       ......................
																																																																														       Passed
																																																																														       4.00
																																																																														       sec
																																																																														               Start
																																																																															       63:
																																																																															       plugins_database_tests_sqliteplugintests-test
																																																																															         63/70
																																																																																 Test
																																																																																 #63:
																																																																																 plugins_database_tests_sqliteplugintests-test
																																																																																 .................
																																																																																 Passed
																																																																																 3.56
																																																																																 sec
																																																																																         Start
																																																																																	 64:
																																																																																	 plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   64/70
																																																																																	   Test
																																																																																	   #64:
																																																																																	   plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   .......
																																																																																	   Passed
																																																																																	   3.17
																																																																																	   sec
																																																																																	           Start
																																																																																		   65:
																																																																																		   plugins_logger_tests_awskinesisloggertests-test
																																																																																		     65/70
																																																																																		     Test
																																																																																		     #65:
																																																																																		     plugins_logger_tests_awskinesisloggertests-test
																																																																																		     ...............
																																																																																		     Passed
																																																																																		     3.60
																																																																																		     sec
																																																																																		             Start
																																																																																			     66:
																																																																																			     plugins_logger_tests_bufferedloggertests-test
																																																																																			       66/70
																																																																																			       Test
																																																																																			       #66:
																																																																																			       plugins_logger_tests_bufferedloggertests-test
																																																																																			       .................
																																																																																			       Passed
																																																																																			       3.00
																																																																																			       sec
																																																																																			               Start
																																																																																				       67:
																																																																																				       plugins_logger_tests_filesystemloggertests-test
																																																																																				         67/70
																																																																																					 Test
																																																																																					 #67:
																																																																																					 plugins_logger_tests_filesystemloggertests-test
																																																																																					 ...............
																																																																																					 Passed
																																																																																					 3.20
																																																																																					 sec
																																																																																					         Start
																																																																																						 68:
																																																																																						 plugins_logger_tests_tlsloggertests-test
																																																																																						   68/70
																																																																																						   Test
																																																																																						   #68:
																																																																																						   plugins_logger_tests_tlsloggertests-test
																																																																																						   ......................
																																																																																						   Passed
																																																																																						   11.05
																																																																																						   sec
																																																																																						           Start
																																																																																							   69:
																																																																																							   plugins_numericmonitoring_tests_filesystem-test
																																																																																							     69/70
																																																																																							     Test
																																																																																							     #69:
																																																																																							     plugins_numericmonitoring_tests_filesystem-test
																																																																																							     ...............
																																																																																							     Passed
																																																																																							     3.03
																																																																																							     sec
																																																																																							             Start
																																																																																								     70:
																																																																																								     tests_integration_tables-test
																																																																																								       70/70
																																																																																								       Test
																																																																																								       #70:
																																																																																								       tests_integration_tables-test
																																																																																								       .................................
																																																																																								       Passed
																																																																																								       24.91
																																																																																								       sec

																																																																																								         99%
																																																																																									 tests
																																																																																									 passed,
																																																																																									 1
																																																																																									 tests
																																																																																									 failed
																																																																																									 out
																																																																																									 of
																																																																																									 70

																																																																																									   Total
																																																																																									   Test
																																																																																									   time
																																																																																									   (real)
																																																																																									   =
																																																																																									   258.07
																																																																																									   sec

																																																																																									     The
																																																																																									     following
																																																																																									     tests
																																																																																									     FAILED:
																																																																																									              28
																																																																																										      -
																																																																																										      osquery_config_tests-test
																																																																																										      (Failed)
																																																																																										        Errors
																																																																																											while
																																																																																											running
																																																																																											CTest
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											The
																																																																																											command
																																																																																											"setlocal
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											"C:\Program
																																																																																											Files\CMake\bin\ctest.exe"
																																																																																											--force-new-ctest-process
																																																																																											-C
																																																																																											RelWithDebInfo
																																																																																											[C:\Users\thor\work\repos\osquery\build\
																																																																																											windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											endlocal
																																																																																											&
																																																																																											call
																																																																																											:cmErrorLevel
																																																																																											%errorlevel%
																																																																																											&
																																																																																											goto
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxpr
																																																																																											oj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmErrorLevel
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											exit
																																																																																											/b
																																																																																											%1
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:VCEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:VCEnd"
																																																																																											exited
																																																																																											with
																																																																																											code
																																																																																											8.
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
```
muffins added a commit to muffins/osquery that referenced this issue Oct 28, 2019
Summary:

This adds tests for the windows and darwin conversions strings helper
classes. Darwin currently has tests, but they are not hooked up and
being run. Windows does not have tests, this adds two simple unit tests
against the logic for our string conversions.

Test Plan:

Run the tests, unsure what's up with the config tests failing, will
investigate but I think they're unrelated to this change?:
```
PS C:\Users\thor\work\repos\osquery\build\windows10> cmake --build .
--config RelWithDebInfo -j10 --target run_tests
Microsoft (R) Build Engine version 16.3.1+1def00d3d for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Test project C:/Users/thor/work/repos/osquery/build/windows10
          Start  1: osquery_dispatcher_tests-test
	     1/70 Test  #1: osquery_dispatcher_tests-test
	     .................................   Passed    3.21 sec
	             Start  2: osquery_dispatcher_tests_scheduler-test
		        2/70 Test  #2:
			osquery_dispatcher_tests_scheduler-test
			.......................   Passed    6.91 sec
			        Start  3: osquery_sql_tests-test
				   3/70 Test  #3: osquery_sql_tests-test
				   ........................................
				   Passed    2.81 sec
				           Start  4:
					   osquery_sql_tests_virtualtabletests-test
					      4/70 Test  #4:
					      osquery_sql_tests_virtualtabletests-test
					      ......................
					      Passed    3.24 sec
					              Start  5:
						      osquery_sql_tests_sqliteutilstests-test
						         5/70 Test  #5:
							 osquery_sql_tests_sqliteutilstests-test
							 .......................
							 Passed    3.39
							 sec
							         Start
								 6:
								 osquery_sdk_tests_pluginsdktests-test
								    6/70
								    Test
								    #6:
								    osquery_sdk_tests_pluginsdktests-test
								    .........................
								    Passed
								    2.84
								    sec
								            Start
									    7:
									    osquery_numericmonitoring_tests-test
									       7/70
									       Test
									       #7:
									       osquery_numericmonitoring_tests-test
									       ..........................
									       Passed
									       3.01
									       sec
									               Start
										       8:
										       osquery_numericmonitoring_tests_preaggregationcache-test
										          8/70
											  Test
											  #8:
											  osquery_numericmonitoring_tests_preaggregationcache-test
											  ......
											  Passed
											  2.90
											  sec
											          Start
												  9:
												  osquery_killswitch_tests-test
												     9/70
												     Test
												     #9:
												     osquery_killswitch_tests-test
												     .................................
												     Passed
												     2.72
												     sec
												             Start
													     10:
													     osquery_registry_tests-test
													       10/70
													       Test
													       #10:
													       osquery_registry_tests-test
													       ...................................
													       Passed
													       2.95
													       sec
													               Start
														       11:
														       osquery_logger_tests-test
														         11/70
															 Test
															 #11:
															 osquery_logger_tests-test
															 .....................................
															 Passed
															 2.91
															 sec
															         Start
																 12:
																 osquery_distributed_tests-test
																   12/70
																   Test
																   #12:
																   osquery_distributed_tests-test
																   ................................
																   Passed
																   3.02
																   sec
																           Start
																	   13:
																	   osquery_carver_tests-test
																	     13/70
																	     Test
																	     #13:
																	     osquery_carver_tests-test
																	     .....................................
																	     Passed
																	     2.88
																	     sec
																	             Start
																		     14:
																		     osquery_tables_events_tests_fileeventstests-test
																		       14/70
																		       Test
																		       #14:
																		       osquery_tables_events_tests_fileeventstests-test
																		       ..............
																		       Passed
																		       3.09
																		       sec
																		               Start
																			       15:
																			       osquery_tables_networking_tests_networkingtablestests-test
																			         15/70
																				 Test
																				 #15:
																				 osquery_tables_networking_tests_networkingtablestests-test
																				 ....
																				 Passed
																				 5.22
																				 sec
																				         Start
																					 16:
																					 osquery_tables_system_tests_certificatestests-test
																					   16/70
																					   Test
																					   #16:
																					   osquery_tables_system_tests_certificatestests-test
																					   ............
																					   Passed
																					   2.99
																					   sec
																					           Start
																						   17:
																						   osquery_tables_system_tests_registrytests-test
																						     17/70
																						     Test
																						     #17:
																						     osquery_tables_system_tests_registrytests-test
																						     ................
																						     Passed
																						     3.65
																						     sec
																						             Start
																							     18:
																							     osquery_tables_system_tests_systemtablestests-test
																							       18/70
																							       Test
																							       #18:
																							       osquery_tables_system_tests_systemtablestests-test
																							       ............
																							       Passed
																							       7.32
																							       sec
																							               Start
																								       19:
																								       osquery_remote_tests_requeststests-test
																								         19/70
																									 Test
																									 #19:
																									 osquery_remote_tests_requeststests-test
																									 .......................
																									 Passed
																									 2.37
																									 sec
																									         Start
																										 20:
																										 osquery_remote_serializers_remotejsonserializerstests-test
																										   20/70
																										   Test
																										   #20:
																										   osquery_remote_serializers_remotejsonserializerstests-test
																										   ....
																										   Passed
																										   1.59
																										   sec
																										           Start
																											   21:
																											   osquery_remote_enroll_remoteenrolltests-test
																											     21/70
																											     Test
																											     #21:
																											     osquery_remote_enroll_remoteenrolltests-test
																											     ..................
																											     Passed
																											     2.89
																											     sec
																											             Start
																												     22:
																												     osquery_core_tests_flagstests-test
																												       22/70
																												       Test
																												       #22:
																												       osquery_core_tests_flagstests-test
																												       ............................
																												       Passed
																												       3.18
																												       sec
																												               Start
																													       23:
																													       osquery_core_tests_systemtests-test
																													         23/70
																														 Test
																														 #23:
																														 osquery_core_tests_systemtests-test
																														 ...........................
																														 Passed
																														 3.19
																														 sec
																														         Start
																															 24:
																															 osquery_core_tests_tablestests-test
																															   24/70
																															   Test
																															   #24:
																															   osquery_core_tests_tablestests-test
																															   ...........................
																															   Passed
																															   2.97
																															   sec
																															           Start
																																   25:
																																   osquery_core_tests_watcherpermissionstests-test
																																     25/70
																																     Test
																																     #25:
																																     osquery_core_tests_watcherpermissionstests-test
																																     ...............
																																     Passed
																																     3.27
																																     sec
																																             Start
																																	     26:
																																	     osquery_core_tests_querytests-test
																																	       26/70
																																	       Test
																																	       #26:
																																	       osquery_core_tests_querytests-test
																																	       ............................
																																	       Passed
																																	       3.50
																																	       sec
																																	               Start
																																		       27:
																																		       osquery_core_tests_processtests-test
																																		         27/70
																																			 Test
																																			 #27:
																																			 osquery_core_tests_processtests-test
																																			 ..........................
																																			 Passed
																																			 4.31
																																			 sec
																																			         Start
																																				 28:
																																				 osquery_config_tests-test
																																				   28/70
																																				   Test
																																				   #28:
																																				   osquery_config_tests-test
																																				   .....................................***Failed
																																				   14.43
																																				   sec
																																				           Start
																																					   29:
																																					   osquery_config_tests_packs-test
																																					     29/70
																																					     Test
																																					     #29:
																																					     osquery_config_tests_packs-test
																																					     ...............................
																																					     Passed
																																					     2.90
																																					     sec
																																					             Start
																																						     30:
																																						     osquery_utils_utilstests-test
																																						       30/70
																																						       Test
																																						       #30:
																																						       osquery_utils_utilstests-test
																																						       .................................
																																						       Passed
																																						       2.09
																																						       sec
																																						               Start
																																							       31:
																																							       osquery_utils_aws_tests-test
																																							         31/70
																																								 Test
																																								 #31:
																																								 osquery_utils_aws_tests-test
																																								 ..................................
																																								 Passed
																																								 3.11
																																								 sec
																																								         Start
																																									 32:
																																									 osquery_utils_caches_tests_lrutests-test
																																									   32/70
																																									   Test
																																									   #32:
																																									   osquery_utils_caches_tests_lrutests-test
																																									   ......................
																																									   Passed
																																									   1.49
																																									   sec
																																									           Start
																																										   33:
																																										   osquery_utils_system_errno_errnotests-test
																																										     33/70
																																										     Test
																																										     #33:
																																										     osquery_utils_system_errno_errnotests-test
																																										     ....................
																																										     Passed
																																										     1.53
																																										     sec
																																										             Start
																																											     34:
																																											     osquery_utils_system_time_timetest-test
																																											       34/70
																																											       Test
																																											       #34:
																																											       osquery_utils_system_time_timetest-test
																																											       .......................
																																											       Passed
																																											       1.45
																																											       sec
																																											               Start
																																												       35:
																																												       osquery_utils_system_linux_proc_proctests-test
																																												         35/70
																																													 Test
																																													 #35:
																																													 osquery_utils_system_linux_proc_proctests-test
																																													 ................
																																													 Passed
																																													 0.96
																																													 sec
																																													         Start
																																														 36:
																																														 osquery_utils_status_statustests-test
																																														   36/70
																																														   Test
																																														   #36:
																																														   osquery_utils_status_statustests-test
																																														   .........................
																																														   Passed
																																														   1.50
																																														   sec
																																														           Start
																																															   37:
																																															   osquery_utils_json_jsontests-test
																																															     37/70
																																															     Test
																																															     #37:
																																															     osquery_utils_json_jsontests-test
																																															     .............................
																																															     Passed
																																															     1.71
																																															     sec
																																															             Start
																																																     38:
																																																     osquery_utils_error_errortests-test
																																																       38/70
																																																       Test
																																																       #38:
																																																       osquery_utils_error_errortests-test
																																																       ...........................
																																																       Passed
																																																       2.09
																																																       sec
																																																               Start
																																																	       39:
																																																	       osquery_utils_debug_debugtests-test
																																																	         39/70
																																																		 Test
																																																		 #39:
																																																		 osquery_utils_debug_debugtests-test
																																																		 ...........................
																																																		 Passed
																																																		 1.60
																																																		 sec
																																																		         Start
																																																			 40:
																																																			 osquery_utils_expected_expectedtests-test
																																																			   40/70
																																																			   Test
																																																			   #40:
																																																			   osquery_utils_expected_expectedtests-test
																																																			   .....................
																																																			   Passed
																																																			   1.64
																																																			   sec
																																																			           Start
																																																				   41:
																																																				   osquery_utils_conversions_windowstests-test
																																																				     41/70
																																																				     Test
																																																				     #41:
																																																				     osquery_utils_conversions_windowstests-test
																																																				     ...................
																																																				     Passed
																																																				     3.00
																																																				     sec
																																																				             Start
																																																					     42:
																																																					     osquery_utils_conversions_conversionstests-test
																																																					       42/70
																																																					       Test
																																																					       #42:
																																																					       osquery_utils_conversions_conversionstests-test
																																																					       ...............
																																																					       Passed
																																																					       1.43
																																																					       sec
																																																					               Start
																																																						       43:
																																																						       osquery_utils_conversions_totests-test
																																																						         43/70
																																																							 Test
																																																							 #43:
																																																							 osquery_utils_conversions_totests-test
																																																							 ........................
																																																							 Passed
																																																							 1.37
																																																							 sec
																																																							         Start
																																																								 44:
																																																								 osquery_utils_versioning_semanticversiontest-test
																																																								   44/70
																																																								   Test
																																																								   #44:
																																																								   osquery_utils_versioning_semanticversiontest-test
																																																								   .............
																																																								   Passed
																																																								   1.95
																																																								   sec
																																																								           Start
																																																									   45:
																																																									   osquery_utils_schemer_tests_schemertests-test
																																																									     45/70
																																																									     Test
																																																									     #45:
																																																									     osquery_utils_schemer_tests_schemertests-test
																																																									     .................
																																																									     Passed
																																																									     1.76
																																																									     sec
																																																									             Start
																																																										     46:
																																																										     osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       46/70
																																																										       Test
																																																										       #46:
																																																										       osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       ........
																																																										       Passed
																																																										       1.78
																																																										       sec
																																																										               Start
																																																											       47:
																																																											       osquery_filesystem_filesystemtests-test
																																																											         47/70
																																																												 Test
																																																												 #47:
																																																												 osquery_filesystem_filesystemtests-test
																																																												 .......................
																																																												 Passed
																																																												 3.86
																																																												 sec
																																																												         Start
																																																													 48:
																																																													 osquery_database_tests-test
																																																													   48/70
																																																													   Test
																																																													   #48:
																																																													   osquery_database_tests-test
																																																													   ...................................
																																																													   Passed
																																																													   2.79
																																																													   sec
																																																													           Start
																																																														   49:
																																																														   osquery_database_tests_results-test
																																																														     49/70
																																																														     Test
																																																														     #49:
																																																														     osquery_database_tests_results-test
																																																														     ...........................
																																																														     Passed
																																																														     3.12
																																																														     sec
																																																														             Start
																																																															     50:
																																																															     osquery_devtools_tests_printertests-test
																																																															       50/70
																																																															       Test
																																																															       #50:
																																																															       osquery_devtools_tests_printertests-test
																																																															       ......................
																																																															       Passed
																																																															       2.96
																																																															       sec
																																																															               Start
																																																																       51:
																																																																       osquery_extensions_extensiontests-test
																																																																         51/70
																																																																	 Test
																																																																	 #51:
																																																																	 osquery_extensions_extensiontests-test
																																																																	 ........................
																																																																	 Passed
																																																																	 7.42
																																																																	 sec
																																																																	         Start
																																																																		 52:
																																																																		 osquery_events_tests_eventsdatabasetests-test
																																																																		   52/70
																																																																		   Test
																																																																		   #52:
																																																																		   osquery_events_tests_eventsdatabasetests-test
																																																																		   .................
																																																																		   Passed
																																																																		   3.03
																																																																		   sec
																																																																		           Start
																																																																			   53:
																																																																			   osquery_events_tests_windowseventlogtests-test
																																																																			     53/70
																																																																			     Test
																																																																			     #53:
																																																																			     osquery_events_tests_windowseventlogtests-test
																																																																			     ................
																																																																			     Passed
																																																																			     3.00
																																																																			     sec
																																																																			             Start
																																																																				     54:
																																																																				     osquery_events_tests-test
																																																																				       54/70
																																																																				       Test
																																																																				       #54:
																																																																				       osquery_events_tests-test
																																																																				       .....................................
																																																																				       Passed
																																																																				       3.40
																																																																				       sec
																																																																				               Start
																																																																					       55:
																																																																					       osquery_ev2_ev2tests-test
																																																																					         55/70
																																																																						 Test
																																																																						 #55:
																																																																						 osquery_ev2_ev2tests-test
																																																																						 .....................................
																																																																						 Passed
																																																																						 1.62
																																																																						 sec
																																																																						         Start
																																																																							 56:
																																																																							 osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   56/70
																																																																							   Test
																																																																							   #56:
																																																																							   osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   ...
																																																																							   Passed
																																																																							   2.95
																																																																							   sec
																																																																							           Start
																																																																								   57:
																																																																								   plugins_config_parsers_tests_decoratorstests-test
																																																																								     57/70
																																																																								     Test
																																																																								     #57:
																																																																								     plugins_config_parsers_tests_decoratorstests-test
																																																																								     .............
																																																																								     Passed
																																																																								     5.43
																																																																								     sec
																																																																								             Start
																																																																									     58:
																																																																									     plugins_config_parsers_tests_eventsparsertests-test
																																																																									       58/70
																																																																									       Test
																																																																									       #58:
																																																																									       plugins_config_parsers_tests_eventsparsertests-test
																																																																									       ...........
																																																																									       Passed
																																																																									       3.82
																																																																									       sec
																																																																									               Start
																																																																										       59:
																																																																										       plugins_config_parsers_tests_filepathstests-test
																																																																										         59/70
																																																																											 Test
																																																																											 #59:
																																																																											 plugins_config_parsers_tests_filepathstests-test
																																																																											 ..............
																																																																											 Passed
																																																																											 6.13
																																																																											 sec
																																																																											         Start
																																																																												 60:
																																																																												 plugins_config_parsers_tests_optionstests-test
																																																																												   60/70
																																																																												   Test
																																																																												   #60:
																																																																												   plugins_config_parsers_tests_optionstests-test
																																																																												   ................
																																																																												   Passed
																																																																												   3.85
																																																																												   sec
																																																																												           Start
																																																																													   61:
																																																																													   plugins_config_parsers_tests_viewstests-test
																																																																													     61/70
																																																																													     Test
																																																																													     #61:
																																																																													     plugins_config_parsers_tests_viewstests-test
																																																																													     ..................
																																																																													     Passed
																																																																													     4.13
																																																																													     sec
																																																																													             Start
																																																																														     62:
																																																																														     plugins_database_tests_rocksdbtests-test
																																																																														       62/70
																																																																														       Test
																																																																														       #62:
																																																																														       plugins_database_tests_rocksdbtests-test
																																																																														       ......................
																																																																														       Passed
																																																																														       4.00
																																																																														       sec
																																																																														               Start
																																																																															       63:
																																																																															       plugins_database_tests_sqliteplugintests-test
																																																																															         63/70
																																																																																 Test
																																																																																 #63:
																																																																																 plugins_database_tests_sqliteplugintests-test
																																																																																 .................
																																																																																 Passed
																																																																																 3.56
																																																																																 sec
																																																																																         Start
																																																																																	 64:
																																																																																	 plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   64/70
																																																																																	   Test
																																																																																	   #64:
																																																																																	   plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   .......
																																																																																	   Passed
																																																																																	   3.17
																																																																																	   sec
																																																																																	           Start
																																																																																		   65:
																																																																																		   plugins_logger_tests_awskinesisloggertests-test
																																																																																		     65/70
																																																																																		     Test
																																																																																		     #65:
																																																																																		     plugins_logger_tests_awskinesisloggertests-test
																																																																																		     ...............
																																																																																		     Passed
																																																																																		     3.60
																																																																																		     sec
																																																																																		             Start
																																																																																			     66:
																																																																																			     plugins_logger_tests_bufferedloggertests-test
																																																																																			       66/70
																																																																																			       Test
																																																																																			       #66:
																																																																																			       plugins_logger_tests_bufferedloggertests-test
																																																																																			       .................
																																																																																			       Passed
																																																																																			       3.00
																																																																																			       sec
																																																																																			               Start
																																																																																				       67:
																																																																																				       plugins_logger_tests_filesystemloggertests-test
																																																																																				         67/70
																																																																																					 Test
																																																																																					 #67:
																																																																																					 plugins_logger_tests_filesystemloggertests-test
																																																																																					 ...............
																																																																																					 Passed
																																																																																					 3.20
																																																																																					 sec
																																																																																					         Start
																																																																																						 68:
																																																																																						 plugins_logger_tests_tlsloggertests-test
																																																																																						   68/70
																																																																																						   Test
																																																																																						   #68:
																																																																																						   plugins_logger_tests_tlsloggertests-test
																																																																																						   ......................
																																																																																						   Passed
																																																																																						   11.05
																																																																																						   sec
																																																																																						           Start
																																																																																							   69:
																																																																																							   plugins_numericmonitoring_tests_filesystem-test
																																																																																							     69/70
																																																																																							     Test
																																																																																							     #69:
																																																																																							     plugins_numericmonitoring_tests_filesystem-test
																																																																																							     ...............
																																																																																							     Passed
																																																																																							     3.03
																																																																																							     sec
																																																																																							             Start
																																																																																								     70:
																																																																																								     tests_integration_tables-test
																																																																																								       70/70
																																																																																								       Test
																																																																																								       #70:
																																																																																								       tests_integration_tables-test
																																																																																								       .................................
																																																																																								       Passed
																																																																																								       24.91
																																																																																								       sec

																																																																																								         99%
																																																																																									 tests
																																																																																									 passed,
																																																																																									 1
																																																																																									 tests
																																																																																									 failed
																																																																																									 out
																																																																																									 of
																																																																																									 70

																																																																																									   Total
																																																																																									   Test
																																																																																									   time
																																																																																									   (real)
																																																																																									   =
																																																																																									   258.07
																																																																																									   sec

																																																																																									     The
																																																																																									     following
																																																																																									     tests
																																																																																									     FAILED:
																																																																																									              28
																																																																																										      -
																																																																																										      osquery_config_tests-test
																																																																																										      (Failed)
																																																																																										        Errors
																																																																																											while
																																																																																											running
																																																																																											CTest
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											The
																																																																																											command
																																																																																											"setlocal
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											"C:\Program
																																																																																											Files\CMake\bin\ctest.exe"
																																																																																											--force-new-ctest-process
																																																																																											-C
																																																																																											RelWithDebInfo
																																																																																											[C:\Users\thor\work\repos\osquery\build\
																																																																																											windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											endlocal
																																																																																											&
																																																																																											call
																																																																																											:cmErrorLevel
																																																																																											%errorlevel%
																																																																																											&
																																																																																											goto
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxpr
																																																																																											oj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmErrorLevel
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											exit
																																																																																											/b
																																																																																											%1
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:VCEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:VCEnd"
																																																																																											exited
																																																																																											with
																																																																																											code
																																																																																											8.
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
```
muffins added a commit to muffins/osquery that referenced this issue Oct 29, 2019
Summary:

This adds tests for the windows and darwin conversions strings helper
classes. Darwin currently has tests, but they are not hooked up and
being run. Windows does not have tests, this adds two simple unit tests
against the logic for our string conversions.

Test Plan:

Run the tests, unsure what's up with the config tests failing, will
investigate but I think they're unrelated to this change?:
```
PS C:\Users\thor\work\repos\osquery\build\windows10> cmake --build .
--config RelWithDebInfo -j10 --target run_tests
Microsoft (R) Build Engine version 16.3.1+1def00d3d for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

  Test project C:/Users/thor/work/repos/osquery/build/windows10
          Start  1: osquery_dispatcher_tests-test
	     1/70 Test  #1: osquery_dispatcher_tests-test
	     .................................   Passed    3.21 sec
	             Start  2: osquery_dispatcher_tests_scheduler-test
		        2/70 Test  #2:
			osquery_dispatcher_tests_scheduler-test
			.......................   Passed    6.91 sec
			        Start  3: osquery_sql_tests-test
				   3/70 Test  #3: osquery_sql_tests-test
				   ........................................
				   Passed    2.81 sec
				           Start  4:
					   osquery_sql_tests_virtualtabletests-test
					      4/70 Test  #4:
					      osquery_sql_tests_virtualtabletests-test
					      ......................
					      Passed    3.24 sec
					              Start  5:
						      osquery_sql_tests_sqliteutilstests-test
						         5/70 Test  #5:
							 osquery_sql_tests_sqliteutilstests-test
							 .......................
							 Passed    3.39
							 sec
							         Start
								 6:
								 osquery_sdk_tests_pluginsdktests-test
								    6/70
								    Test
								    #6:
								    osquery_sdk_tests_pluginsdktests-test
								    .........................
								    Passed
								    2.84
								    sec
								            Start
									    7:
									    osquery_numericmonitoring_tests-test
									       7/70
									       Test
									       #7:
									       osquery_numericmonitoring_tests-test
									       ..........................
									       Passed
									       3.01
									       sec
									               Start
										       8:
										       osquery_numericmonitoring_tests_preaggregationcache-test
										          8/70
											  Test
											  #8:
											  osquery_numericmonitoring_tests_preaggregationcache-test
											  ......
											  Passed
											  2.90
											  sec
											          Start
												  9:
												  osquery_killswitch_tests-test
												     9/70
												     Test
												     #9:
												     osquery_killswitch_tests-test
												     .................................
												     Passed
												     2.72
												     sec
												             Start
													     10:
													     osquery_registry_tests-test
													       10/70
													       Test
													       #10:
													       osquery_registry_tests-test
													       ...................................
													       Passed
													       2.95
													       sec
													               Start
														       11:
														       osquery_logger_tests-test
														         11/70
															 Test
															 #11:
															 osquery_logger_tests-test
															 .....................................
															 Passed
															 2.91
															 sec
															         Start
																 12:
																 osquery_distributed_tests-test
																   12/70
																   Test
																   #12:
																   osquery_distributed_tests-test
																   ................................
																   Passed
																   3.02
																   sec
																           Start
																	   13:
																	   osquery_carver_tests-test
																	     13/70
																	     Test
																	     #13:
																	     osquery_carver_tests-test
																	     .....................................
																	     Passed
																	     2.88
																	     sec
																	             Start
																		     14:
																		     osquery_tables_events_tests_fileeventstests-test
																		       14/70
																		       Test
																		       #14:
																		       osquery_tables_events_tests_fileeventstests-test
																		       ..............
																		       Passed
																		       3.09
																		       sec
																		               Start
																			       15:
																			       osquery_tables_networking_tests_networkingtablestests-test
																			         15/70
																				 Test
																				 #15:
																				 osquery_tables_networking_tests_networkingtablestests-test
																				 ....
																				 Passed
																				 5.22
																				 sec
																				         Start
																					 16:
																					 osquery_tables_system_tests_certificatestests-test
																					   16/70
																					   Test
																					   #16:
																					   osquery_tables_system_tests_certificatestests-test
																					   ............
																					   Passed
																					   2.99
																					   sec
																					           Start
																						   17:
																						   osquery_tables_system_tests_registrytests-test
																						     17/70
																						     Test
																						     #17:
																						     osquery_tables_system_tests_registrytests-test
																						     ................
																						     Passed
																						     3.65
																						     sec
																						             Start
																							     18:
																							     osquery_tables_system_tests_systemtablestests-test
																							       18/70
																							       Test
																							       #18:
																							       osquery_tables_system_tests_systemtablestests-test
																							       ............
																							       Passed
																							       7.32
																							       sec
																							               Start
																								       19:
																								       osquery_remote_tests_requeststests-test
																								         19/70
																									 Test
																									 #19:
																									 osquery_remote_tests_requeststests-test
																									 .......................
																									 Passed
																									 2.37
																									 sec
																									         Start
																										 20:
																										 osquery_remote_serializers_remotejsonserializerstests-test
																										   20/70
																										   Test
																										   #20:
																										   osquery_remote_serializers_remotejsonserializerstests-test
																										   ....
																										   Passed
																										   1.59
																										   sec
																										           Start
																											   21:
																											   osquery_remote_enroll_remoteenrolltests-test
																											     21/70
																											     Test
																											     #21:
																											     osquery_remote_enroll_remoteenrolltests-test
																											     ..................
																											     Passed
																											     2.89
																											     sec
																											             Start
																												     22:
																												     osquery_core_tests_flagstests-test
																												       22/70
																												       Test
																												       #22:
																												       osquery_core_tests_flagstests-test
																												       ............................
																												       Passed
																												       3.18
																												       sec
																												               Start
																													       23:
																													       osquery_core_tests_systemtests-test
																													         23/70
																														 Test
																														 #23:
																														 osquery_core_tests_systemtests-test
																														 ...........................
																														 Passed
																														 3.19
																														 sec
																														         Start
																															 24:
																															 osquery_core_tests_tablestests-test
																															   24/70
																															   Test
																															   #24:
																															   osquery_core_tests_tablestests-test
																															   ...........................
																															   Passed
																															   2.97
																															   sec
																															           Start
																																   25:
																																   osquery_core_tests_watcherpermissionstests-test
																																     25/70
																																     Test
																																     #25:
																																     osquery_core_tests_watcherpermissionstests-test
																																     ...............
																																     Passed
																																     3.27
																																     sec
																																             Start
																																	     26:
																																	     osquery_core_tests_querytests-test
																																	       26/70
																																	       Test
																																	       #26:
																																	       osquery_core_tests_querytests-test
																																	       ............................
																																	       Passed
																																	       3.50
																																	       sec
																																	               Start
																																		       27:
																																		       osquery_core_tests_processtests-test
																																		         27/70
																																			 Test
																																			 #27:
																																			 osquery_core_tests_processtests-test
																																			 ..........................
																																			 Passed
																																			 4.31
																																			 sec
																																			         Start
																																				 28:
																																				 osquery_config_tests-test
																																				   28/70
																																				   Test
																																				   #28:
																																				   osquery_config_tests-test
																																				   .....................................***Failed
																																				   14.43
																																				   sec
																																				           Start
																																					   29:
																																					   osquery_config_tests_packs-test
																																					     29/70
																																					     Test
																																					     #29:
																																					     osquery_config_tests_packs-test
																																					     ...............................
																																					     Passed
																																					     2.90
																																					     sec
																																					             Start
																																						     30:
																																						     osquery_utils_utilstests-test
																																						       30/70
																																						       Test
																																						       #30:
																																						       osquery_utils_utilstests-test
																																						       .................................
																																						       Passed
																																						       2.09
																																						       sec
																																						               Start
																																							       31:
																																							       osquery_utils_aws_tests-test
																																							         31/70
																																								 Test
																																								 #31:
																																								 osquery_utils_aws_tests-test
																																								 ..................................
																																								 Passed
																																								 3.11
																																								 sec
																																								         Start
																																									 32:
																																									 osquery_utils_caches_tests_lrutests-test
																																									   32/70
																																									   Test
																																									   #32:
																																									   osquery_utils_caches_tests_lrutests-test
																																									   ......................
																																									   Passed
																																									   1.49
																																									   sec
																																									           Start
																																										   33:
																																										   osquery_utils_system_errno_errnotests-test
																																										     33/70
																																										     Test
																																										     #33:
																																										     osquery_utils_system_errno_errnotests-test
																																										     ....................
																																										     Passed
																																										     1.53
																																										     sec
																																										             Start
																																											     34:
																																											     osquery_utils_system_time_timetest-test
																																											       34/70
																																											       Test
																																											       #34:
																																											       osquery_utils_system_time_timetest-test
																																											       .......................
																																											       Passed
																																											       1.45
																																											       sec
																																											               Start
																																												       35:
																																												       osquery_utils_system_linux_proc_proctests-test
																																												         35/70
																																													 Test
																																													 #35:
																																													 osquery_utils_system_linux_proc_proctests-test
																																													 ................
																																													 Passed
																																													 0.96
																																													 sec
																																													         Start
																																														 36:
																																														 osquery_utils_status_statustests-test
																																														   36/70
																																														   Test
																																														   #36:
																																														   osquery_utils_status_statustests-test
																																														   .........................
																																														   Passed
																																														   1.50
																																														   sec
																																														           Start
																																															   37:
																																															   osquery_utils_json_jsontests-test
																																															     37/70
																																															     Test
																																															     #37:
																																															     osquery_utils_json_jsontests-test
																																															     .............................
																																															     Passed
																																															     1.71
																																															     sec
																																															             Start
																																																     38:
																																																     osquery_utils_error_errortests-test
																																																       38/70
																																																       Test
																																																       #38:
																																																       osquery_utils_error_errortests-test
																																																       ...........................
																																																       Passed
																																																       2.09
																																																       sec
																																																               Start
																																																	       39:
																																																	       osquery_utils_debug_debugtests-test
																																																	         39/70
																																																		 Test
																																																		 #39:
																																																		 osquery_utils_debug_debugtests-test
																																																		 ...........................
																																																		 Passed
																																																		 1.60
																																																		 sec
																																																		         Start
																																																			 40:
																																																			 osquery_utils_expected_expectedtests-test
																																																			   40/70
																																																			   Test
																																																			   #40:
																																																			   osquery_utils_expected_expectedtests-test
																																																			   .....................
																																																			   Passed
																																																			   1.64
																																																			   sec
																																																			           Start
																																																				   41:
																																																				   osquery_utils_conversions_windowstests-test
																																																				     41/70
																																																				     Test
																																																				     #41:
																																																				     osquery_utils_conversions_windowstests-test
																																																				     ...................
																																																				     Passed
																																																				     3.00
																																																				     sec
																																																				             Start
																																																					     42:
																																																					     osquery_utils_conversions_conversionstests-test
																																																					       42/70
																																																					       Test
																																																					       #42:
																																																					       osquery_utils_conversions_conversionstests-test
																																																					       ...............
																																																					       Passed
																																																					       1.43
																																																					       sec
																																																					               Start
																																																						       43:
																																																						       osquery_utils_conversions_totests-test
																																																						         43/70
																																																							 Test
																																																							 #43:
																																																							 osquery_utils_conversions_totests-test
																																																							 ........................
																																																							 Passed
																																																							 1.37
																																																							 sec
																																																							         Start
																																																								 44:
																																																								 osquery_utils_versioning_semanticversiontest-test
																																																								   44/70
																																																								   Test
																																																								   #44:
																																																								   osquery_utils_versioning_semanticversiontest-test
																																																								   .............
																																																								   Passed
																																																								   1.95
																																																								   sec
																																																								           Start
																																																									   45:
																																																									   osquery_utils_schemer_tests_schemertests-test
																																																									     45/70
																																																									     Test
																																																									     #45:
																																																									     osquery_utils_schemer_tests_schemertests-test
																																																									     .................
																																																									     Passed
																																																									     1.76
																																																									     sec
																																																									             Start
																																																										     46:
																																																										     osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       46/70
																																																										       Test
																																																										       #46:
																																																										       osquery_utils_schemer_json_tests_schemerjsontests-test
																																																										       ........
																																																										       Passed
																																																										       1.78
																																																										       sec
																																																										               Start
																																																											       47:
																																																											       osquery_filesystem_filesystemtests-test
																																																											         47/70
																																																												 Test
																																																												 #47:
																																																												 osquery_filesystem_filesystemtests-test
																																																												 .......................
																																																												 Passed
																																																												 3.86
																																																												 sec
																																																												         Start
																																																													 48:
																																																													 osquery_database_tests-test
																																																													   48/70
																																																													   Test
																																																													   #48:
																																																													   osquery_database_tests-test
																																																													   ...................................
																																																													   Passed
																																																													   2.79
																																																													   sec
																																																													           Start
																																																														   49:
																																																														   osquery_database_tests_results-test
																																																														     49/70
																																																														     Test
																																																														     #49:
																																																														     osquery_database_tests_results-test
																																																														     ...........................
																																																														     Passed
																																																														     3.12
																																																														     sec
																																																														             Start
																																																															     50:
																																																															     osquery_devtools_tests_printertests-test
																																																															       50/70
																																																															       Test
																																																															       #50:
																																																															       osquery_devtools_tests_printertests-test
																																																															       ......................
																																																															       Passed
																																																															       2.96
																																																															       sec
																																																															               Start
																																																																       51:
																																																																       osquery_extensions_extensiontests-test
																																																																         51/70
																																																																	 Test
																																																																	 #51:
																																																																	 osquery_extensions_extensiontests-test
																																																																	 ........................
																																																																	 Passed
																																																																	 7.42
																																																																	 sec
																																																																	         Start
																																																																		 52:
																																																																		 osquery_events_tests_eventsdatabasetests-test
																																																																		   52/70
																																																																		   Test
																																																																		   #52:
																																																																		   osquery_events_tests_eventsdatabasetests-test
																																																																		   .................
																																																																		   Passed
																																																																		   3.03
																																																																		   sec
																																																																		           Start
																																																																			   53:
																																																																			   osquery_events_tests_windowseventlogtests-test
																																																																			     53/70
																																																																			     Test
																																																																			     #53:
																																																																			     osquery_events_tests_windowseventlogtests-test
																																																																			     ................
																																																																			     Passed
																																																																			     3.00
																																																																			     sec
																																																																			             Start
																																																																				     54:
																																																																				     osquery_events_tests-test
																																																																				       54/70
																																																																				       Test
																																																																				       #54:
																																																																				       osquery_events_tests-test
																																																																				       .....................................
																																																																				       Passed
																																																																				       3.40
																																																																				       sec
																																																																				               Start
																																																																					       55:
																																																																					       osquery_ev2_ev2tests-test
																																																																					         55/70
																																																																						 Test
																																																																						 #55:
																																																																						 osquery_ev2_ev2tests-test
																																																																						 .....................................
																																																																						 Passed
																																																																						 1.62
																																																																						 sec
																																																																						         Start
																																																																							 56:
																																																																							 osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   56/70
																																																																							   Test
																																																																							   #56:
																																																																							   osquery_system_network_tests_hostnamehostidentitytests-test
																																																																							   ...
																																																																							   Passed
																																																																							   2.95
																																																																							   sec
																																																																							           Start
																																																																								   57:
																																																																								   plugins_config_parsers_tests_decoratorstests-test
																																																																								     57/70
																																																																								     Test
																																																																								     #57:
																																																																								     plugins_config_parsers_tests_decoratorstests-test
																																																																								     .............
																																																																								     Passed
																																																																								     5.43
																																																																								     sec
																																																																								             Start
																																																																									     58:
																																																																									     plugins_config_parsers_tests_eventsparsertests-test
																																																																									       58/70
																																																																									       Test
																																																																									       #58:
																																																																									       plugins_config_parsers_tests_eventsparsertests-test
																																																																									       ...........
																																																																									       Passed
																																																																									       3.82
																																																																									       sec
																																																																									               Start
																																																																										       59:
																																																																										       plugins_config_parsers_tests_filepathstests-test
																																																																										         59/70
																																																																											 Test
																																																																											 #59:
																																																																											 plugins_config_parsers_tests_filepathstests-test
																																																																											 ..............
																																																																											 Passed
																																																																											 6.13
																																																																											 sec
																																																																											         Start
																																																																												 60:
																																																																												 plugins_config_parsers_tests_optionstests-test
																																																																												   60/70
																																																																												   Test
																																																																												   #60:
																																																																												   plugins_config_parsers_tests_optionstests-test
																																																																												   ................
																																																																												   Passed
																																																																												   3.85
																																																																												   sec
																																																																												           Start
																																																																													   61:
																																																																													   plugins_config_parsers_tests_viewstests-test
																																																																													     61/70
																																																																													     Test
																																																																													     #61:
																																																																													     plugins_config_parsers_tests_viewstests-test
																																																																													     ..................
																																																																													     Passed
																																																																													     4.13
																																																																													     sec
																																																																													             Start
																																																																														     62:
																																																																														     plugins_database_tests_rocksdbtests-test
																																																																														       62/70
																																																																														       Test
																																																																														       #62:
																																																																														       plugins_database_tests_rocksdbtests-test
																																																																														       ......................
																																																																														       Passed
																																																																														       4.00
																																																																														       sec
																																																																														               Start
																																																																															       63:
																																																																															       plugins_database_tests_sqliteplugintests-test
																																																																															         63/70
																																																																																 Test
																																																																																 #63:
																																																																																 plugins_database_tests_sqliteplugintests-test
																																																																																 .................
																																																																																 Passed
																																																																																 3.56
																																																																																 sec
																																																																																         Start
																																																																																	 64:
																																																																																	 plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   64/70
																																																																																	   Test
																																																																																	   #64:
																																																																																	   plugins_killswitch_killswitchfilesystemplugintests-test
																																																																																	   .......
																																																																																	   Passed
																																																																																	   3.17
																																																																																	   sec
																																																																																	           Start
																																																																																		   65:
																																																																																		   plugins_logger_tests_awskinesisloggertests-test
																																																																																		     65/70
																																																																																		     Test
																																																																																		     #65:
																																																																																		     plugins_logger_tests_awskinesisloggertests-test
																																																																																		     ...............
																																																																																		     Passed
																																																																																		     3.60
																																																																																		     sec
																																																																																		             Start
																																																																																			     66:
																																																																																			     plugins_logger_tests_bufferedloggertests-test
																																																																																			       66/70
																																																																																			       Test
																																																																																			       #66:
																																																																																			       plugins_logger_tests_bufferedloggertests-test
																																																																																			       .................
																																																																																			       Passed
																																																																																			       3.00
																																																																																			       sec
																																																																																			               Start
																																																																																				       67:
																																																																																				       plugins_logger_tests_filesystemloggertests-test
																																																																																				         67/70
																																																																																					 Test
																																																																																					 #67:
																																																																																					 plugins_logger_tests_filesystemloggertests-test
																																																																																					 ...............
																																																																																					 Passed
																																																																																					 3.20
																																																																																					 sec
																																																																																					         Start
																																																																																						 68:
																																																																																						 plugins_logger_tests_tlsloggertests-test
																																																																																						   68/70
																																																																																						   Test
																																																																																						   #68:
																																																																																						   plugins_logger_tests_tlsloggertests-test
																																																																																						   ......................
																																																																																						   Passed
																																																																																						   11.05
																																																																																						   sec
																																																																																						           Start
																																																																																							   69:
																																																																																							   plugins_numericmonitoring_tests_filesystem-test
																																																																																							     69/70
																																																																																							     Test
																																																																																							     #69:
																																																																																							     plugins_numericmonitoring_tests_filesystem-test
																																																																																							     ...............
																																																																																							     Passed
																																																																																							     3.03
																																																																																							     sec
																																																																																							             Start
																																																																																								     70:
																																																																																								     tests_integration_tables-test
																																																																																								       70/70
																																																																																								       Test
																																																																																								       #70:
																																																																																								       tests_integration_tables-test
																																																																																								       .................................
																																																																																								       Passed
																																																																																								       24.91
																																																																																								       sec

																																																																																								         99%
																																																																																									 tests
																																																																																									 passed,
																																																																																									 1
																																																																																									 tests
																																																																																									 failed
																																																																																									 out
																																																																																									 of
																																																																																									 70

																																																																																									   Total
																																																																																									   Test
																																																																																									   time
																																																																																									   (real)
																																																																																									   =
																																																																																									   258.07
																																																																																									   sec

																																																																																									     The
																																																																																									     following
																																																																																									     tests
																																																																																									     FAILED:
																																																																																									              28
																																																																																										      -
																																																																																										      osquery_config_tests-test
																																																																																										      (Failed)
																																																																																										        Errors
																																																																																											while
																																																																																											running
																																																																																											CTest
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											The
																																																																																											command
																																																																																											"setlocal
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											"C:\Program
																																																																																											Files\CMake\bin\ctest.exe"
																																																																																											--force-new-ctest-process
																																																																																											-C
																																																																																											RelWithDebInfo
																																																																																											[C:\Users\thor\work\repos\osquery\build\
																																																																																											windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											endlocal
																																																																																											&
																																																																																											call
																																																																																											:cmErrorLevel
																																																																																											%errorlevel%
																																																																																											&
																																																																																											goto
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxpr
																																																																																											oj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmErrorLevel
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											exit
																																																																																											/b
																																																																																											%1
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:cmDone
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											if
																																																																																											%errorlevel%
																																																																																											neq
																																																																																											0
																																																																																											goto
																																																																																											:VCEnd
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
																																																																																											C:\Program
																																																																																											Files
																																																																																											(x86)\Microsoft
																																																																																											Visual
																																																																																											Studio\2019\Community\MSBuild\Microsoft\VC\v150\Microsoft.CppCommon.targets(138,5):
																																																																																											error
																																																																																											MSB3073:
																																																																																											:VCEnd"
																																																																																											exited
																																																																																											with
																																																																																											code
																																																																																											8.
																																																																																											[C:\Users\thor\work\repos\osquery\build\windows10\run_tests.vcxproj]
```
aikuchin pushed a commit to aikuchin/osquery that referenced this issue Jul 11, 2023
…0 to master

* commit '367b03dd1baeb99506de13a897eff0456c287791': (46 commits)
  4.9.0 Changelog (osquery#7152)
  packaging: update rendered chocolatey spec icon URL (osquery#7148)
  Add additional paths to `apps` and `launchd` (osquery#7154)
  custom curl_certificate timeouts would never be used (osquery#7151)
  Add current WMI location for dell bios info (osquery#7103)
  enable other stats on containers that don't have traditional networks (osquery#7145)
  Add Prefetch table (osquery#7076)
  Add detection/handling for updated XProtect path in macOS Big Sur (osquery#7138)
  Trigger event cleanup checks every 256 events (osquery#7143)
  pipe_channel not reading all data in a message (osquery#7139)
  libs: Update libyara to version 4.1.1 (osquery#7133)
  libs: Update librdkafka to version 1.7.0 (osquery#7134)
  Update website generators (osquery#7136)
  7118: Make generaing an extension uuid thread safe (osquery#7135)
  Alternate check for packageIdentifiers key (osquery#7099)
  Website: Note windows support for yara (osquery#7130)
  Fix crash and deadlocks in the support for recursive logging (osquery#7127)
  Implement infinite enrollment retries with tls_enrollment_max_attempts=0 (osquery#7125)
  Remove POSIX-only -fexceptions on Windows (osquery#7126)
  Minor cleanup of unused variables (osquery#7128)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants