corrected size in block_devices on darwin, linux (#3538) #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
cla signed
|
ok to test |
vishwa35
force-pushed
the
fix-block-devices-size
branch
from
7078819
to
5b3c0b0
Compare
|
@vishwa35 updated the pull request - view changes |
vishwa35
force-pushed
the
fix-block-devices-size
branch
from
5b3c0b0
to
f27e873
Compare
|
@vishwa35 updated the pull request - view changes |
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issues from #3538. Am open to modifying this to display size in bytes, but left it in block units to preserve current Linux implementation.