Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tables: Add constraints and testing #6105

Merged
merged 22 commits into from
Dec 13, 2019

Conversation

directionless
Copy link
Member

@directionless directionless commented Dec 7, 2019

After #6103 I thought I'd take a pass at the spec files and tests. Not totally sure on all of these.

Also adds an IntOrEmpty type to the validation map

Requires: #6104

Relates To: #5932

specs/carves.table Show resolved Hide resolved
specs/darwin/running_apps.table Outdated Show resolved Hide resolved
specs/posix/docker_container_mounts.table Show resolved Hide resolved
specs/posix/docker_container_networks.table Show resolved Hide resolved
specs/posix/docker_container_processes.table Show resolved Hide resolved
tests/integration/tables/keychain_items.cpp Outdated Show resolved Hide resolved
tests/integration/tables/ntfs_acl_permissions.cpp Outdated Show resolved Hide resolved
tests/integration/tables/preferences.cpp Outdated Show resolved Hide resolved
tests/integration/tables/preferences.cpp Outdated Show resolved Hide resolved
tests/integration/tables/process_open_sockets.cpp Outdated Show resolved Hide resolved
@directionless directionless added this to the 4.1.2 milestone Dec 10, 2019
@theopolis
Copy link
Member

85: [----------] 1 test from processOpenSockets
85: [ RUN      ] processOpenSockets.test_sanity
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/helper.cpp:162: Failure
85: Expected: (validation_map.count(rec.first)) != (std::size_t{0}), actual: 0 vs 0
85: Unexpected column "net_namespace" in a row
85: [  FAILED  ] processOpenSockets.test_sanity (10 ms)
85: [----------] 1 test from processOpenSockets (10 ms total)
85: [----------] 1 test from pythonPackages
85: [ RUN      ] pythonPackages.test_sanity
85: /__w/1/s/usr/src/debug/osquery/tests/integration/tables/python_packages.cpp:36: Failure
85: Value of: data.empty()
85:   Actual: true
85: Expected: false
85: [  FAILED  ] pythonPackages.test_sanity (1 ms)
85: [----------] 1 test from pythonPackages (1 ms total)

@theopolis theopolis force-pushed the seph/table-constraint branch 2 times, most recently from a9b75cb to ff155b7 Compare December 12, 2019 00:54
@theopolis theopolis merged commit a73ffad into osquery:master Dec 13, 2019
@directionless directionless deleted the seph/table-constraint branch December 17, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants