Fix format_check.py failing on Windows with Python 3.7 #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theopolis
previously approved these changes
Jan 18, 2020
- The output from the git subprocess has to be decoded from bytes to str before passing it as an argument of a new subprocess. - Use the python interpreter of the current script to run git-clang-format.py.
Smjert
force-pushed
the
stefano/fix/format-check-windows
branch
from
0c41ffa
to
09481b0
Compare
|
@theopolis thanks and sorry, had a nit on the commit message, |
theopolis
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output from the git subprocess has to be decoded from bytes
to str before passing it as an argument of a new subprocess.
Use the python interpreter of the current script to run git-clang-format.py.
Closes #6089